mirror of
https://github.com/microsoft/PowerToys
synced 2024-11-22 00:03:48 +00:00
ce5e5647b3
After we upgraded Windows App SDK to 1.6, Dev Files Preview on Peek has been broken on ARM64. For .86, we've added WebView2 to Registry Preview in order to have Monaco Editor as the text editor, which is also broken on ARM64. After a lengthy investigation, it seems we've found the core issue, PowerToys has been shipping with a x64 Microsoft.Web.WebView2.Core.dll in the ARM64 installer, which fails at runtime. We seem to have hit a version of https://github.com/microsoft/WindowsAppSDK/issues/4826 When we build PowerToys in Dart for release, we publish some of the C# WinUI3Apps after building PowerToys and before signing / building the install. This means that the WindowsAppSDK build will recopy its WebView2 dependency, which for some reason is ARM64. On local builds of PowerToys, PowerRename, a C++ WinAppSDK application finished last, which copies the right dll and it's the reason we weren't being able to repro the issue on local builds of ARM64 PowerToys. This PR solves the issue by including a short time hack in the CI to copy the right dll after publishing the C# WinUI3Apps when building for ARM64. ## Validation Steps Performed Waiting for 4 concurrent builds of ARM64 from Dart to test whether the problem is solved. |
||
|---|---|---|
| .. | ||
| loc | ||
| v2 | ||
| applyXamlStyling.ps1 | ||
| CIPolicy.xml | ||
| ESRPSigning_abstracted_utils_dll.json | ||
| ESRPSigning_core.json | ||
| ESRPSigning_DSC.json | ||
| ESRPSigning_installer.json | ||
| ESRPSigning_vcm.json | ||
| InstallWinAppDriver.ps1 | ||
| installWiX.ps1 | ||
| packages.config | ||
| release-nuget.config | ||
| tsa.json | ||
| verifyAndSetLatestVCToolsVersion.ps1 | ||
| verifyArm64Configuration.ps1 | ||
| verifyDepsJsonLibraryVersions.ps1 | ||
| verifyNoticeMdAgainstNugetPackages.ps1 | ||
| verifyNugetPackages.ps1 | ||
| verifyPossibleAssetConflicts.ps1 | ||
| versionAndSignCheck.ps1 | ||
| versionSetting.ps1 | ||