mirrors/VTable
1
0
Fork 0
mirror of https://github.com/VisActor/VTable synced 2024-11-22 01:52:03 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #2857 from VisActor/2830-bug-editor-validatevalue-repeatedly

Browse Source 
2830 bug editor validatevalue repeatedly
This commit is contained in:
方帅 2024-11-19 19:13:59 +08:00 committed by GitHub
commit 8b78f2cd49
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
common/changes/@visactor/vtable/2830-bug-editor-validatevalue-repeatedly_2024-11-18-07-08.json Normal file
View File

@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: add isValidatingValue state to fix call validateValue api repeatedly #2830\n\n",
"type": "none",
"packageName": "@visactor/vtable"
}
],
"packageName": "@visactor/vtable",
"email": "892739385@qq.com"
}

9
packages/vtable/src/edit/edit-manager.ts
View File

@ -10,6 +10,7 @@ import { isValid } from '@visactor/vutils';
export class EditManeger {
table: BaseTableAPI;
editingEditor: IEditor;
isValidatingValue: boolean = false;
editCell: { col: number; row: number };
constructor(table: BaseTableAPI) {
@ -121,7 +122,9 @@ export class EditManeger {
if (!this.editingEditor) {
return true;
}
if (this.isValidatingValue) {
return false;
}
const target = e?.target as HTMLElement | undefined;
const { editingEditor: editor } = this;
@ -141,6 +144,7 @@ export class EditManeger {
console.warn('VTable Warn: `getValue` is not provided, did you forget to implement it?');
}
if (this.editingEditor.validateValue) {
this.isValidatingValue = true;
const maybePromiseOrValue = this.editingEditor.validateValue?.();
if (isPromise(maybePromiseOrValue)) {
return new Promise((resolve, reject) => {
@ -150,10 +154,12 @@ export class EditManeger {
this.doExit();
resolve(true);
} else {
this.isValidatingValue = false;
resolve(false);
}
})
.catch((err: Error) => {
this.isValidatingValue = false;
console.error('VTable Error:', err);
reject(err);
});
@ -184,6 +190,7 @@ export class EditManeger {
this.editingEditor.exit?.();
this.editingEditor.onEnd?.();
this.editingEditor = null;
this.isValidatingValue = false;
}
cancelEdit() {