fixed changing editor theme #300

packages/api/src/controllers/config.js

@@ -59,13 +59,10 @@ module.exports = {
 
   getSettings_meta: true,
   async getSettings() {
-    try {
+    const res = await lock.acquire('settings', async () => {
-      return this.fillMissingSettings(
+      return await this.loadSettings();
-        JSON.parse(await fs.readFile(path.join(datadir(), 'settings.json'), { encoding: 'utf-8' }))
+    });
-      );
+    return res;
-    } catch (err) {
-      return this.fillMissingSettings({});
-    }
   },
 
   fillMissingSettings(value) {
@@ -79,12 +76,21 @@ module.exports = {
     return res;
   },
 
+  async loadSettings() {
+    try {
+      const settingsText = await fs.readFile(path.join(datadir(), 'settings.json'), { encoding: 'utf-8' });
+      return this.fillMissingSettings(JSON.parse(settingsText));
+    } catch (err) {
+      return this.fillMissingSettings({});
+    }
+  },
+
   updateSettings_meta: true,
   async updateSettings(values, req) {
     if (!hasPermission(`settings/change`, req)) return false;
 
-    const res = await lock.acquire('update', async () => {
+    const res = await lock.acquire('settings', async () => {
-      const currentValue = await this.getSettings();
+      const currentValue = await this.loadSettings();
       try {
         const updated = {
           ...currentValue,

packages/web/src/stores.ts

@@ -29,7 +29,11 @@ export function writableWithStorage<T>(defaultValue: T, storageName) {
 }
 
 export function writableSettingsValue<T>(defaultValue: T, storageName) {
-  const res = derived(useSettings(), $settings => ($settings || {})[storageName] ?? defaultValue);
+  const res = derived(useSettings(), $settings => {
+    const obj = $settings || {};
+    // console.log('GET SETTINGS', $settings, storageName, obj[storageName]);
+    return obj[storageName] ?? defaultValue;
+  });
   return {
     ...res,
     set: value => apiCall('config/update-settings', { [storageName]: value }),

packages/web/src/utility/metadataLoaders.ts

@@ -189,25 +189,29 @@ async function getCore(loader, args) {
 function useCore(loader, args) {
   const { url, params, reloadTrigger, transform, onLoaded } = loader(args);
   const cacheKey = stableStringify({ url, ...params });
-  let closed = false;
+  let openedCount = 0;
 
   return {
     subscribe: onChange => {
       async function handleReload() {
         const res = await getCore(loader, args);
-        if (!closed) {
+        if (openedCount > 0) {
           onChange(res);
         }
       }
-
+      openedCount += 1;
       handleReload();
 
       if (reloadTrigger) {
         subscribeCacheChange(reloadTrigger, cacheKey, handleReload);
         return () => {
-          closed = true;
+          openedCount -= 1;
           unsubscribeCacheChange(reloadTrigger, cacheKey, handleReload);
         };
+      } else {
+        return () => {
+          openedCount -= 1;
+        };
       }
     },
   };