From 530b1cade362c551500dfe5411dc47d67a1658ea Mon Sep 17 00:00:00 2001
From: Jan Prochazka <jan.prochazka@gmail.com>
Date: Mon, 8 Aug 2022 19:40:50 +0200
Subject: [PATCH] perspective UX

---
 packages/web/src/datagrid/DataFilterControl.svelte            | 3 ++-
 packages/web/src/perspectives/PerspectiveFiltersColumn.svelte | 1 +
 packages/web/src/perspectives/PerspectiveTable.svelte         | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/packages/web/src/datagrid/DataFilterControl.svelte b/packages/web/src/datagrid/DataFilterControl.svelte
index 2d5bf7d4..d8649a0b 100644
--- a/packages/web/src/datagrid/DataFilterControl.svelte
+++ b/packages/web/src/datagrid/DataFilterControl.svelte
@@ -32,6 +32,7 @@
   export let jslid = null;
   export let customCommandIcon = null;
   export let onCustomCommand = null;
+  export let customCommandTooltip = null;
 
   export let pureName = null;
   export let schemaName = null;
@@ -298,7 +299,7 @@
     placeholder="Filter"
   />
   {#if customCommandIcon && onCustomCommand}
-    <InlineButton on:click={onCustomCommand} narrow square>
+    <InlineButton on:click={onCustomCommand} title={customCommandTooltip} narrow square>
       <FontIcon icon={customCommandIcon} />
     </InlineButton>
   {/if}
diff --git a/packages/web/src/perspectives/PerspectiveFiltersColumn.svelte b/packages/web/src/perspectives/PerspectiveFiltersColumn.svelte
index 644fea36..953718ad 100644
--- a/packages/web/src/perspectives/PerspectiveFiltersColumn.svelte
+++ b/packages/web/src/perspectives/PerspectiveFiltersColumn.svelte
@@ -78,5 +78,6 @@
     foreignKey={filterInfo.foreignKey}
     {customCommandIcon}
     onCustomCommand={customCommandIcon ? changeParentFilter : null}
+    customCommandTooltip='Filter parent rows'
   />
 </div>
diff --git a/packages/web/src/perspectives/PerspectiveTable.svelte b/packages/web/src/perspectives/PerspectiveTable.svelte
index 4b700090..1bbf1392 100644
--- a/packages/web/src/perspectives/PerspectiveTable.svelte
+++ b/packages/web/src/perspectives/PerspectiveTable.svelte
@@ -285,7 +285,7 @@
                       filters: {
                         [dataNode.columnName]: getFilterValueExpression(value, dataNode.column.dataType),
                       },
-                      isFormView: true,
+                      // isFormView: true,
                     },
                   },
                   {