From 8035380e7b53b6bc32c0fdc4fc615c11f826ab81 Mon Sep 17 00:00:00 2001 From: Jan Prochazka Date: Tue, 19 Nov 2024 10:34:49 +0100 Subject: [PATCH] commented handle autoincrement change --- .../__tests__/alter-table.spec.js | 16 ++++++------- packages/tools/src/alterPlan.ts | 24 +++++++++---------- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/integration-tests/__tests__/alter-table.spec.js b/integration-tests/__tests__/alter-table.spec.js index a7157b86..afe1c9a6 100644 --- a/integration-tests/__tests__/alter-table.spec.js +++ b/integration-tests/__tests__/alter-table.spec.js @@ -167,13 +167,13 @@ describe('Alter table', () => { }) ); - test.each(engines.map(engine => [engine.label, engine]))( - 'Change autoincrement - %s', - testWrapper(async (conn, driver, engine) => { - await testTableDiff(engine, conn, driver, tbl => { - tbl.columns.find(x => x.columnName == 'col_pk').autoIncrement = true; - }); - }) - ); + // test.each(engines.map(engine => [engine.label, engine]))( + // 'Change autoincrement - %s', + // testWrapper(async (conn, driver, engine) => { + // await testTableDiff(engine, conn, driver, tbl => { + // tbl.columns.find(x => x.columnName == 'col_pk').autoIncrement = true; + // }); + // }) + // ); }); diff --git a/packages/tools/src/alterPlan.ts b/packages/tools/src/alterPlan.ts index 4f837a8c..d049fa46 100644 --- a/packages/tools/src/alterPlan.ts +++ b/packages/tools/src/alterPlan.ts @@ -416,12 +416,12 @@ export class AlterPlan { this._testTableRecreate(op, 'createConstraint', obj => this._canCreateConstraint(obj), 'newObject') || this._testTableRecreate(op, 'dropConstraint', obj => this._canDropConstraint(obj), 'oldObject') || this._testTableRecreate(op, 'changeColumn', this.dialect.changeColumn, 'newObject') || - this._testTableRecreate( - op, - 'changeColumn', - obj => this._canChangeAutoIncrement(obj, op as AlterOperation_ChangeColumn), - 'newObject' - ) || + // this._testTableRecreate( + // op, + // 'changeColumn', + // obj => this._canChangeAutoIncrement(obj, op as AlterOperation_ChangeColumn), + // 'newObject' + // ) || this._testTableRecreate(op, 'renameColumn', true, 'object') || [op] ); }); @@ -449,12 +449,12 @@ export class AlterPlan { return null; } - _canChangeAutoIncrement(column: ColumnInfo, op: AlterOperation_ChangeColumn) { - if (!!column.autoIncrement != !!op.oldObject.autoIncrement) { - return this.dialect.changeAutoIncrement; - } - return null; - } + // _canChangeAutoIncrement(column: ColumnInfo, op: AlterOperation_ChangeColumn) { + // if (!!column.autoIncrement != !!op.oldObject.autoIncrement) { + // return this.dialect.changeAutoIncrement; + // } + // return null; + // } _testTableRecreate( op: AlterOperation,