mirrors/dbgate
1
0
Fork 0
mirror of https://github.com/dbgate/dbgate synced 2024-11-07 20:26:23 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

performance comments

Browse Source
This commit is contained in:
Jan Prochazka 2021-01-14 10:45:24 +01:00
parent f60ee04883
commit f2dbe1f103
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/web/src/datagrid/DataGrid.js
View File

@ -45,7 +45,13 @@ export default function DataGrid(props) {
<ReferenceManager {...props} managerSize={managerSize} />
</WidgetColumnBarItem>
)}
<WidgetColumnBarItem title="Cell data" name="cellData" collapsed>
<WidgetColumnBarItem
title="Cell data"
name="cellData"
// cell data must be collapsed by default, because of performance reasons
// when not collapsed, onSelectionChanged of grid is set and RERENDER of this component is done on every selection change
collapsed
>
{isFormView ? (
<CellDataView selectedValue={formSelection} />
) : (

3
packages/web/src/datagrid/DataGridCore.js
View File

@ -1062,6 +1062,9 @@ export default function DataGridCore(props) {
{_.range(firstVisibleRowScrollIndex, firstVisibleRowScrollIndex + visibleRowCountUpperBound).map(
(rowIndex) => (
<DataGridRow
// this component use React.memo
// when adding props, check, whether they are correctly memoized and row is not rerendered
// uncomment line console.log('RENDER ROW', rowIndex); in DataGridRow.js for check
key={rowIndex}
grider={grider}
rowIndex={rowIndex}