mirrors/fort
1
0
Fork 0
mirror of https://github.com/tnodir/fort synced 2024-11-15 12:05:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Review TODO-s.

Browse Source
This commit is contained in:
Nodir Temirkhodjaev 2021-03-20 13:38:47 +03:00
parent 4e5e0254d2
commit e200aec5d4
4 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/driver/fortpkt.c
View File

@ -111,7 +111,8 @@ static PFORT_PACKET fort_defer_packet_get(PFORT_DEFER defer)
const tommy_size_t size = tommy_arrayof_size(&defer->packets); const tommy_size_t size = tommy_arrayof_size(&defer->packets);
/* TODO: tommy_arrayof_grow(): check calloc()'s result for NULL */ /* TODO: tommy_arrayof_grow(): check calloc()'s result for NULL */
tommy_arrayof_grow(&defer->packets, size + 1); if (tommy_arrayof_grow(&defer->packets, size + 1), 0)
return NULL;
pkt = tommy_arrayof_ref(&defer->packets, size); pkt = tommy_arrayof_ref(&defer->packets, size);
} }

4
src/ui/form/conn/connectionswindow.cpp
View File

@ -192,7 +192,7 @@ void ConnectionsWindow::setupLogAllowedIp()
fortManager()->applyConfImmediateFlags(); fortManager()->applyConfImmediateFlags();
}); });
m_cbLogAllowedIp->setVisible(false); // TODO m_cbLogAllowedIp->setVisible(false); // TODO: Collect allowed connections
} }
void ConnectionsWindow::setupLogBlockedIp() void ConnectionsWindow::setupLogBlockedIp()
@ -239,7 +239,7 @@ void ConnectionsWindow::setupTableConnList()
m_connListView->setSelectionMode(QAbstractItemView::ExtendedSelection); m_connListView->setSelectionMode(QAbstractItemView::ExtendedSelection);
m_connListView->setSelectionBehavior(QAbstractItemView::SelectItems); m_connListView->setSelectionBehavior(QAbstractItemView::SelectItems);
// TODO: Add ability to select the allowed/blocked mode from UI // TODO: Select the allowed/blocked mode from UI
connListModel()->setBlockedMode(true); connListModel()->setBlockedMode(true);
m_connListView->setModel(connListModel()); m_connListView->setModel(connListModel());

2
src/ui/form/opt/pages/applicationspage.cpp
View File

@ -445,7 +445,7 @@ void ApplicationsPage::setupGroupLogConn()
ctrl()->setConfEdited(true); ctrl()->setConfEdited(true);
}); });
m_cbLogConn->setVisible(false); // TODO m_cbLogConn->setVisible(false); // TODO: Collect allowed connections
} }
void ApplicationsPage::setupGroupFragmentPacket() void ApplicationsPage::setupGroupFragmentPacket()

2
src/ui/util/net/ip4range.cpp
View File

@ -66,7 +66,7 @@ bool Ip4Range::fromText(const QString &text)
bool Ip4Range::fromList(const StringViewList &list, int emptyNetMask, bool sort) bool Ip4Range::fromList(const StringViewList &list, int emptyNetMask, bool sort)
{ {
Q_UNUSED(sort); // TODO Q_UNUSED(sort); // TODO: Sort parsed IPv4 addresses
clear(); clear();