Merge pull request #256 from cclauss/patch-1

Do not use bare `except:`

.github/workflows/lint_python.yml

@@ -7,12 +7,12 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-python@v3
       - run: pip install --upgrade pip wheel
-      - run: pip install bandit black codespell flake8 flake8-2020 flake8-bugbear
+      - run: pip install bandit black codespell flake8 flake8-bugbear flake8-return
                          flake8-comprehensions isort mypy pytest pyupgrade safety
       - run: bandit --recursive --skip B404,B603,B605,B607 .
       - run: black --check . || true
       - run: codespell --ignore-words-list="WAN" || true  # --skip="*.css,*.js,*.lock"
-      - run: flake8 --ignore=B001,E124,E128,E225,E251,E302,E722,F841,R502,R503,W291,W293,W605
+      - run: flake8 --ignore=E124,E128,E225,E251,E302,R502,R503,W291,W293,W605
                     --max-complexity=11 --max-line-length=265 --show-source --statistics .
       - run: isort --check-only --profile black . || true
       - run: pip install -r requirements.txt || pip install --editable .  || pip install . || true

core.py

@@ -11,21 +11,18 @@ from typing import Tuple
 
 
 def clear_screen():
-    if system() == "Linux":
-        os.system("clear")
-    if system() == "Windows":
-        os.system("cls")
+    os.system("cls" if system() == "Windows" else "clear")
 
 
 def validate_input(ip, val_range):
+    val_range = val_range or []
     try:
         ip = int(ip)
         if ip in val_range:
             return ip
-        else:
-            return None
-    except:
+    except Exception:
         return None
+    return None
 
 
 class HackingTool(object):
@@ -46,8 +43,7 @@ class HackingTool(object):
 
     def __init__(self, options = None, installable: bool = True,
                  runnable: bool = True):
-        if options is None:
-            options = []
+        options = options or []
         if isinstance(options, list):
             self.OPTIONS = []
             if installable:
@@ -176,7 +172,7 @@ class HackingToolsCollection(object):
         except (TypeError, ValueError):
             print("Please enter a valid option")
             input("\n\nPress ENTER to continue:")
-        except Exception as e:
+        except Exception:
             print_exc()
             input("\n\nPress ENTER to continue:")
         return self.show_options(parent = parent)