mirrors/insomnia
1
0
Fork 0
mirror of https://github.com/Kong/insomnia synced 2024-11-08 06:39:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unsafe deletion of a protofile (#2798)

Browse Source
This commit is contained in:
Opender Singh 2020-11-03 13:30:43 +13:00 committed by GitHub
parent e6bdbf27ea
commit 175834efa9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
packages/insomnia-app/app/ui/components/modals/proto-files-modal.js
View File

@ -10,7 +10,7 @@ import type { Workspace } from '../../../models/workspace';
import Modal from '../base/modal';
import ProtoFileList from '../proto-file/proto-file-list';
import FileInputButton from '../base/file-input-button';
import { showError } from './index';
import { showAlert, showError } from './index';
import fs from 'fs';
import path from 'path';
@ -72,9 +72,25 @@ class ProtoFilesModal extends React.PureComponent<Props, State> {
this.setState({ selectedProtoFileId: id });
}
_handleDelete(protoFile: ProtoFile) {
// TODO: to be built in INS-209
console.log(`delete ${protoFile._id}`);
async _handleDelete(protoFile: ProtoFile) {
showAlert({
title: `Delete ${protoFile.name}`,
message: (
<span>
Really delete <strong>{protoFile.name}</strong>? All requests that use this proto file
will stop working.
</span>
),
addCancel: true,
onConfirm: async () => {
await models.protoFile.remove(protoFile);
// if the deleted protoFile was previously selected, clear the selection
if (this.state.selectedProtoFileId === protoFile._id) {
this.setState({ selectedProtoFileId: '' });
}
},
});
}
async _handleProtoFileUpload(filePath: string) {

14
packages/insomnia-app/app/ui/components/proto-file/proto-file-list-item.js
View File

@ -2,13 +2,12 @@
import * as React from 'react';
import styled from 'styled-components';
import type { ProtoFile } from '../../../models/proto-file';
import PromptButton from '../base/prompt-button';
import type {
DeleteProtoFileHandler,
RenameProtoFileHandler,
SelectProtoFileHandler,
} from './proto-file-list';
import { ListGroupItem } from '../../../../../insomnia-components';
import { ListGroupItem, Button } from '../../../../../insomnia-components';
import Editable from '../base/editable';
type Props = {
@ -55,15 +54,10 @@ const ProtoFileListItem = ({
return (
<SelectableListItem isSelected={isSelected} onClick={handleSelectCallback}>
<div className="row-spaced">
<Editable onSubmit={handleRenameCallback} value={name} preventBlank />
<PromptButton
className="btn btn--super-compact btn--outlined"
addIcon
confirmMessage=""
onClick={handleDeleteCallback}
title="Delete Proto File">
<Editable className="wide" onSubmit={handleRenameCallback} value={name} preventBlank />
<Button size="small" title="Delete Proto File" onClick={handleDeleteCallback}>
<i className="fa fa-trash-o" />
</PromptButton>
</Button>
</div>
</SelectableListItem>
);