mirrors/insomnia
1
0
Fork 0
mirror of https://github.com/Kong/insomnia synced 2024-11-07 22:30:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use the database change listener in the global tests (#4017)

Browse Source 
* Use the database change listener instead of waiting for an amount of time

* Fire the actions after registering the handler
This commit is contained in:
James Gatz 2021-09-13 19:42:12 +02:00 committed by GitHub
parent 7e7d235fec
commit 45f683f992
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
packages/insomnia-app/app/ui/redux/modules/__tests__/global.test.ts
View File

@ -16,6 +16,7 @@ import {
GlobalActivity,
SORT_MODIFIED_DESC,
} from '../../../../common/constants';
import { database } from '../../../../common/database';
import { getDesignerDataDir } from '../../../../common/electron-helpers';
import * as models from '../../../../models';
import { DEFAULT_PROJECT_ID } from '../../../../models/project';
@ -81,32 +82,43 @@ describe('global', () => {
);
});
it('should update flag for onboarding prompted', async () => {
it('should update flag for onboarding prompted', async done => {
await models.settings.patch({
hasPromptedToMigrateFromDesigner: false,
hasPromptedOnboarding: false,
});
async function onDatabaseChange() {
const settings = await models.settings.getOrCreate();
expect(settings.hasPromptedToMigrateFromDesigner).toBe(false);
expect(settings.hasPromptedOnboarding).toBe(true);
database.offChange(onDatabaseChange);
done();
}
database.onChange(onDatabaseChange);
setActiveActivity(ACTIVITY_ONBOARDING);
// We don't await the settings update in the action creator
// so wait for it to update before checking
await new Promise(resolve => setTimeout(resolve, 10));
const settings = await models.settings.getOrCreate();
expect(settings.hasPromptedToMigrateFromDesigner).toBe(false);
expect(settings.hasPromptedOnboarding).toBe(true);
});
it('should update flag for migration prompted', async () => {
it('should update flag for migration prompted', async done => {
await models.settings.patch({
hasPromptedToMigrateFromDesigner: false,
hasPromptedOnboarding: false,
});
async function onDatabaseChange() {
const settings = await models.settings.getOrCreate();
expect(settings.hasPromptedToMigrateFromDesigner).toBe(true);
expect(settings.hasPromptedOnboarding).toBe(false);
database.offChange(onDatabaseChange);
done();
}
database.onChange(onDatabaseChange);
setActiveActivity(ACTIVITY_MIGRATION);
// We don't await the settings update in the action creator
// so wait for it to update before checking
await new Promise(resolve => setTimeout(resolve, 10));
const settings = await models.settings.getOrCreate();
expect(settings.hasPromptedToMigrateFromDesigner).toBe(true);
expect(settings.hasPromptedOnboarding).toBe(false);
});
});