mirrors/insomnia
1
0
Fork 0
mirror of https://github.com/Kong/insomnia synced 2024-11-07 14:19:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove :smoke (#4597)

Browse Source
This commit is contained in:
Jack Kavanagh 2022-03-16 10:36:41 +01:00 committed by GitHub
parent 28f6c2bdf4
commit 4c657d4e5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/test.yml vendored
View File

@ -64,7 +64,7 @@ jobs:
run: npm test
- name: Build app for smoke tests
run: npm run app-build:smoke
run: npm run app-build
- name: Run app smoke tests
run: npm run test:smoke:build

2
package.json
View File

@ -31,8 +31,6 @@
"app-package": "npm run package --prefix packages/insomnia-app",
"app-bump-version": "npm run bump-version --prefix packages/insomnia-app",
"preinstall": "node ./scripts/check-version.js",
"app-build:smoke": "cross-env npm run app-build",
"app-package:smoke": "cross-env npm run app-package",
"test:smoke:dev": "npm run test:dev --prefix packages/insomnia-smoke-test",
"test:smoke:build": "npm run test:build --prefix packages/insomnia-smoke-test",
"test:smoke:package": "npm run test:package --prefix packages/insomnia-smoke-test",

4
packages/insomnia-smoke-test/README.md
View File

@ -49,14 +49,14 @@ It's possible to run the smoke tests for:
For `build`:
```shell
npm run app-build:smoke # Transpile js bundle
npm run app-build # Transpile js bundle
npm run test:smoke:build # Run tests
```
For `package`:
```shell
npm run app-package:smoke # Build executable in /packages/insomnia-app/dist
npm run app-package # Build executable in /packages/insomnia-app/dist
npm run test:smoke:package # Run tests
```

6
packages/insomnia-smoke-test/playwright/paths.ts
View File

@ -25,7 +25,7 @@ const electronBinary = path.join('node_modules', '.bin', process.platform === 'w
export const executablePath = bundleType() === 'package' ? insomniaBinary : electronBinary;
// NOTE: main.min.js is built by app-build:smoke in /build and also by the watcher in /app
// NOTE: main.min.js is built by app-build in /build and also by the watcher in /app
export const mainPath = path.join(bundleType() === 'dev' ? 'app' : 'build', 'main.min.js');
export const cwd = path.resolve(__dirname, '..', '..', 'insomnia-app');
@ -40,12 +40,12 @@ if (bundleType() === 'dev' && !hasMainBeenBuilt) {
}
if (bundleType() === 'build' && !hasMainBeenBuilt) {
console.error(`ERROR: ${mainPath} not found at ${path.resolve(cwd, mainPath)}
Have you run "npm run app-build:smoke"?`);
Have you run "npm run app-build"?`);
exit(1);
}
if (bundleType() === 'package' && !hasBinaryBeenBuilt) {
console.error(`ERROR: ${insomniaBinary} not found at ${path.resolve(cwd, insomniaBinary)}
Have you run "npm run app-package:smoke"?`);
Have you run "npm run app-package"?`);
exit(1);
}
if (process.env.DEBUG) {