diff --git a/packages/insomnia-app/app/ui/components/editors/body/graph-ql-editor.tsx b/packages/insomnia-app/app/ui/components/editors/body/graph-ql-editor.tsx index 5e881c140..696ba3dc8 100644 --- a/packages/insomnia-app/app/ui/components/editors/body/graph-ql-editor.tsx +++ b/packages/insomnia-app/app/ui/components/editors/body/graph-ql-editor.tsx @@ -325,11 +325,6 @@ class GraphQLEditor extends PureComponent { } async _loadAndSetLocalSchema() { - const newState: Partial = { - schemaFetchError: null, - schemaIsFetching: false, - }; - const options: OpenDialogOptions = { title: 'Import GraphQL introspection schema', buttonLabel: 'Import', @@ -342,33 +337,42 @@ class GraphQLEditor extends PureComponent { ], }; - const { canceled, filePaths: paths } = await electron.remote.dialog.showOpenDialog(options); + const { canceled, filePaths } = await electron.remote.dialog.showOpenDialog(options); if (canceled) { return; } try { - const path = paths[0]; // showOpenDialog is single select - const file = readFileSync(path); + const filePath = filePaths[0]; // showOpenDialog is single select + const file = readFileSync(filePath); const content = JSON.parse(file.toString()); if (!content.data) { throw new Error('JSON file should have a data field with the introspection results'); } - newState.schema = buildClientSchema(content.data); - newState.schemaLastFetchTime = Date.now(); + if (!this._isMounted) { + return; + } + this.setState({ + schema: buildClientSchema(content.data), + schemaLastFetchTime: Date.now(), + schemaFetchError: null, + schemaIsFetching: false, + }); } catch (err) { console.log('[graphql] ERROR: Failed to fetch schema', err); - newState.schemaFetchError = { - message: `Failed to fetch schema: ${err.message}`, - response: null, - }; - } - - if (this._isMounted) { - this.setState(existingState => ({ ...existingState, ...newState })); + if (!this._isMounted) { + return; + } + this.setState({ + schemaFetchError: { + message: `Failed to fetch schema: ${err.message}`, + response: null, + }, + schemaIsFetching: false, + }); } } @@ -426,9 +430,7 @@ class GraphQLEditor extends PureComponent { } _handleSetLocalSchema() { - this.setState({ hideSchemaFetchErrors: false }, async () => { - await this._loadAndSetLocalSchema(); - }); + this.setState({ hideSchemaFetchErrors: false }, this._loadAndSetLocalSchema); } async _handleToggleAutomaticFetching() { @@ -669,26 +671,28 @@ class GraphQLEditor extends PureComponent { return (
+ schema - GraphQL Schema + Show Documentation + + Remote GraphQL Schema + - Refresh Schema + Refresh Schema - {' '} + {' '} Automatic Fetch Automatically fetch schema when request URL is modified + + Local GraphQL Schema + Load schema from JSON @@ -697,6 +701,7 @@ class GraphQLEditor extends PureComponent { +