git sync ux add->authenticate (#6260)

* add->authenticate

* update doc

* fix test
This commit is contained in:
Jack Kavanagh 2023-08-11 13:54:39 +02:00 committed by GitHub
parent 96011e8db5
commit 87953708ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 5 deletions

View File

@ -8,7 +8,12 @@ npm install will download the electron version of libcurl but for inso we need t
node_modules/.bin/node-pre-gyp install --update-binary --directory node_modules/@getinsomnia/node-libcurl
```
to download the electron version of node-libcurl you should run npm run clean and npm install again
to download the electron version of node-libcurl you should remove the module and npm install again
```shell
rm -rf node_modules/@getinsomnia/
npm install
```
## Run CLI Smoke Tests

View File

@ -50,7 +50,7 @@ test('Sign in with GitHub', async ({ app, page }) => {
await page.locator('input[name="link"]').fill(redirectUrl);
await page.getByRole('button', { name: 'Add' }).click();
await page.getByRole('button', { name: 'Authenticate' }).click();
await page
.locator('input[name="uri"]')

View File

@ -34,7 +34,7 @@ test('Sign in with Gitlab', async ({ app, page }) => {
await page.locator('input[name="link"]').click();
await page.locator('input[name="link"]').fill(redirectUrl);
await page.getByRole('button', { name: 'Add' }).click();
await page.getByRole('button', { name: 'Authenticate' }).click();
test.expect(await page.locator('text="Mark Kim"')).toBeTruthy();
test.expect(await page.locator('button[name="sign-out"]')).toBeTruthy();

View File

@ -389,7 +389,7 @@ const GitHubSignInForm = ({ token }: GitHubSignInFormProps) => {
</div>
<div className="form-row">
<input name="link" />
<Button name="add-token">Add</Button>
<Button bg="surprise" name="add-token">Authenticate</Button>
</div>
</label>
{error && (

View File

@ -340,7 +340,7 @@ const GitLabSignInForm = ({ token }: GitLabSignInFormProps) => {
</div>
<div className="form-row">
<input name="link" />
<Button name="add-token">Add</Button>
<Button bg="surprise" name="add-token">Authenticate</Button>
</div>
</label>
</form>