mirrors/insomnia
1
0
Fork 0
mirror of https://github.com/Kong/insomnia synced 2024-11-07 22:30:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove broken tab tracking from settings

Browse Source
This commit is contained in:
Gregory Schier 2017-08-15 11:43:58 -07:00
parent a92ef82e9f
commit ee70a697b5
2 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.appveyor.yml
View File

@ -8,7 +8,7 @@ build: off
shallow_clone: true
platform: x64
environment:
NODEJS_VERSION: "7"
NODEJS_VERSION: "8"
CSC_LINK: '%WINDOWS_CSC_LINK%'
CSC_KEY_PASSWORD: '%WINDOWS_CSC_KEY_PASSWORD%'

22
app/ui/components/modals/settings-modal.js
View File

@ -1,6 +1,6 @@
import React, {PureComponent} from 'react';
import PropTypes from 'prop-types';
import {Tab, Tabs, TabList, TabPanel} from 'react-tabs';
import {Tab, TabList, TabPanel, Tabs} from 'react-tabs';
import autobind from 'autobind-decorator';
import Modal from '../base/modal';
import Button from '../base/button';
@ -15,7 +15,7 @@ import Plugins from '../settings/plugins';
import Theme from '../settings/theme';
import * as models from '../../../models/index';
import {Curl} from 'node-libcurl';
import {getAppVersion, getAppName} from '../../../common/constants';
import {getAppName, getAppVersion} from '../../../common/constants';
import {trackEvent} from '../../../analytics/index';
import * as session from '../../../sync/session';
import Tooltip from '../tooltip';
@ -34,10 +34,6 @@ class SettingsModal extends PureComponent {
this.modal = n;
}
_trackTab (name) {
trackEvent('Setting', `Tab ${name}`);
}
_handleUpdateSetting (key, value) {
models.settings.update(this.props.settings, {[key]: value});
trackEvent('Setting', 'Change', key);
@ -114,37 +110,37 @@ class SettingsModal extends PureComponent {
<Tabs className="react-tabs" defaultIndex={currentTabIndex}>
<TabList>
<Tab>
<Button value="General" onClick={this._trackTab}>
<Button value="General">
General
</Button>
</Tab>
<Tab>
<Button value="Import/Export" onClick={this._trackTab}>
<Button value="Import/Export">
Data
</Button>
</Tab>
<Tab>
<Button value="Themes" onClick={this._trackTab}>
<Button value="Themes">
Themes
</Button>
</Tab>
<Tab>
<Button value="Shortcuts" onClick={this._trackTab}>
<Button value="Shortcuts">
Keyboard
</Button>
</Tab>
<Tab>
<Button value="Account" onClick={this._trackTab}>
<Button value="Account">
Account
</Button>
</Tab>
<Tab>
<Button value="Plugins" onClick={this._trackTab}>
<Button value="Plugins">
Plugins
</Button>
</Tab>
<Tab>
<Button value="About" onClick={this._trackTab}>
<Button value="About">
About
</Button>
</Tab>