mirrors/insomnia
1
0
Fork 0
mirror of https://github.com/Kong/insomnia synced 2024-11-07 22:30:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix 405 HTTP status description (#1479)

Browse Source 
The https://developer.mozilla.org/en-US/docs/Web/HTTP/Status page do say that the 405 should not be returned for GET and HEAD. But if you click on that 405 link it will open https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405 , and there there's nothing about mandatory methods.

On that page you will get the RFC link https://tools.ietf.org/html/rfc7231#section-6.5.5 , and again, there's nothing about mandatory methods.

The restful documentation also doesn't talk about mandatory methods for 405: https://restfulapi.net/http-status-codes/

Spring Framework (a well know framework for Java) has some configuration for the Spring Data Rest project that will result in GET requests returning 405.

Since the RFC should be the winner here, and the divergence between the mozilla's pages, I'm proposing this fix to remove the misleading description.
This commit is contained in:
Rafael Renan Pacheco 2019-05-03 11:18:26 -03:00 committed by Gregory Schier
parent 0eccfce9db
commit fd9ebf335d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/insomnia-app/app/common/constants.js
View File

@ -264,7 +264,7 @@ export const RESPONSE_CODE_DESCRIPTIONS = {
402: 'This response code is reserved for future use. Initial aim for creating this code was using it for digital payment systems however this is not used currently.',
403: 'Client does not have access rights to the content so server is rejecting to give proper response.',
404: 'Server can not find requested resource. This response code probably is most famous one due to its frequency to occur in web.',
405: 'The request method is known by the server but has been disabled and cannot be used. The two mandatory methods, GET and HEAD, must never be disabled and should not return this error code.',
405: 'The request method is known by the server but has been disabled and cannot be used.',
406: "This response is sent when the web server, after performing server-driven content negotiation, doesn't find any content following the criteria given by the user agent.",
407: 'This is similar to 401 but authentication is needed to be done by a proxy.',
408: 'This response is sent on an idle connection by some servers, even without any previous request by the client. It means that the server would like to shut down this unused connection. This response is used much more since some browsers, like Chrome or IE9, use HTTP preconnection mechanisms to speed up surfing (see bug 881804, which tracks the future implementation of such a mechanism in Firefox). Also note that some servers merely shut down the connection without sending this message.',