insomnia/packages/insomnia-app
Akhil Sasidharan 0b38c68c1f
fix: insomnia open dialog for proto directory can't select directories (#3348)
* fix: insomnia open dialog for proto directory can't select directories

* uses a named export for selectFileOrFolder

(also, removes original js file from rebase)

* clears error by leveraging exhaustiveness check

* fixes bug: the `name` field is actually for a file filter

see the referenced pull request.

As for the `extensions: ['*']`, there's no reason I can see to include a filter and then tell the filter to then accept everything.

* update selectFileOrFolder mocks

* use switch (for exhaustiveness checking) and type selectedFormat

* removes unnecessary filters from _save_ dialog

from the docs:
> The filters specifies an array of file types that can be displayed

As suspected, this is not needed.  A user is free to save it wherever they want.

* adds extension to saved file

not sure why this was missing before, but it appears to have been a bug

* formatting updates

best to "ignore whitespace" for this commit.  I did this with the hope of using the `ThunkAction` type from `redux-thunk`, but once I got them all looking good and started adding the type I quickly learned there's quite a bit more work to do in this area before we can have such a thing.  I therefore opted to just call it a day at that and take the (no-op) formatting changes and typings.

* removes remaining name filters from save dialogs

same reason as the 2nd to prior commit - they cause the bug

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
Co-authored-by: Opender Singh <opender.singh@konghq.com>
2021-05-26 10:24:21 -04:00
..
.storybook [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
app fix: insomnia open dialog for proto directory can't select directories (#3348) 2021-05-26 10:24:21 -04:00
bin [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
config merge release branch with develop and resolve conflicts 2021-05-25 09:30:09 +12:00
scripts merge release branch with develop and resolve conflicts 2021-05-25 09:30:09 +12:00
send-request [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
webpack [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
.eslintignore reverts changes to main.min.js artifact location (#3401) 2021-05-19 15:00:12 -04:00
.eslintrc.js use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
.gitignore reverts changes to main.min.js artifact location (#3401) 2021-05-19 15:00:12 -04:00
.npmrc Upgrade Electron to 9.3.5 (#3000) 2021-03-16 09:23:56 +13:00
jest.config.js remove duplication of all jest configs (#3375) 2021-05-13 07:29:02 -04:00
package-lock.json publish npm packages lib@2.3.0-beta.3 2021-05-20 13:12:04 +12:00
package.json merge release branch with develop and resolve conflicts 2021-05-25 09:30:09 +12:00
README.md
tsconfig.build.json reverts changes to main.min.js artifact location (#3401) 2021-05-19 15:00:12 -04:00
tsconfig.build.sr.json [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
tsconfig.json reverts changes to main.min.js artifact location (#3401) 2021-05-19 15:00:12 -04:00
tsconfig.webpack.json [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00

Insomnia App

The main desktop application.