mirrors/librempeg
1
0
Fork 0
mirror of https://github.com/librempeg/librempeg synced 2024-11-23 19:58:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

riffdec: Explicitly null-terminate array to work around VC++ bug

Browse Source 
Due to this bug in VC++ 2015 Update 1:
https://connect.microsoft.com/VisualStudio/feedback/details/2291638

the 'key' array in ff_read_riff_info() ends up being not null
terminated which led to failures in a Chromium unit tests. Update 2
should have a fix, but until then it is important to avoid problems.
This commit is contained in:
Bruce Dawson 2016-01-28 13:06:07 -08:00 committed by Hendrik Leppkes
parent f85cc3bf12
commit 09b3a42495
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libavformat/riffdec.c
View File

@ -279,6 +279,9 @@ int ff_read_riff_info(AVFormatContext *s, int64_t size)
} }
AV_WL32(key, chunk_code); AV_WL32(key, chunk_code);
// Work around VC++ 2015 Update 1 code-gen bug:
// https://connect.microsoft.com/VisualStudio/feedback/details/2291638
key[4] = 0;
if (avio_read(pb, value, chunk_size) != chunk_size) { if (avio_read(pb, value, chunk_size) != chunk_size) {
av_log(s, AV_LOG_WARNING, av_log(s, AV_LOG_WARNING,