From 4aad316bff610c34b6eb047644e616982bdde621 Mon Sep 17 00:00:00 2001 From: Diego Biurrun Date: Sat, 30 Jun 2012 15:35:57 +0200 Subject: [PATCH] doc: Remind devs to check return values, especially for malloc() et al --- doc/developer.texi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 2e25f5fb0d..d36f53f191 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -488,6 +488,10 @@ send a reminder by email. Your patch should eventually be dealt with. @item Lines with similar content should be aligned vertically when doing so improves readability. +@item + Make sure you check the return values of function and return appropriate + error codes. Especially memory allocation functions like @code{malloc()} + are notoriously left unchecked, which is a serious problem. @end enumerate @section Patch review process