From 6ff4473012bc0131a3a47ff613c3c0aa5ecb1881 Mon Sep 17 00:00:00 2001 From: Mark Thompson Date: Thu, 4 Oct 2018 23:29:04 +0100 Subject: [PATCH] av1_metadata: Fix constraint on setting chroma_sample_position It can't be set for 4:2:2 streams. --- libavcodec/av1_metadata_bsf.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavcodec/av1_metadata_bsf.c b/libavcodec/av1_metadata_bsf.c index 20c3a39da7..52d383661f 100644 --- a/libavcodec/av1_metadata_bsf.c +++ b/libavcodec/av1_metadata_bsf.c @@ -86,13 +86,9 @@ static int av1_metadata_update_sequence_header(AVBSFContext *bsf, } if (ctx->chroma_sample_position >= 0) { - if (clc->mono_chrome) { + if (clc->mono_chrome || !clc->subsampling_x || !clc->subsampling_y) { av_log(bsf, AV_LOG_WARNING, "Warning: chroma_sample_position " - "is not meaningful for monochrome streams.\n"); - } else if (clc->subsampling_x == 0 && - clc->subsampling_y == 0) { - av_log(bsf, AV_LOG_WARNING, "Warning: chroma_sample_position " - "is not meaningful for non-chroma-subsampled streams.\n"); + "can only be set for 4:2:0 streams.\n"); } else { clc->chroma_sample_position = ctx->chroma_sample_position; }