From 9b77a199acdb4c9958744054966d1e68c0b038c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Tue, 21 May 2024 14:03:07 +0300 Subject: [PATCH] checkasm: h264dsp: Avoid out of buffer writes when benchmarking MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The loop filters can write before the pointer given to them; the actual test invocations correctly used an offset, while the benchmark calls were lacking an offset. Therefore, when running with benchmarking, these tests could have spurious failures. Signed-off-by: Martin Storsjö Signed-off-by: Paul B Mahol --- tests/checkasm/h264dsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c index 0cc1f32740..67b8dce53c 100644 --- a/tests/checkasm/h264dsp.c +++ b/tests/checkasm/h264dsp.c @@ -362,7 +362,7 @@ static void check_loop_filter(void) tc0[j][0], tc0[j][1], tc0[j][2], tc0[j][3]); \ fail(); \ } \ - bench_new(dst1, 32, alphas[j], betas[j], tc0[j]); \ + bench_new(dst1 + off, 32, alphas[j], betas[j], tc0[j]);\ } \ } \ } while (0) @@ -421,7 +421,7 @@ static void check_loop_filter_intra(void) j, alphas[j], betas[j]); \ fail(); \ } \ - bench_new(dst1, 32, alphas[j], betas[j]); \ + bench_new(dst1 + off, 32, alphas[j], betas[j]); \ } \ } \ } while (0)