From be01d1a24ddca88bded154f5fae77c6373e67cfe Mon Sep 17 00:00:00 2001 From: Nicolas George Date: Wed, 2 Jan 2013 23:22:46 +0100 Subject: [PATCH] fate: disable globbing when calling shell functions. Some of the filters tests use globbing characters, especially brackets for filter pad labels. While most of these strings are way too complicated to ever match an existing file name and are therefore kept unchanged in the command line (an old misfeature of the shell language that happens to be convenient here), at least one use is simple enough to match random files lying in the current directory. If that happens, the string, that was meant to be kept verbatim, is replaced by the file name, and that causes the test to fail (or worse). --- tests/fate-run.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 9cd872b6c6..0520d62f7d 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -166,6 +166,10 @@ lavfitest(){ mkdir -p "$outdir" +# Disable globbing: command arguments may contain globbing characters and +# must be kept verbatim +set -f + exec 3>&2 eval $command >"$outfile" 2>$errfile err=$?