From 1f1ffbe97b643ff6cb18ce0aaee550b24611fee0 Mon Sep 17 00:00:00 2001 From: Josh Bruce Date: Tue, 27 Feb 2018 00:27:22 -0500 Subject: [PATCH] A little more detail around CI things --- .github/PULL_REQUEST_TEMPLATE.md | 5 ++++- .github/PULL_REQUEST_TEMPLATE/release.md | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b893892b..c8d249d9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -40,7 +40,10 @@ Describe what code combination got you there ## Committer +In most cases, this should be a different person than the contributor. + - [ ] Draft GitHub release notes have been updated. -- [ ] case_insensitive_refs is only failing test (remove once CI is in place and all tests pass). +- [ ] cm_autolinks is the only failing test (remove once CI is in place and all tests pass). - [ ] All lint checks pass (remove once CI is in place). +- [ ] CI is green (no forced merge required). - [ ] Merge PR \ No newline at end of file diff --git a/.github/PULL_REQUEST_TEMPLATE/release.md b/.github/PULL_REQUEST_TEMPLATE/release.md index bf24c608..8d417b7e 100644 --- a/.github/PULL_REQUEST_TEMPLATE/release.md +++ b/.github/PULL_REQUEST_TEMPLATE/release.md @@ -16,8 +16,11 @@ Note: If merges to `master` occur after submitting this PR and before running `$ ## Committer +In most cases, this should be someone different than the publisher. + - [ ] Version in `package.json` has been updated (see [RELEASE.md](https://github.com/markedjs/marked/blob/master/RELEASE.md)). - [ ] The `marked.min.js` has been updated; or, - [ ] release does not change library. -- [ ] cm_autolinks is only failing test (remove once CI is in place and all tests pass). +- [ ] cm_autolinks is the only failing test (remove once CI is in place and all tests pass). - [ ] All lint checks pass (remove once CI is in place). +- [ ] CI is green (no forced merge required).