mirrors/oneuptime
1
0
Fork 0
mirror of https://github.com/OneUptime/oneuptime synced 2024-11-22 15:24:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor ServerMonitorCriteria class to improve code readability and remove redundant code

Browse Source
This commit is contained in:
Simon Larsen 2024-04-03 11:52:22 +01:00
parent 8ebcb1b659
commit 37a13ce853
No known key found for this signature in database
GPG Key ID: AB45983AA9C81CDE
1 changed files with 1 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
CommonServer/Utils/Probe/Criteria/ServerMonitorCriteria.ts
View File

@ -162,48 +162,8 @@ export default class ServerMonitorCriteria {
!(input.dataToProcess as ServerMonitorResponse)
.onlyCheckRequestReceivedAt
) {
const thresholdProcessName: string = threshold
.toString()
.trim()
.toLowerCase();
if (input.criteriaFilter.filterType === FilterType.IsExecuting) {
const processNames: Array<string> =
(
input.dataToProcess as ServerMonitorResponse
)?.processes?.map((item: ServerProcess) => {
return item.name.trim().toLowerCase();
}) || [];
if (processNames.includes(thresholdProcessName)) {
return `Process ${threshold} is executing.`;
}
return null;
}
if (input.criteriaFilter.filterType === FilterType.IsNotExecuting) {
const processNames: Array<string> =
(
input.dataToProcess as ServerMonitorResponse
)?.processes?.map((item: ServerProcess) => {
return item.name.trim().toLowerCase();
}) || [];
if (!processNames.includes(thresholdProcessName)) {
return `Process ${threshold} is not executing.`;
}
return null;
}
}
if (
input.criteriaFilter.checkOn === CheckOn.ServerProcessName &&
threshold &&
!(input.dataToProcess as ServerMonitorResponse)
.onlyCheckRequestReceivedAt
) {
debugger;
const thresholdProcessName: string = threshold
.toString()
.trim()