mirrors/oneuptime
1
0
Fork 0
mirror of https://github.com/OneUptime/oneuptime synced 2024-11-22 07:10:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor unsubscribe URL generation in StatusPageSubscriberService

Browse Source
This commit is contained in:
Simon Larsen 2023-12-19 11:43:41 +00:00
parent 32e72a8817
commit 59ab24ba36
No known key found for this signature in database
GPG Key ID: AB45983AA9C81CDE
8 changed files with 13 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
CommonServer/Services/StatusPageSubscriberService.ts
View File

@ -189,12 +189,7 @@ export class Service extends DatabaseService<Model> {
.isPublicStatusPage
? 'true'
: 'false',
unsubscribeUrl: new URL(httpProtocol, host)
.addRoute(
'/api/status-page-subscriber/unsubscribe/' +
createdItem._id.toString()
)
.toString(),
unsubscribeUrl: this.getUnsubscribeLink(URL.fromString(statusPageURL), createdItem.id!).toString()
},
subject: 'You have been subscribed to ' + statusPageName,
},
@ -229,5 +224,10 @@ export class Service extends DatabaseService<Model> {
props: props,
});
}
public getUnsubscribeLink(statusPageUrl: URL, statusPageSubscriberId: ObjectID): URL {
return URL.fromString(statusPageUrl.toString()).addRoute('/update-subscription/'+statusPageSubscriberId.toString());
}
}
export default new Service();

7
Workers/Jobs/Announcement/SendNotificationToSubscribers.ts
View File

@ -132,12 +132,7 @@ RunCron(
continue;
}
const unsubscribeUrl: string = new URL(httpProtocol, host)
.addRoute(
'/api/status-page-subscriber/unsubscribe/' +
subscriber._id.toString()
)
.toString();
const unsubscribeUrl: string = StatusPageSubscriberService.getUnsubscribeLink(URL.fromString(statusPageURL), subscriber.id!).toString();;
if (subscriber.subscriberPhone) {
const sms: SMS = {

7
Workers/Jobs/Incident/SendNotificationToSubscribers.ts
View File

@ -190,12 +190,7 @@ RunCron(
continue;
}
const unsubscribeUrl: string = new URL(httpProtocol, host)
.addRoute(
'/api/status-page-subscriber/unsubscribe/' +
subscriber._id.toString()
)
.toString();
const unsubscribeUrl: string = StatusPageSubscriberService.getUnsubscribeLink(URL.fromString(statusPageURL), subscriber.id!).toString();
if (subscriber.subscriberEmail) {
// send email here.

7
Workers/Jobs/IncidentPublicNote/SendNotificationToSubscribers.ts
View File

@ -212,12 +212,7 @@ RunCron(
continue;
}
const unsubscribeUrl: string = new URL(httpProtocol, host)
.addRoute(
'/api/status-page-subscriber/unsubscribe/' +
subscriber._id.toString()
)
.toString();
const unsubscribeUrl: string = StatusPageSubscriberService.getUnsubscribeLink(URL.fromString(statusPageURL), subscriber.id!).toString();;
if (subscriber.subscriberPhone) {
const sms: SMS = {

7
Workers/Jobs/IncidentStateTimeline/SendNotificationToSubscribers.ts
View File

@ -220,12 +220,7 @@ RunCron(
continue;
}
const unsubscribeUrl: string = new URL(httpProtocol, host)
.addRoute(
'/api/status-page-subscriber/unsubscribe/' +
subscriber._id.toString()
)
.toString();
const unsubscribeUrl: string = StatusPageSubscriberService.getUnsubscribeLink(URL.fromString(statusPageURL), subscriber.id!).toString();;
if (subscriber.subscriberPhone) {
const sms: SMS = {

7
Workers/Jobs/ScheduledMaintenance/SendNotificationToSubscribers.ts
View File

@ -194,12 +194,7 @@ RunCron(
continue;
}
const unsubscribeUrl: string = new URL(httpProtocol, host)
.addRoute(
'/api/status-page-subscriber/unsubscribe/' +
subscriber._id.toString()
)
.toString();
const unsubscribeUrl: string = StatusPageSubscriberService.getUnsubscribeLink(URL.fromString(statusPageURL), subscriber.id!).toString();;
if (subscriber.subscriberPhone) {
const sms: SMS = {

7
Workers/Jobs/ScheduledMaintenancePublicNote/SendNotificationToSubscribers.ts
View File

@ -206,12 +206,7 @@ RunCron(
continue;
}
const unsubscribeUrl: string = new URL(httpProtocol, host)
.addRoute(
'/api/status-page-subscriber/unsubscribe/' +
subscriber._id.toString()
)
.toString();
const unsubscribeUrl: string = StatusPageSubscriberService.getUnsubscribeLink(URL.fromString(statusPageURL), subscriber.id!).toString();;
if (subscriber.subscriberPhone) {
const sms: SMS = {

7
Workers/Jobs/ScheduledMaintenanceStateTimeline/SendNotificationToSubscribers.ts
View File

@ -218,12 +218,7 @@ RunCron(
continue;
}
const unsubscribeUrl: string = new URL(httpProtocol, host)
.addRoute(
'/api/status-page-subscriber/unsubscribe/' +
subscriber._id.toString()
)
.toString();
const unsubscribeUrl: string = StatusPageSubscriberService.getUnsubscribeLink(URL.fromString(statusPageURL), subscriber.id!).toString();;
if (subscriber.subscriberPhone) {
const sms: SMS = {