Add a script to check our translation files are valid

Checks the following:
- Translation files are valid JS
- Each translation file is registered in translations.js
- Each translation's code matches its name
- Translation dictionaries only contain keys that exist in the English
  translation.
This commit is contained in:
Sam Atkins 2024-03-20 12:00:56 +00:00
parent afd733024b
commit 3f27608850
3 changed files with 113 additions and 1 deletions

View File

@ -0,0 +1,28 @@
# This workflow runs the tools/check-translations.js script to make sure that the translation data is valid.
name: Check Translations
env:
NODE_VERSION: 21.x
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
cache: 'npm'
cache-dependency-path: ./package-lock.json
- run: npm ci
- run: npm run check-translations

View File

@ -23,7 +23,8 @@
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"start": "nodemon --exec \"node dev-server.js\" ",
"build": "node ./build.js"
"build": "node ./build.js",
"check-translations": "node tools/check-translations.js"
},
"nodemonConfig": {
"ext": "js, json, mjs, jsx, svg, css",

View File

@ -0,0 +1,83 @@
/**
* Copyright (C) 2024 Puter Technologies Inc.
*
* This file is part of Puter.
*
* Puter is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published
* by the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
import translations from '../src/i18n/translations/translations.js';
import fs from 'fs';
let hadError = false;
function reportError(message) {
hadError = true;
process.stderr.write(`${message}\n`);
}
// Check that each translation file is recorded in `translations`
async function checkTranslationRegistrations() {
const files = await fs.promises.readdir('./src/i18n/translations');
for (const fileName of files) {
if (!fileName.endsWith('.js')) continue;
const translationName = fileName.substring(0, fileName.length - 3);
if (translationName === 'translations') continue;
const translation = translations[translationName];
if (!translation) {
reportError(`Translation '${translationName}' is not listed in translations.js, please add it!`);
continue;
}
if (!translation.name) {
reportError(`Translation '${translationName}' is missing a name!`);
}
if (!translation.code) {
reportError(`Translation '${translationName}' is missing a code!`);
} else if (translation.code !== translationName) {
reportError(`Translation '${translationName}' has code '${translation.code}', which should be '${translationName}'!`);
}
if (typeof translation.dictionary !== 'object') {
reportError(`Translation '${translationName}' is missing a translations dictionary! Should be an object.`);
}
}
}
function checkTranslationKeys() {
const enDictionary = translations.en.dictionary;
for (const translation of Object.values(translations)) {
// We compare against the en translation, so checking it doesn't make sense.
if (translation.code === 'en') continue;
// If the dictionary is missing, we already reported that in checkTranslationRegistrations().
if (typeof translation.dictionary !== "object") continue;
for (const [key, value] of Object.entries(translation.dictionary)) {
if (!enDictionary[key]) {
reportError(`Translation '${translation.code}' has key '${key}' that doesn't exist in 'en'!`);
}
}
}
}
await checkTranslationRegistrations();
checkTranslationKeys();
if (hadError) {
process.stdout.write('Errors were found in translation files.\n');
process.exit(1);
}
process.stdout.write('✅ Translations appear valid.\n');
process.exit(0);