mirrors/puter
1
0
Fork 0
mirror of https://github.com/HeyPuter/puter synced 2024-11-14 22:06:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Only run Component initialization functions once

Browse Source 
If the Component gets removed from the DOM and then re-added, it already
has contents, and we don't need to create them again. It also has
already had on_ready called, so that doesn't need to happen again
either.

This fix stops Components duplicating their content elements and
listener callbacks whenever they're moved around the document.
This commit is contained in:
Sam Atkins 2024-05-10 14:48:26 +01:00
parent cf605c8a38
commit 5b43358219
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/util/Component.js
View File

@ -1,6 +1,9 @@
import ValueHolder from "./ValueHolder.js";
export class Component extends HTMLElement {
#has_created_element = false;
#has_called_on_ready = false;
// Render modes
static NO_SHADOW = Symbol('no-shadow');
@ -86,12 +89,18 @@ export class Component extends HTMLElement {
}
connectedCallback () {
this.on_ready && this.on_ready(this.get_api_());
if (!this.#has_called_on_ready) {
this.on_ready && this.on_ready(this.get_api_());
this.#has_called_on_ready = true;
}
}
attach (destination) {
const el = this.create_element_();
this.dom_.appendChild(el);
if (!this.#has_created_element) {
const el = this.create_element_();
this.dom_.appendChild(el);
this.#has_created_element = true;
}
if ( destination instanceof HTMLElement ) {
destination.appendChild(this);