Merge pull request #407 from AtkinsSJ/clean-suggested-apps

fix: Remove null or duplicate app entries from suggest_app_for_fsentry()
This commit is contained in:
Eric Dubé 2024-05-17 15:46:06 -04:00 committed by GitHub
commit 80b763c47c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -1770,7 +1770,15 @@ async function suggest_app_for_fsentry(fsentry, options){
monitor.end();
// return list
return suggested_apps;
return suggested_apps.filter((suggested_app, pos, self) => {
// Remove any null values caused by calling `get_app()` for apps that don't exist.
// This happens on self-host because we don't include `code`, among others.
if (!suggested_app)
return false;
// Remove any duplicate entries
return self.indexOf(suggested_app) === pos;
});
}
function build_item_object(item){