mirrors/puter
1
0
Fork 0
mirror of https://github.com/HeyPuter/puter synced 2024-11-15 06:15:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove outdated FIXMEs about consuming extra stdin data

Browse Source
This commit is contained in:
Sam Atkins 2024-05-15 11:05:54 +01:00
parent c08c8bd073
commit bf33fd752d
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/phoenix/src/puter-shell/providers/PathCommandProvider.js
View File

@ -83,7 +83,6 @@ function spawn_process(ctx, executablePath) {
// Repeatedly copy data from stdin to the child, while it's running. // Repeatedly copy data from stdin to the child, while it's running.
let data, done; let data, done;
const next_data = async () => { const next_data = async () => {
// FIXME: This waits for one more read() after we finish.
({ value: data, done } = await Promise.race([ ({ value: data, done } = await Promise.race([
exit_promise, sigint_promise, ctx.externs.in_.read(), exit_promise, sigint_promise, ctx.externs.in_.read(),
])); ]));
@ -135,7 +134,6 @@ function spawn_pty(ctx, executablePath) {
// Repeatedly copy data from stdin to the child, while it's running. // Repeatedly copy data from stdin to the child, while it's running.
let data, done; let data, done;
const next_data = async () => { const next_data = async () => {
// FIXME: This waits for one more read() after we finish.
({ value: data, done } = await Promise.race([ ({ value: data, done } = await Promise.race([
exit_promise, sigint_promise, ctx.externs.in_.read(), exit_promise, sigint_promise, ctx.externs.in_.read(),
])); ]));

1
packages/phoenix/src/puter-shell/providers/PuterAppCommandProvider.js
View File

@ -86,7 +86,6 @@ export class PuterAppCommandProvider {
// DRY: Initially copied from PathCommandProvider // DRY: Initially copied from PathCommandProvider
let data, done; let data, done;
const next_data = async () => { const next_data = async () => {
// FIXME: This waits for one more read() after we finish.
({ value: data, done } = await Promise.race([ ({ value: data, done } = await Promise.race([
app_close_promise, sigint_promise, ctx.externs.in_.read(), app_close_promise, sigint_promise, ctx.externs.in_.read(),
])); ]));