mirrors/puter
1
0
Fork 0
mirror of https://github.com/HeyPuter/puter synced 2024-11-14 22:06:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Make PathCommandProvider reject queries with path separators

Browse Source 
`../bin/foo` should only find `foo` relative to the current working
directory, not to directories in PATH.

Also switch to using the Node path library since PathCommandProvider is
Node-only, and this means getting the correct path separator and
delimiter values on Windows.
This commit is contained in:
Sam Atkins 2024-04-24 11:44:52 +01:00
parent 670673ab8d
commit d733119456
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/phoenix/src/puter-shell/providers/PathCommandProvider.js
View File

@ -16,7 +16,7 @@
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
import path_ from "path-browserify";
import path_ from "node:path";
import child_process from "node:child_process";
import stream from "node:stream";
import { signals } from '../../ansi-shell/signals.js';
@ -167,9 +167,9 @@ function makeCommand(id, executablePath) {
async function findCommandsInPath(id, ctx, firstOnly) {
const PATH = ctx.env['PATH'];
if (!PATH)
if (!PATH || id.includes(path_.sep))
return;
const pathDirectories = PATH.split(':');
const pathDirectories = PATH.split(path_.delimiter);
const results = [];