mirrors/puter
1
0
Fork 0
mirror of https://github.com/HeyPuter/puter synced 2024-11-15 06:15:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Phoenix: Support older Node versions in test harness

Browse Source 
This brings Phoenix's minimum required version from 20.x down to 16.x.

ReadableStream.from() is deemed experimental, and requires Node 20.x
(or at least, something higher than 18.x). This was the only code that
made us require version 20.x.

ReadableStream and WritableStream are available from Node 16.5, but
require that they be explicitly imported.
This commit is contained in:
Sam Atkins 2024-04-18 14:35:24 +01:00
parent 04a641adc2
commit dc95f2e065
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
packages/phoenix/test/coreutils/harness.js
View File

@ -19,8 +19,9 @@
import { Context } from "contextlink"; import { Context } from "contextlink";
import { SyncLinesReader } from '../../src/ansi-shell/ioutil/SyncLinesReader.js'; import { SyncLinesReader } from '../../src/ansi-shell/ioutil/SyncLinesReader.js';
import { CommandStdinDecorator } from '../../src/ansi-shell/pipeline/iowrappers.js'; import { CommandStdinDecorator } from '../../src/ansi-shell/pipeline/iowrappers.js';
import { ReadableStream, WritableStream } from 'stream/web'
export class WritableStringStream extends WritableStream { class WritableStringStream extends WritableStream {
constructor() { constructor() {
super({ super({
write: (chunk) => { write: (chunk) => {
@ -42,8 +43,23 @@ export class WritableStringStream extends WritableStream {
// TODO: Flesh this out as needed. // TODO: Flesh this out as needed.
export const MakeTestContext = (command, { positionals = [], values = {}, stdinInputs = [], env = {} }) => { export const MakeTestContext = (command, { positionals = [], values = {}, stdinInputs = [], env = {} }) => {
// This is a replacement to ReadableStream.from() in earlier Node versions
// Sourece: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream#convert_an_iterator_or_async_iterator_to_a_stream
function iteratorToStream(iterator) {
return new ReadableStream({
async pull(controller) {
const { value, done } = await iterator.next();
let in_ = ReadableStream.from(stdinInputs).getReader(); if (done) {
controller.close();
} else {
controller.enqueue(value);
}
},
});
}
let in_ = iteratorToStream(stdinInputs.values()).getReader();
if (command.input?.syncLines) { if (command.input?.syncLines) {
in_ = new SyncLinesReader({ delegate: in_ }); in_ = new SyncLinesReader({ delegate: in_ });
} }