2024-04-09 08:24:03 +00:00
|
|
|
# Server test suite. Copyright (C) 2009 Salvatore Sanfilippo antirez@gmail.com
|
2014-07-31 18:25:48 +00:00
|
|
|
# This software is released under the BSD License. See the COPYING file for
|
2010-05-14 15:31:11 +00:00
|
|
|
# more information.
|
|
|
|
|
2013-01-23 22:36:59 +00:00
|
|
|
package require Tcl 8.5
|
|
|
|
|
2010-05-14 15:31:11 +00:00
|
|
|
set tcl_precision 17
|
2024-04-24 18:54:52 +00:00
|
|
|
source tests/support/valkey.tcl
|
Implement Multi Part AOF mechanism to avoid AOFRW overheads. (#9788)
Implement Multi-Part AOF mechanism to avoid overheads during AOFRW.
Introducing a folder with multiple AOF files tracked by a manifest file.
The main issues with the the original AOFRW mechanism are:
* buffering of commands that are processed during rewrite (consuming a lot of RAM)
* freezes of the main process when the AOFRW completes to drain the remaining part of the buffer and fsync it.
* double disk IO for the data that arrives during AOFRW (had to be written to both the old and new AOF files)
The main modifications of this PR:
1. Remove the AOF rewrite buffer and related code.
2. Divide the AOF into multiple files, they are classified as two types, one is the the `BASE` type,
it represents the full amount of data (Maybe AOF or RDB format) after each AOFRW, there is only
one `BASE` file at most. The second is `INCR` type, may have more than one. They represent the
incremental commands since the last AOFRW.
3. Use a AOF manifest file to record and manage these AOF files mentioned above.
4. The original configuration of `appendfilename` will be the base part of the new file name, for example:
`appendonly.aof.1.base.rdb` and `appendonly.aof.2.incr.aof`
5. Add manifest-related TCL tests, and modified some existing tests that depend on the `appendfilename`
6. Remove the `aof_rewrite_buffer_length` field in info.
7. Add `aof-disable-auto-gc` configuration. By default we're automatically deleting HISTORY type AOFs.
It also gives users the opportunity to preserve the history AOFs. just for testing use now.
8. Add AOFRW limiting measure. When the AOFRW failures reaches the threshold (3 times now),
we will delay the execution of the next AOFRW by 1 minute. If the next AOFRW also fails, it will be
delayed by 2 minutes. The next is 4, 8, 16, the maximum delay is 60 minutes (1 hour). During the limit
period, we can still use the 'bgrewriteaof' command to execute AOFRW immediately.
9. Support upgrade (load) data from old version redis.
10. Add `appenddirname` configuration, as the directory name of the append only files. All AOF files and
manifest file will be placed in this directory.
11. Only the last AOF file (BASE or INCR) can be truncated. Otherwise redis will exit even if
`aof-load-truncated` is enabled.
Co-authored-by: Oran Agra <oran@redislabs.com>
2022-01-03 17:14:13 +00:00
|
|
|
source tests/support/aofmanifest.tcl
|
2010-05-14 16:48:33 +00:00
|
|
|
source tests/support/server.tcl
|
2022-11-02 02:26:44 +00:00
|
|
|
source tests/support/cluster_util.tcl
|
2010-05-14 16:48:33 +00:00
|
|
|
source tests/support/tmpfile.tcl
|
|
|
|
source tests/support/test.tcl
|
|
|
|
source tests/support/util.tcl
|
2010-05-14 15:31:11 +00:00
|
|
|
|
2024-04-15 12:25:33 +00:00
|
|
|
set dir [pwd]
|
|
|
|
set ::all_tests []
|
|
|
|
|
|
|
|
set test_dirs {
|
|
|
|
unit
|
|
|
|
unit/type
|
|
|
|
unit/cluster
|
|
|
|
integration
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach test_dir $test_dirs {
|
|
|
|
set files [glob -nocomplain $dir/tests/$test_dir/*.tcl]
|
|
|
|
|
|
|
|
foreach file $files {
|
|
|
|
lappend ::all_tests $test_dir/[file root [file tail $file]]
|
|
|
|
}
|
2011-07-10 21:25:48 +00:00
|
|
|
}
|
|
|
|
# Index to the next test to run in the ::all_tests list.
|
|
|
|
set ::next_test 0
|
|
|
|
|
2010-05-14 15:31:11 +00:00
|
|
|
set ::host 127.0.0.1
|
2020-05-26 08:00:48 +00:00
|
|
|
set ::port 6379; # port for external server
|
2024-04-09 08:24:03 +00:00
|
|
|
set ::baseport 21111; # initial port for spawned servers
|
2020-05-26 08:00:48 +00:00
|
|
|
set ::portcount 8000; # we don't wanna use more than 10000 to avoid collision with cluster bus ports
|
2010-08-26 11:18:56 +00:00
|
|
|
set ::traceleaks 0
|
2010-05-21 10:00:13 +00:00
|
|
|
set ::valgrind 0
|
2020-08-31 08:24:17 +00:00
|
|
|
set ::durable 0
|
2019-09-12 07:56:54 +00:00
|
|
|
set ::tls 0
|
Build TLS as a loadable module
* Support BUILD_TLS=module to be loaded as a module via config file or
command line. e.g. redis-server --loadmodule redis-tls.so
* Updates to redismodule.h to allow it to be used side by side with
server.h by defining REDISMODULE_CORE_MODULE
* Changes to server.h, redismodule.h and module.c to avoid repeated
type declarations (gcc 4.8 doesn't like these)
* Add a mechanism for non-ABI neutral modules (ones who include
server.h) to refuse loading if they detect not being built together with
redis (release.c)
* Fix wrong signature of RedisModuleDefragFunc, this could break
compilation of a module, but not the ABI
* Move initialization of listeners in server.c to be after loading
the modules
* Config TLS after initialization of listeners
* Init cluster after initialization of listeners
* Add TLS module to CI
* Fix a test suite race conditions:
Now that the listeners are initialized later, it's not sufficient to
wait for the PID message in the log, we need to wait for the "Server
Initialized" message.
* Fix issues with moduleconfigs test as a result from start_server
waiting for "Server Initialized"
* Fix issues with modules/infra test as a result of an additional module
present
Notes about Sentinel:
Sentinel can't really rely on the tls module, since it uses hiredis to
initiate connections and depends on OpenSSL (won't be able to use any
other connection modules for that), so it was decided that when TLS is
built as a module, sentinel does not support TLS at all.
This means that it keeps using redis_tls_ctx and redis_tls_client_ctx directly.
Example code of config in redis-tls.so(may be use in the future):
RedisModuleString *tls_cfg = NULL;
void tlsInfo(RedisModuleInfoCtx *ctx, int for_crash_report) {
UNUSED(for_crash_report);
RedisModule_InfoAddSection(ctx, "");
RedisModule_InfoAddFieldLongLong(ctx, "var", 42);
}
int tlsCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc)
{
if (argc != 2) return RedisModule_WrongArity(ctx);
return RedisModule_ReplyWithString(ctx, argv[1]);
}
RedisModuleString *getStringConfigCommand(const char *name, void *privdata) {
REDISMODULE_NOT_USED(name);
REDISMODULE_NOT_USED(privdata);
return tls_cfg;
}
int setStringConfigCommand(const char *name, RedisModuleString *new, void *privdata, RedisModuleString **err) {
REDISMODULE_NOT_USED(name);
REDISMODULE_NOT_USED(err);
REDISMODULE_NOT_USED(privdata);
if (tls_cfg) RedisModule_FreeString(NULL, tls_cfg);
RedisModule_RetainString(NULL, new);
tls_cfg = new;
return REDISMODULE_OK;
}
int RedisModule_OnLoad(void *ctx, RedisModuleString **argv, int argc)
{
....
if (RedisModule_CreateCommand(ctx,"tls",tlsCommand,"",0,0,0) == REDISMODULE_ERR)
return REDISMODULE_ERR;
if (RedisModule_RegisterStringConfig(ctx, "cfg", "", REDISMODULE_CONFIG_DEFAULT, getStringConfigCommand, setStringConfigCommand, NULL, NULL) == REDISMODULE_ERR)
return REDISMODULE_ERR;
if (RedisModule_LoadConfigs(ctx) == REDISMODULE_ERR) {
if (tls_cfg) {
RedisModule_FreeString(ctx, tls_cfg);
tls_cfg = NULL;
}
return REDISMODULE_ERR;
}
...
}
Co-authored-by: zhenwei pi <pizhenwei@bytedance.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
2022-08-22 07:53:56 +00:00
|
|
|
set ::tls_module 0
|
2015-09-23 09:44:40 +00:00
|
|
|
set ::stack_logging 0
|
2011-01-09 18:42:56 +00:00
|
|
|
set ::verbose 0
|
2011-11-29 15:29:12 +00:00
|
|
|
set ::quiet 0
|
2010-06-02 20:53:22 +00:00
|
|
|
set ::denytags {}
|
2018-07-30 13:43:21 +00:00
|
|
|
set ::skiptests {}
|
2020-08-31 08:05:30 +00:00
|
|
|
set ::skipunits {}
|
2020-10-22 08:10:53 +00:00
|
|
|
set ::no_latency 0
|
2010-06-02 20:53:22 +00:00
|
|
|
set ::allowtags {}
|
2018-07-30 13:43:21 +00:00
|
|
|
set ::only_tests {}
|
|
|
|
set ::single_tests {}
|
2020-04-16 08:05:03 +00:00
|
|
|
set ::run_solo_tests {}
|
2018-07-30 13:43:21 +00:00
|
|
|
set ::skip_till ""
|
2010-06-14 08:19:45 +00:00
|
|
|
set ::external 0; # If "1" this means, we are running against external instance
|
2010-10-13 07:26:44 +00:00
|
|
|
set ::file ""; # If set, runs only the tests in this comma separated list
|
2010-12-10 15:13:21 +00:00
|
|
|
set ::curfile ""; # Hold the filename of the current suite
|
2011-07-11 09:59:55 +00:00
|
|
|
set ::accurate 0; # If true runs fuzz tests with more iterations
|
2011-07-11 10:44:55 +00:00
|
|
|
set ::force_failure 0
|
2020-02-21 12:48:43 +00:00
|
|
|
set ::timeout 1200; # 20 minutes without progresses will quit the test.
|
2014-11-28 10:05:58 +00:00
|
|
|
set ::last_progress [clock seconds]
|
2024-04-09 08:24:03 +00:00
|
|
|
set ::active_servers {} ; # Pids of active server instances.
|
2018-06-26 11:14:04 +00:00
|
|
|
set ::dont_clean 0
|
Add reply_schema to command json files (internal for now) (#10273)
Work in progress towards implementing a reply schema as part of COMMAND DOCS, see #9845
Since ironing the details of the reply schema of each and every command can take a long time, we
would like to merge this PR when the infrastructure is ready, and let this mature in the unstable branch.
Meanwhile the changes of this PR are internal, they are part of the repo, but do not affect the produced build.
### Background
In #9656 we add a lot of information about Redis commands, but we are missing information about the replies
### Motivation
1. Documentation. This is the primary goal.
2. It should be possible, based on the output of COMMAND, to be able to generate client code in typed
languages. In order to do that, we need Redis to tell us, in detail, what each reply looks like.
3. We would like to build a fuzzer that verifies the reply structure (for now we use the existing
testsuite, see the "Testing" section)
### Schema
The idea is to supply some sort of schema for the various replies of each command.
The schema will describe the conceptual structure of the reply (for generated clients), as defined in RESP3.
Note that the reply structure itself may change, depending on the arguments (e.g. `XINFO STREAM`, with
and without the `FULL` modifier)
We decided to use the standard json-schema (see https://json-schema.org/) as the reply-schema.
Example for `BZPOPMIN`:
```
"reply_schema": {
"oneOf": [
{
"description": "Timeout reached and no elements were popped.",
"type": "null"
},
{
"description": "The keyname, popped member, and its score.",
"type": "array",
"minItems": 3,
"maxItems": 3,
"items": [
{
"description": "Keyname",
"type": "string"
},
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
]
}
```
#### Notes
1. It is ok that some commands' reply structure depends on the arguments and it's the caller's responsibility
to know which is the relevant one. this comes after looking at other request-reply systems like OpenAPI,
where the reply schema can also be oneOf and the caller is responsible to know which schema is the relevant one.
2. The reply schemas will describe RESP3 replies only. even though RESP3 is structured, we want to use reply
schema for documentation (and possibly to create a fuzzer that validates the replies)
3. For documentation, the description field will include an explanation of the scenario in which the reply is sent,
including any relation to arguments. for example, for `ZRANGE`'s two schemas we will need to state that one
is with `WITHSCORES` and the other is without.
4. For documentation, there will be another optional field "notes" in which we will add a short description of
the representation in RESP2, in case it's not trivial (RESP3's `ZRANGE`'s nested array vs. RESP2's flat
array, for example)
Given the above:
1. We can generate the "return" section of all commands in [redis-doc](https://redis.io/commands/)
(given that "description" and "notes" are comprehensive enough)
2. We can generate a client in a strongly typed language (but the return type could be a conceptual
`union` and the caller needs to know which schema is relevant). see the section below for RESP2 support.
3. We can create a fuzzer for RESP3.
### Limitations (because we are using the standard json-schema)
The problem is that Redis' replies are more diverse than what the json format allows. This means that,
when we convert the reply to a json (in order to validate the schema against it), we lose information (see
the "Testing" section below).
The other option would have been to extend the standard json-schema (and json format) to include stuff
like sets, bulk-strings, error-string, etc. but that would mean also extending the schema-validator - and that
seemed like too much work, so we decided to compromise.
Examples:
1. We cannot tell the difference between an "array" and a "set"
2. We cannot tell the difference between simple-string and bulk-string
3. we cannot verify true uniqueness of items in commands like ZRANGE: json-schema doesn't cover the
case of two identical members with different scores (e.g. `[["m1",6],["m1",7]]`) because `uniqueItems`
compares (member,score) tuples and not just the member name.
### Testing
This commit includes some changes inside Redis in order to verify the schemas (existing and future ones)
are indeed correct (i.e. describe the actual response of Redis).
To do that, we added a debugging feature to Redis that causes it to produce a log of all the commands
it executed and their replies.
For that, Redis needs to be compiled with `-DLOG_REQ_RES` and run with
`--reg-res-logfile <file> --client-default-resp 3` (the testsuite already does that if you run it with
`--log-req-res --force-resp3`)
You should run the testsuite with the above args (and `--dont-clean`) in order to make Redis generate
`.reqres` files (same dir as the `stdout` files) which contain request-response pairs.
These files are later on processed by `./utils/req-res-log-validator.py` which does:
1. Goes over req-res files, generated by redis-servers, spawned by the testsuite (see logreqres.c)
2. For each request-response pair, it validates the response against the request's reply_schema
(obtained from the extended COMMAND DOCS)
5. In order to get good coverage of the Redis commands, and all their different replies, we chose to use
the existing redis test suite, rather than attempt to write a fuzzer.
#### Notes about RESP2
1. We will not be able to use the testing tool to verify RESP2 replies (we are ok with that, it's time to
accept RESP3 as the future RESP)
2. Since the majority of the test suite is using RESP2, and we want the server to reply with RESP3
so that we can validate it, we will need to know how to convert the actual reply to the one expected.
- number and boolean are always strings in RESP2 so the conversion is easy
- objects (maps) are always a flat array in RESP2
- others (nested array in RESP3's `ZRANGE` and others) will need some special per-command
handling (so the client will not be totally auto-generated)
Example for ZRANGE:
```
"reply_schema": {
"anyOf": [
{
"description": "A list of member elements",
"type": "array",
"uniqueItems": true,
"items": {
"type": "string"
}
},
{
"description": "Members and their scores. Returned in case `WITHSCORES` was used.",
"notes": "In RESP2 this is returned as a flat array",
"type": "array",
"uniqueItems": true,
"items": {
"type": "array",
"minItems": 2,
"maxItems": 2,
"items": [
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
}
]
}
```
### Other changes
1. Some tests that behave differently depending on the RESP are now being tested for both RESP,
regardless of the special log-req-res mode ("Pub/Sub PING" for example)
2. Update the history field of CLIENT LIST
3. Added basic tests for commands that were not covered at all by the testsuite
### TODO
- [x] (maybe a different PR) add a "condition" field to anyOf/oneOf schemas that refers to args. e.g.
when `SET` return NULL, the condition is `arguments.get||arguments.condition`, for `OK` the condition
is `!arguments.get`, and for `string` the condition is `arguments.get` - https://github.com/redis/redis/issues/11896
- [x] (maybe a different PR) also run `runtest-cluster` in the req-res logging mode
- [x] add the new tests to GH actions (i.e. compile with `-DLOG_REQ_RES`, run the tests, and run the validator)
- [x] (maybe a different PR) figure out a way to warn about (sub)schemas that are uncovered by the output
of the tests - https://github.com/redis/redis/issues/11897
- [x] (probably a separate PR) add all missing schemas
- [x] check why "SDOWN is triggered by misconfigured instance replying with errors" fails with --log-req-res
- [x] move the response transformers to their own file (run both regular, cluster, and sentinel tests - need to
fight with the tcl including mechanism a bit)
- [x] issue: module API - https://github.com/redis/redis/issues/11898
- [x] (probably a separate PR): improve schemas: add `required` to `object`s - https://github.com/redis/redis/issues/11899
Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com>
Co-authored-by: Hanna Fadida <hanna.fadida@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Shaya Potter <shaya@redislabs.com>
2023-03-11 08:14:16 +00:00
|
|
|
set ::dont_pre_clean 0
|
2018-06-26 11:14:04 +00:00
|
|
|
set ::wait_server 0
|
2018-08-02 16:49:49 +00:00
|
|
|
set ::stop_on_failure 0
|
2021-02-07 10:37:24 +00:00
|
|
|
set ::dump_logs 0
|
2018-08-02 17:07:17 +00:00
|
|
|
set ::loop 0
|
2019-09-12 07:56:54 +00:00
|
|
|
set ::tlsdir "tests/tls"
|
2021-06-09 12:13:24 +00:00
|
|
|
set ::singledb 0
|
|
|
|
set ::cluster_mode 0
|
|
|
|
set ::ignoreencoding 0
|
|
|
|
set ::ignoredigest 0
|
2021-11-03 18:47:18 +00:00
|
|
|
set ::large_memory 0
|
Add reply_schema to command json files (internal for now) (#10273)
Work in progress towards implementing a reply schema as part of COMMAND DOCS, see #9845
Since ironing the details of the reply schema of each and every command can take a long time, we
would like to merge this PR when the infrastructure is ready, and let this mature in the unstable branch.
Meanwhile the changes of this PR are internal, they are part of the repo, but do not affect the produced build.
### Background
In #9656 we add a lot of information about Redis commands, but we are missing information about the replies
### Motivation
1. Documentation. This is the primary goal.
2. It should be possible, based on the output of COMMAND, to be able to generate client code in typed
languages. In order to do that, we need Redis to tell us, in detail, what each reply looks like.
3. We would like to build a fuzzer that verifies the reply structure (for now we use the existing
testsuite, see the "Testing" section)
### Schema
The idea is to supply some sort of schema for the various replies of each command.
The schema will describe the conceptual structure of the reply (for generated clients), as defined in RESP3.
Note that the reply structure itself may change, depending on the arguments (e.g. `XINFO STREAM`, with
and without the `FULL` modifier)
We decided to use the standard json-schema (see https://json-schema.org/) as the reply-schema.
Example for `BZPOPMIN`:
```
"reply_schema": {
"oneOf": [
{
"description": "Timeout reached and no elements were popped.",
"type": "null"
},
{
"description": "The keyname, popped member, and its score.",
"type": "array",
"minItems": 3,
"maxItems": 3,
"items": [
{
"description": "Keyname",
"type": "string"
},
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
]
}
```
#### Notes
1. It is ok that some commands' reply structure depends on the arguments and it's the caller's responsibility
to know which is the relevant one. this comes after looking at other request-reply systems like OpenAPI,
where the reply schema can also be oneOf and the caller is responsible to know which schema is the relevant one.
2. The reply schemas will describe RESP3 replies only. even though RESP3 is structured, we want to use reply
schema for documentation (and possibly to create a fuzzer that validates the replies)
3. For documentation, the description field will include an explanation of the scenario in which the reply is sent,
including any relation to arguments. for example, for `ZRANGE`'s two schemas we will need to state that one
is with `WITHSCORES` and the other is without.
4. For documentation, there will be another optional field "notes" in which we will add a short description of
the representation in RESP2, in case it's not trivial (RESP3's `ZRANGE`'s nested array vs. RESP2's flat
array, for example)
Given the above:
1. We can generate the "return" section of all commands in [redis-doc](https://redis.io/commands/)
(given that "description" and "notes" are comprehensive enough)
2. We can generate a client in a strongly typed language (but the return type could be a conceptual
`union` and the caller needs to know which schema is relevant). see the section below for RESP2 support.
3. We can create a fuzzer for RESP3.
### Limitations (because we are using the standard json-schema)
The problem is that Redis' replies are more diverse than what the json format allows. This means that,
when we convert the reply to a json (in order to validate the schema against it), we lose information (see
the "Testing" section below).
The other option would have been to extend the standard json-schema (and json format) to include stuff
like sets, bulk-strings, error-string, etc. but that would mean also extending the schema-validator - and that
seemed like too much work, so we decided to compromise.
Examples:
1. We cannot tell the difference between an "array" and a "set"
2. We cannot tell the difference between simple-string and bulk-string
3. we cannot verify true uniqueness of items in commands like ZRANGE: json-schema doesn't cover the
case of two identical members with different scores (e.g. `[["m1",6],["m1",7]]`) because `uniqueItems`
compares (member,score) tuples and not just the member name.
### Testing
This commit includes some changes inside Redis in order to verify the schemas (existing and future ones)
are indeed correct (i.e. describe the actual response of Redis).
To do that, we added a debugging feature to Redis that causes it to produce a log of all the commands
it executed and their replies.
For that, Redis needs to be compiled with `-DLOG_REQ_RES` and run with
`--reg-res-logfile <file> --client-default-resp 3` (the testsuite already does that if you run it with
`--log-req-res --force-resp3`)
You should run the testsuite with the above args (and `--dont-clean`) in order to make Redis generate
`.reqres` files (same dir as the `stdout` files) which contain request-response pairs.
These files are later on processed by `./utils/req-res-log-validator.py` which does:
1. Goes over req-res files, generated by redis-servers, spawned by the testsuite (see logreqres.c)
2. For each request-response pair, it validates the response against the request's reply_schema
(obtained from the extended COMMAND DOCS)
5. In order to get good coverage of the Redis commands, and all their different replies, we chose to use
the existing redis test suite, rather than attempt to write a fuzzer.
#### Notes about RESP2
1. We will not be able to use the testing tool to verify RESP2 replies (we are ok with that, it's time to
accept RESP3 as the future RESP)
2. Since the majority of the test suite is using RESP2, and we want the server to reply with RESP3
so that we can validate it, we will need to know how to convert the actual reply to the one expected.
- number and boolean are always strings in RESP2 so the conversion is easy
- objects (maps) are always a flat array in RESP2
- others (nested array in RESP3's `ZRANGE` and others) will need some special per-command
handling (so the client will not be totally auto-generated)
Example for ZRANGE:
```
"reply_schema": {
"anyOf": [
{
"description": "A list of member elements",
"type": "array",
"uniqueItems": true,
"items": {
"type": "string"
}
},
{
"description": "Members and their scores. Returned in case `WITHSCORES` was used.",
"notes": "In RESP2 this is returned as a flat array",
"type": "array",
"uniqueItems": true,
"items": {
"type": "array",
"minItems": 2,
"maxItems": 2,
"items": [
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
}
]
}
```
### Other changes
1. Some tests that behave differently depending on the RESP are now being tested for both RESP,
regardless of the special log-req-res mode ("Pub/Sub PING" for example)
2. Update the history field of CLIENT LIST
3. Added basic tests for commands that were not covered at all by the testsuite
### TODO
- [x] (maybe a different PR) add a "condition" field to anyOf/oneOf schemas that refers to args. e.g.
when `SET` return NULL, the condition is `arguments.get||arguments.condition`, for `OK` the condition
is `!arguments.get`, and for `string` the condition is `arguments.get` - https://github.com/redis/redis/issues/11896
- [x] (maybe a different PR) also run `runtest-cluster` in the req-res logging mode
- [x] add the new tests to GH actions (i.e. compile with `-DLOG_REQ_RES`, run the tests, and run the validator)
- [x] (maybe a different PR) figure out a way to warn about (sub)schemas that are uncovered by the output
of the tests - https://github.com/redis/redis/issues/11897
- [x] (probably a separate PR) add all missing schemas
- [x] check why "SDOWN is triggered by misconfigured instance replying with errors" fails with --log-req-res
- [x] move the response transformers to their own file (run both regular, cluster, and sentinel tests - need to
fight with the tcl including mechanism a bit)
- [x] issue: module API - https://github.com/redis/redis/issues/11898
- [x] (probably a separate PR): improve schemas: add `required` to `object`s - https://github.com/redis/redis/issues/11899
Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com>
Co-authored-by: Hanna Fadida <hanna.fadida@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Shaya Potter <shaya@redislabs.com>
2023-03-11 08:14:16 +00:00
|
|
|
set ::log_req_res 0
|
|
|
|
set ::force_resp3 0
|
2011-07-10 21:25:48 +00:00
|
|
|
|
2024-04-09 08:24:03 +00:00
|
|
|
# Set to 1 when we are running in client mode. The server test uses a
|
2011-07-10 21:25:48 +00:00
|
|
|
# server-client model to run tests simultaneously. The server instance
|
|
|
|
# runs the specified number of client instances that will actually run tests.
|
|
|
|
# The server is responsible of showing the result to the user, and exit with
|
|
|
|
# the appropriate exit code depending on the test outcome.
|
|
|
|
set ::client 0
|
|
|
|
set ::numclients 16
|
2010-05-14 15:31:11 +00:00
|
|
|
|
2020-04-17 08:51:12 +00:00
|
|
|
# This function is called by one of the test clients when it receives
|
|
|
|
# a "run" command from the server, with a filename as data.
|
|
|
|
# It will run the specified test source file and signal it to the
|
|
|
|
# test server when finished.
|
2021-06-06 14:35:30 +00:00
|
|
|
proc execute_test_file __testname {
|
|
|
|
set path "tests/$__testname.tcl"
|
2010-12-10 15:13:21 +00:00
|
|
|
set ::curfile $path
|
|
|
|
source $path
|
2021-06-06 14:35:30 +00:00
|
|
|
send_data_packet $::test_server_fd done "$__testname"
|
2010-05-14 15:31:11 +00:00
|
|
|
}
|
|
|
|
|
2020-04-17 08:51:12 +00:00
|
|
|
# This function is called by one of the test clients when it receives
|
|
|
|
# a "run_code" command from the server, with a verbatim test source code
|
|
|
|
# as argument, and an associated name.
|
|
|
|
# It will run the specified code and signal it to the test server when
|
|
|
|
# finished.
|
2021-06-06 14:35:30 +00:00
|
|
|
proc execute_test_code {__testname filename code} {
|
2020-11-04 15:50:31 +00:00
|
|
|
set ::curfile $filename
|
2020-04-16 08:05:03 +00:00
|
|
|
eval $code
|
2021-06-06 14:35:30 +00:00
|
|
|
send_data_packet $::test_server_fd done "$__testname"
|
2020-04-16 08:05:03 +00:00
|
|
|
}
|
|
|
|
|
2010-05-14 18:50:32 +00:00
|
|
|
# Setup a list to hold a stack of server configs. When calls to start_server
|
|
|
|
# are nested, use "srv 0 pid" to get the pid of the inner server. To access
|
|
|
|
# outer servers, use "srv -1 pid" etcetera.
|
|
|
|
set ::servers {}
|
2010-08-04 12:15:52 +00:00
|
|
|
proc srv {args} {
|
|
|
|
set level 0
|
|
|
|
if {[string is integer [lindex $args 0]]} {
|
|
|
|
set level [lindex $args 0]
|
|
|
|
set property [lindex $args 1]
|
|
|
|
} else {
|
|
|
|
set property [lindex $args 0]
|
|
|
|
}
|
2010-05-14 18:50:32 +00:00
|
|
|
set srv [lindex $::servers end+$level]
|
|
|
|
dict get $srv $property
|
|
|
|
}
|
|
|
|
|
2023-09-27 06:08:18 +00:00
|
|
|
# Take an index to get a srv.
|
|
|
|
proc get_srv {level} {
|
|
|
|
set srv [lindex $::servers end+$level]
|
|
|
|
return $srv
|
|
|
|
}
|
|
|
|
|
2010-05-14 18:50:32 +00:00
|
|
|
# Provide easy access to the client for the inner server. It's possible to
|
|
|
|
# prepend the argument list with a negative level to access clients for
|
|
|
|
# servers running in outer blocks.
|
2010-05-14 15:31:11 +00:00
|
|
|
proc r {args} {
|
2010-05-14 18:50:32 +00:00
|
|
|
set level 0
|
|
|
|
if {[string is integer [lindex $args 0]]} {
|
|
|
|
set level [lindex $args 0]
|
|
|
|
set args [lrange $args 1 end]
|
|
|
|
}
|
|
|
|
[srv $level "client"] {*}$args
|
|
|
|
}
|
|
|
|
|
2024-04-09 08:24:03 +00:00
|
|
|
# Returns a server instance by index.
|
2022-11-02 02:26:44 +00:00
|
|
|
proc Rn {n} {
|
|
|
|
set level [expr -1*$n]
|
|
|
|
return [srv $level "client"]
|
|
|
|
}
|
|
|
|
|
2022-07-12 17:41:29 +00:00
|
|
|
# Provide easy access to a client for an inner server. Requires a positive
|
|
|
|
# index, unlike r which uses an optional negative index.
|
|
|
|
proc R {n args} {
|
2022-11-02 02:26:44 +00:00
|
|
|
[Rn $n] {*}$args
|
2022-07-12 17:41:29 +00:00
|
|
|
}
|
|
|
|
|
2010-10-13 09:25:40 +00:00
|
|
|
proc reconnect {args} {
|
|
|
|
set level [lindex $args 0]
|
|
|
|
if {[string length $level] == 0 || ![string is integer $level]} {
|
|
|
|
set level 0
|
|
|
|
}
|
|
|
|
|
|
|
|
set srv [lindex $::servers end+$level]
|
|
|
|
set host [dict get $srv "host"]
|
|
|
|
set port [dict get $srv "port"]
|
|
|
|
set config [dict get $srv "config"]
|
2024-04-18 13:57:17 +00:00
|
|
|
set client [valkey $host $port 0 $::tls]
|
2020-11-22 19:21:42 +00:00
|
|
|
if {[dict exists $srv "client"]} {
|
|
|
|
set old [dict get $srv "client"]
|
|
|
|
$old close
|
|
|
|
}
|
2010-10-13 09:25:40 +00:00
|
|
|
dict set srv "client" $client
|
|
|
|
|
|
|
|
# select the right db when we don't have to authenticate
|
2021-06-09 12:13:24 +00:00
|
|
|
if {![dict exists $config "requirepass"] && !$::singledb} {
|
2010-10-13 09:25:40 +00:00
|
|
|
$client select 9
|
|
|
|
}
|
|
|
|
|
|
|
|
# re-set $srv in the servers list
|
2012-01-06 16:28:40 +00:00
|
|
|
lset ::servers end+$level $srv
|
2010-10-13 09:25:40 +00:00
|
|
|
}
|
|
|
|
|
2024-04-09 14:38:09 +00:00
|
|
|
proc valkey_deferring_client {args} {
|
2010-06-15 19:16:27 +00:00
|
|
|
set level 0
|
|
|
|
if {[llength $args] > 0 && [string is integer [lindex $args 0]]} {
|
|
|
|
set level [lindex $args 0]
|
|
|
|
set args [lrange $args 1 end]
|
|
|
|
}
|
|
|
|
|
|
|
|
# create client that defers reading reply
|
2024-04-18 13:57:17 +00:00
|
|
|
set client [valkey [srv $level "host"] [srv $level "port"] 1 $::tls]
|
2010-06-15 19:16:27 +00:00
|
|
|
|
|
|
|
# select the right db and read the response (OK)
|
2021-06-09 12:13:24 +00:00
|
|
|
if {!$::singledb} {
|
|
|
|
$client select 9
|
|
|
|
$client read
|
|
|
|
} else {
|
|
|
|
# For timing/symmetry with the above select
|
|
|
|
$client ping
|
|
|
|
$client read
|
|
|
|
}
|
2010-06-15 19:16:27 +00:00
|
|
|
return $client
|
|
|
|
}
|
|
|
|
|
2024-04-10 14:18:47 +00:00
|
|
|
proc valkey_client {args} {
|
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 18:09:35 +00:00
|
|
|
set level 0
|
|
|
|
if {[llength $args] > 0 && [string is integer [lindex $args 0]]} {
|
|
|
|
set level [lindex $args 0]
|
|
|
|
set args [lrange $args 1 end]
|
|
|
|
}
|
|
|
|
|
2024-02-20 09:12:19 +00:00
|
|
|
# create client that won't defers reading reply
|
2024-04-18 13:57:17 +00:00
|
|
|
set client [valkey [srv $level "host"] [srv $level "port"] 0 $::tls]
|
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 18:09:35 +00:00
|
|
|
|
2021-06-09 12:13:24 +00:00
|
|
|
# select the right db and read the response (OK), or at least ping
|
|
|
|
# the server if we're in a singledb mode.
|
|
|
|
if {$::singledb} {
|
|
|
|
$client ping
|
|
|
|
} else {
|
|
|
|
$client select 9
|
|
|
|
}
|
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 18:09:35 +00:00
|
|
|
return $client
|
|
|
|
}
|
|
|
|
|
2010-05-14 18:50:32 +00:00
|
|
|
# Provide easy access to INFO properties. Same semantic as "proc r".
|
|
|
|
proc s {args} {
|
|
|
|
set level 0
|
|
|
|
if {[string is integer [lindex $args 0]]} {
|
|
|
|
set level [lindex $args 0]
|
|
|
|
set args [lrange $args 1 end]
|
|
|
|
}
|
|
|
|
status [srv $level "client"] [lindex $args 0]
|
2010-05-14 15:31:11 +00:00
|
|
|
}
|
|
|
|
|
2022-07-12 17:41:29 +00:00
|
|
|
# Get the specified field from the givens instances cluster info output.
|
|
|
|
proc CI {index field} {
|
|
|
|
getInfoProperty [R $index cluster info] $field
|
2022-04-26 09:09:21 +00:00
|
|
|
}
|
|
|
|
|
2020-04-16 08:05:03 +00:00
|
|
|
# Test wrapped into run_solo are sent back from the client to the
|
|
|
|
# test server, so that the test server will send them again to
|
|
|
|
# clients once the clients are idle.
|
|
|
|
proc run_solo {name code} {
|
|
|
|
if {$::numclients == 1 || $::loop || $::external} {
|
|
|
|
# run_solo is not supported in these scenarios, just run the code.
|
|
|
|
eval $code
|
|
|
|
return
|
|
|
|
}
|
2020-11-04 15:50:31 +00:00
|
|
|
send_data_packet $::test_server_fd run_solo [list $name $::curfile $code]
|
2020-04-16 08:05:03 +00:00
|
|
|
}
|
|
|
|
|
2010-05-20 11:58:58 +00:00
|
|
|
proc cleanup {} {
|
2011-11-29 15:29:12 +00:00
|
|
|
if {!$::quiet} {puts -nonewline "Cleanup: may take some time... "}
|
2011-07-10 21:25:48 +00:00
|
|
|
flush stdout
|
2024-04-03 17:47:26 +00:00
|
|
|
catch {exec rm -rf {*}[glob tests/tmp/valkey.conf.*]}
|
2024-03-26 15:26:22 +00:00
|
|
|
catch {exec rm -rf {*}[glob tests/tmp/server*.*]}
|
|
|
|
catch {exec rm -rf {*}[glob tests/tmp/*.acl.*]}
|
2011-11-29 15:29:12 +00:00
|
|
|
if {!$::quiet} {puts "OK"}
|
2010-05-20 11:58:58 +00:00
|
|
|
}
|
|
|
|
|
2011-07-10 21:25:48 +00:00
|
|
|
proc test_server_main {} {
|
Add reply_schema to command json files (internal for now) (#10273)
Work in progress towards implementing a reply schema as part of COMMAND DOCS, see #9845
Since ironing the details of the reply schema of each and every command can take a long time, we
would like to merge this PR when the infrastructure is ready, and let this mature in the unstable branch.
Meanwhile the changes of this PR are internal, they are part of the repo, but do not affect the produced build.
### Background
In #9656 we add a lot of information about Redis commands, but we are missing information about the replies
### Motivation
1. Documentation. This is the primary goal.
2. It should be possible, based on the output of COMMAND, to be able to generate client code in typed
languages. In order to do that, we need Redis to tell us, in detail, what each reply looks like.
3. We would like to build a fuzzer that verifies the reply structure (for now we use the existing
testsuite, see the "Testing" section)
### Schema
The idea is to supply some sort of schema for the various replies of each command.
The schema will describe the conceptual structure of the reply (for generated clients), as defined in RESP3.
Note that the reply structure itself may change, depending on the arguments (e.g. `XINFO STREAM`, with
and without the `FULL` modifier)
We decided to use the standard json-schema (see https://json-schema.org/) as the reply-schema.
Example for `BZPOPMIN`:
```
"reply_schema": {
"oneOf": [
{
"description": "Timeout reached and no elements were popped.",
"type": "null"
},
{
"description": "The keyname, popped member, and its score.",
"type": "array",
"minItems": 3,
"maxItems": 3,
"items": [
{
"description": "Keyname",
"type": "string"
},
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
]
}
```
#### Notes
1. It is ok that some commands' reply structure depends on the arguments and it's the caller's responsibility
to know which is the relevant one. this comes after looking at other request-reply systems like OpenAPI,
where the reply schema can also be oneOf and the caller is responsible to know which schema is the relevant one.
2. The reply schemas will describe RESP3 replies only. even though RESP3 is structured, we want to use reply
schema for documentation (and possibly to create a fuzzer that validates the replies)
3. For documentation, the description field will include an explanation of the scenario in which the reply is sent,
including any relation to arguments. for example, for `ZRANGE`'s two schemas we will need to state that one
is with `WITHSCORES` and the other is without.
4. For documentation, there will be another optional field "notes" in which we will add a short description of
the representation in RESP2, in case it's not trivial (RESP3's `ZRANGE`'s nested array vs. RESP2's flat
array, for example)
Given the above:
1. We can generate the "return" section of all commands in [redis-doc](https://redis.io/commands/)
(given that "description" and "notes" are comprehensive enough)
2. We can generate a client in a strongly typed language (but the return type could be a conceptual
`union` and the caller needs to know which schema is relevant). see the section below for RESP2 support.
3. We can create a fuzzer for RESP3.
### Limitations (because we are using the standard json-schema)
The problem is that Redis' replies are more diverse than what the json format allows. This means that,
when we convert the reply to a json (in order to validate the schema against it), we lose information (see
the "Testing" section below).
The other option would have been to extend the standard json-schema (and json format) to include stuff
like sets, bulk-strings, error-string, etc. but that would mean also extending the schema-validator - and that
seemed like too much work, so we decided to compromise.
Examples:
1. We cannot tell the difference between an "array" and a "set"
2. We cannot tell the difference between simple-string and bulk-string
3. we cannot verify true uniqueness of items in commands like ZRANGE: json-schema doesn't cover the
case of two identical members with different scores (e.g. `[["m1",6],["m1",7]]`) because `uniqueItems`
compares (member,score) tuples and not just the member name.
### Testing
This commit includes some changes inside Redis in order to verify the schemas (existing and future ones)
are indeed correct (i.e. describe the actual response of Redis).
To do that, we added a debugging feature to Redis that causes it to produce a log of all the commands
it executed and their replies.
For that, Redis needs to be compiled with `-DLOG_REQ_RES` and run with
`--reg-res-logfile <file> --client-default-resp 3` (the testsuite already does that if you run it with
`--log-req-res --force-resp3`)
You should run the testsuite with the above args (and `--dont-clean`) in order to make Redis generate
`.reqres` files (same dir as the `stdout` files) which contain request-response pairs.
These files are later on processed by `./utils/req-res-log-validator.py` which does:
1. Goes over req-res files, generated by redis-servers, spawned by the testsuite (see logreqres.c)
2. For each request-response pair, it validates the response against the request's reply_schema
(obtained from the extended COMMAND DOCS)
5. In order to get good coverage of the Redis commands, and all their different replies, we chose to use
the existing redis test suite, rather than attempt to write a fuzzer.
#### Notes about RESP2
1. We will not be able to use the testing tool to verify RESP2 replies (we are ok with that, it's time to
accept RESP3 as the future RESP)
2. Since the majority of the test suite is using RESP2, and we want the server to reply with RESP3
so that we can validate it, we will need to know how to convert the actual reply to the one expected.
- number and boolean are always strings in RESP2 so the conversion is easy
- objects (maps) are always a flat array in RESP2
- others (nested array in RESP3's `ZRANGE` and others) will need some special per-command
handling (so the client will not be totally auto-generated)
Example for ZRANGE:
```
"reply_schema": {
"anyOf": [
{
"description": "A list of member elements",
"type": "array",
"uniqueItems": true,
"items": {
"type": "string"
}
},
{
"description": "Members and their scores. Returned in case `WITHSCORES` was used.",
"notes": "In RESP2 this is returned as a flat array",
"type": "array",
"uniqueItems": true,
"items": {
"type": "array",
"minItems": 2,
"maxItems": 2,
"items": [
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
}
]
}
```
### Other changes
1. Some tests that behave differently depending on the RESP are now being tested for both RESP,
regardless of the special log-req-res mode ("Pub/Sub PING" for example)
2. Update the history field of CLIENT LIST
3. Added basic tests for commands that were not covered at all by the testsuite
### TODO
- [x] (maybe a different PR) add a "condition" field to anyOf/oneOf schemas that refers to args. e.g.
when `SET` return NULL, the condition is `arguments.get||arguments.condition`, for `OK` the condition
is `!arguments.get`, and for `string` the condition is `arguments.get` - https://github.com/redis/redis/issues/11896
- [x] (maybe a different PR) also run `runtest-cluster` in the req-res logging mode
- [x] add the new tests to GH actions (i.e. compile with `-DLOG_REQ_RES`, run the tests, and run the validator)
- [x] (maybe a different PR) figure out a way to warn about (sub)schemas that are uncovered by the output
of the tests - https://github.com/redis/redis/issues/11897
- [x] (probably a separate PR) add all missing schemas
- [x] check why "SDOWN is triggered by misconfigured instance replying with errors" fails with --log-req-res
- [x] move the response transformers to their own file (run both regular, cluster, and sentinel tests - need to
fight with the tcl including mechanism a bit)
- [x] issue: module API - https://github.com/redis/redis/issues/11898
- [x] (probably a separate PR): improve schemas: add `required` to `object`s - https://github.com/redis/redis/issues/11899
Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com>
Co-authored-by: Hanna Fadida <hanna.fadida@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Shaya Potter <shaya@redislabs.com>
2023-03-11 08:14:16 +00:00
|
|
|
if {!$::dont_pre_clean} cleanup
|
2013-01-23 22:37:18 +00:00
|
|
|
set tclsh [info nameofexecutable]
|
2011-07-10 21:25:48 +00:00
|
|
|
# Open a listening socket, trying different ports in order to find a
|
|
|
|
# non busy one.
|
2020-11-22 19:21:42 +00:00
|
|
|
set clientport [find_available_port [expr {$::baseport - 32}] 32]
|
2011-11-29 15:29:12 +00:00
|
|
|
if {!$::quiet} {
|
2020-05-26 08:00:48 +00:00
|
|
|
puts "Starting test server at port $clientport"
|
2011-11-29 15:29:12 +00:00
|
|
|
}
|
2020-05-26 08:00:48 +00:00
|
|
|
socket -server accept_test_clients -myaddr 127.0.0.1 $clientport
|
2011-05-31 16:35:09 +00:00
|
|
|
|
2011-07-10 21:25:48 +00:00
|
|
|
# Start the client instances
|
2011-07-10 22:46:25 +00:00
|
|
|
set ::clients_pids {}
|
2020-04-06 06:41:14 +00:00
|
|
|
if {$::external} {
|
2013-01-23 22:37:18 +00:00
|
|
|
set p [exec $tclsh [info script] {*}$::argv \
|
2020-05-26 08:00:48 +00:00
|
|
|
--client $clientport &]
|
2011-07-10 22:46:25 +00:00
|
|
|
lappend ::clients_pids $p
|
2020-04-06 06:41:14 +00:00
|
|
|
} else {
|
2020-05-26 08:00:48 +00:00
|
|
|
set start_port $::baseport
|
|
|
|
set port_count [expr {$::portcount / $::numclients}]
|
2020-04-06 06:41:14 +00:00
|
|
|
for {set j 0} {$j < $::numclients} {incr j} {
|
|
|
|
set p [exec $tclsh [info script] {*}$::argv \
|
2020-05-26 08:00:48 +00:00
|
|
|
--client $clientport --baseport $start_port --portcount $port_count &]
|
2020-04-06 06:41:14 +00:00
|
|
|
lappend ::clients_pids $p
|
2020-05-26 08:00:48 +00:00
|
|
|
incr start_port $port_count
|
2020-04-06 06:41:14 +00:00
|
|
|
}
|
2011-07-10 21:25:48 +00:00
|
|
|
}
|
2010-10-13 07:26:44 +00:00
|
|
|
|
2011-07-10 21:25:48 +00:00
|
|
|
# Setup global state for the test server
|
|
|
|
set ::idle_clients {}
|
|
|
|
set ::active_clients {}
|
2014-01-31 15:25:13 +00:00
|
|
|
array set ::active_clients_task {}
|
2011-07-10 21:57:35 +00:00
|
|
|
array set ::clients_start_time {}
|
|
|
|
set ::clients_time_history {}
|
2011-07-11 10:44:55 +00:00
|
|
|
set ::failed_tests {}
|
2011-07-10 21:25:48 +00:00
|
|
|
|
|
|
|
# Enter the event loop to handle clients I/O
|
|
|
|
after 100 test_server_cron
|
|
|
|
vwait forever
|
|
|
|
}
|
|
|
|
|
2014-11-28 10:05:58 +00:00
|
|
|
# This function gets called 10 times per second.
|
2011-07-10 21:25:48 +00:00
|
|
|
proc test_server_cron {} {
|
2014-11-28 10:05:58 +00:00
|
|
|
set elapsed [expr {[clock seconds]-$::last_progress}]
|
|
|
|
|
|
|
|
if {$elapsed > $::timeout} {
|
|
|
|
set err "\[[colorstr red TIMEOUT]\]: clients state report follows."
|
|
|
|
puts $err
|
2018-06-26 11:14:04 +00:00
|
|
|
lappend ::failed_tests $err
|
2014-11-28 10:05:58 +00:00
|
|
|
show_clients_state
|
|
|
|
kill_clients
|
2014-11-28 10:38:14 +00:00
|
|
|
force_kill_all_servers
|
2014-11-28 10:05:58 +00:00
|
|
|
the_end
|
|
|
|
}
|
|
|
|
|
2014-01-31 15:25:13 +00:00
|
|
|
after 100 test_server_cron
|
2011-07-10 21:25:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
proc accept_test_clients {fd addr port} {
|
2014-01-31 15:25:13 +00:00
|
|
|
fconfigure $fd -encoding binary
|
2011-07-10 21:25:48 +00:00
|
|
|
fileevent $fd readable [list read_from_test_client $fd]
|
|
|
|
}
|
|
|
|
|
|
|
|
# This is the readable handler of our test server. Clients send us messages
|
|
|
|
# in the form of a status code such and additional data. Supported
|
|
|
|
# status types are:
|
|
|
|
#
|
|
|
|
# ready: the client is ready to execute the command. Only sent at client
|
|
|
|
# startup. The server will queue the client FD in the list of idle
|
|
|
|
# clients.
|
|
|
|
# testing: just used to signal that a given test started.
|
|
|
|
# ok: a test was executed with success.
|
|
|
|
# err: a test was executed with an error.
|
2018-07-30 13:43:21 +00:00
|
|
|
# skip: a test was skipped by skipfile or individual test options.
|
|
|
|
# ignore: a test was skipped by a group tag.
|
2011-07-10 21:25:48 +00:00
|
|
|
# exception: there was a runtime exception while executing the test.
|
|
|
|
# done: all the specified test file was processed, this test client is
|
|
|
|
# ready to accept a new task.
|
|
|
|
proc read_from_test_client fd {
|
|
|
|
set bytes [gets $fd]
|
|
|
|
set payload [read $fd $bytes]
|
2022-01-05 11:49:01 +00:00
|
|
|
foreach {status data elapsed} $payload break
|
2014-11-28 10:05:58 +00:00
|
|
|
set ::last_progress [clock seconds]
|
|
|
|
|
2011-07-10 21:25:48 +00:00
|
|
|
if {$status eq {ready}} {
|
2011-11-29 15:29:12 +00:00
|
|
|
if {!$::quiet} {
|
|
|
|
puts "\[$status\]: $data"
|
|
|
|
}
|
2011-07-10 21:25:48 +00:00
|
|
|
signal_idle_client $fd
|
|
|
|
} elseif {$status eq {done}} {
|
2011-07-10 21:57:35 +00:00
|
|
|
set elapsed [expr {[clock seconds]-$::clients_start_time($fd)}]
|
2011-11-29 15:29:12 +00:00
|
|
|
set all_tests_count [llength $::all_tests]
|
|
|
|
set running_tests_count [expr {[llength $::active_clients]-1}]
|
|
|
|
set completed_tests_count [expr {$::next_test-$running_tests_count}]
|
|
|
|
puts "\[$completed_tests_count/$all_tests_count [colorstr yellow $status]\]: $data ($elapsed seconds)"
|
2011-07-10 21:57:35 +00:00
|
|
|
lappend ::clients_time_history $elapsed $data
|
2011-07-10 21:25:48 +00:00
|
|
|
signal_idle_client $fd
|
2020-02-21 16:08:45 +00:00
|
|
|
set ::active_clients_task($fd) "(DONE) $data"
|
2011-07-10 22:09:56 +00:00
|
|
|
} elseif {$status eq {ok}} {
|
2011-11-29 15:29:12 +00:00
|
|
|
if {!$::quiet} {
|
2022-01-05 11:49:01 +00:00
|
|
|
puts "\[[colorstr green $status]\]: $data ($elapsed ms)"
|
2011-11-29 15:29:12 +00:00
|
|
|
}
|
2014-01-31 15:25:13 +00:00
|
|
|
set ::active_clients_task($fd) "(OK) $data"
|
2018-07-30 13:43:21 +00:00
|
|
|
} elseif {$status eq {skip}} {
|
|
|
|
if {!$::quiet} {
|
|
|
|
puts "\[[colorstr yellow $status]\]: $data"
|
|
|
|
}
|
|
|
|
} elseif {$status eq {ignore}} {
|
|
|
|
if {!$::quiet} {
|
|
|
|
puts "\[[colorstr cyan $status]\]: $data"
|
|
|
|
}
|
2011-07-10 22:09:56 +00:00
|
|
|
} elseif {$status eq {err}} {
|
2011-07-11 10:44:55 +00:00
|
|
|
set err "\[[colorstr red $status]\]: $data"
|
|
|
|
puts $err
|
|
|
|
lappend ::failed_tests $err
|
2014-01-31 15:25:13 +00:00
|
|
|
set ::active_clients_task($fd) "(ERR) $data"
|
2020-07-13 13:09:08 +00:00
|
|
|
if {$::stop_on_failure} {
|
|
|
|
puts -nonewline "(Test stopped, press enter to resume the tests)"
|
2018-08-02 16:49:49 +00:00
|
|
|
flush stdout
|
|
|
|
gets stdin
|
|
|
|
}
|
2011-07-10 22:46:25 +00:00
|
|
|
} elseif {$status eq {exception}} {
|
|
|
|
puts "\[[colorstr red $status]\]: $data"
|
2014-11-28 10:05:58 +00:00
|
|
|
kill_clients
|
2014-11-28 10:38:14 +00:00
|
|
|
force_kill_all_servers
|
2011-07-10 22:46:25 +00:00
|
|
|
exit 1
|
2011-07-10 22:53:30 +00:00
|
|
|
} elseif {$status eq {testing}} {
|
2014-01-31 15:25:13 +00:00
|
|
|
set ::active_clients_task($fd) "(IN PROGRESS) $data"
|
2020-02-21 16:08:45 +00:00
|
|
|
} elseif {$status eq {server-spawning}} {
|
|
|
|
set ::active_clients_task($fd) "(SPAWNING SERVER) $data"
|
2014-11-28 10:38:14 +00:00
|
|
|
} elseif {$status eq {server-spawned}} {
|
|
|
|
lappend ::active_servers $data
|
2020-02-21 16:08:45 +00:00
|
|
|
set ::active_clients_task($fd) "(SPAWNED SERVER) pid:$data"
|
|
|
|
} elseif {$status eq {server-killing}} {
|
|
|
|
set ::active_clients_task($fd) "(KILLING SERVER) pid:$data"
|
2014-11-28 10:38:14 +00:00
|
|
|
} elseif {$status eq {server-killed}} {
|
|
|
|
set ::active_servers [lsearch -all -inline -not -exact $::active_servers $data]
|
2020-02-21 16:08:45 +00:00
|
|
|
set ::active_clients_task($fd) "(KILLED SERVER) pid:$data"
|
2020-04-16 08:05:03 +00:00
|
|
|
} elseif {$status eq {run_solo}} {
|
|
|
|
lappend ::run_solo_tests $data
|
2010-10-13 07:26:44 +00:00
|
|
|
} else {
|
2011-11-29 15:29:12 +00:00
|
|
|
if {!$::quiet} {
|
|
|
|
puts "\[$status\]: $data"
|
|
|
|
}
|
2010-10-13 07:26:44 +00:00
|
|
|
}
|
2011-07-10 21:25:48 +00:00
|
|
|
}
|
2010-07-23 11:08:35 +00:00
|
|
|
|
2014-11-28 10:05:58 +00:00
|
|
|
proc show_clients_state {} {
|
|
|
|
# The following loop is only useful for debugging tests that may
|
2020-02-21 16:08:45 +00:00
|
|
|
# enter an infinite loop.
|
2014-11-28 10:05:58 +00:00
|
|
|
foreach x $::active_clients {
|
|
|
|
if {[info exist ::active_clients_task($x)]} {
|
|
|
|
puts "$x => $::active_clients_task($x)"
|
|
|
|
} else {
|
|
|
|
puts "$x => ???"
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
proc kill_clients {} {
|
|
|
|
foreach p $::clients_pids {
|
|
|
|
catch {exec kill $p}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-11-28 10:38:14 +00:00
|
|
|
proc force_kill_all_servers {} {
|
|
|
|
foreach p $::active_servers {
|
2024-04-24 18:54:52 +00:00
|
|
|
puts "Killing still running Valkey server $p"
|
2014-11-28 10:38:14 +00:00
|
|
|
catch {exec kill -9 $p}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-04-16 08:05:03 +00:00
|
|
|
proc lpop {listVar {count 1}} {
|
|
|
|
upvar 1 $listVar l
|
|
|
|
set ele [lindex $l 0]
|
|
|
|
set l [lrange $l 1 end]
|
|
|
|
set ele
|
|
|
|
}
|
|
|
|
|
2020-08-31 08:05:30 +00:00
|
|
|
proc lremove {listVar value} {
|
|
|
|
upvar 1 $listVar var
|
|
|
|
set idx [lsearch -exact $var $value]
|
|
|
|
set var [lreplace $var $idx $idx]
|
|
|
|
}
|
|
|
|
|
2011-07-10 21:25:48 +00:00
|
|
|
# A new client is idle. Remove it from the list of active clients and
|
|
|
|
# if there are still test units to run, launch them.
|
|
|
|
proc signal_idle_client fd {
|
|
|
|
# Remove this fd from the list of active clients.
|
|
|
|
set ::active_clients \
|
|
|
|
[lsearch -all -inline -not -exact $::active_clients $fd]
|
2014-01-31 15:25:13 +00:00
|
|
|
|
2011-07-10 21:25:48 +00:00
|
|
|
# New unit to process?
|
|
|
|
if {$::next_test != [llength $::all_tests]} {
|
2011-11-29 15:29:12 +00:00
|
|
|
if {!$::quiet} {
|
|
|
|
puts [colorstr bold-white "Testing [lindex $::all_tests $::next_test]"]
|
2014-01-31 15:25:13 +00:00
|
|
|
set ::active_clients_task($fd) "ASSIGNED: $fd ([lindex $::all_tests $::next_test])"
|
2011-11-29 15:29:12 +00:00
|
|
|
}
|
2011-07-10 21:57:35 +00:00
|
|
|
set ::clients_start_time($fd) [clock seconds]
|
2011-07-10 21:25:48 +00:00
|
|
|
send_data_packet $fd run [lindex $::all_tests $::next_test]
|
|
|
|
lappend ::active_clients $fd
|
|
|
|
incr ::next_test
|
2018-08-02 17:07:17 +00:00
|
|
|
if {$::loop && $::next_test == [llength $::all_tests]} {
|
|
|
|
set ::next_test 0
|
Attempt to solve MacOS CI issues in GH Actions (#12013)
The MacOS CI in github actions often hangs without any logs. GH argues that
it's due to resource utilization, either running out of disk space, memory, or CPU
starvation, and thus the runner is terminated.
This PR contains multiple attempts to resolve this:
1. introducing pause_process instead of SIGSTOP, which waits for the process
to stop before resuming the test, possibly resolving race conditions in some tests,
this was a suspect since there was one test that could result in an infinite loop in that
case, in practice this didn't help, but still a good idea to keep.
2. disable the `save` config in many tests that don't need it, specifically ones that use
heavy writes and could create large files.
3. change the `populate` proc to use short pipeline rather than an infinite one.
4. use `--clients 1` in the macos CI so that we don't risk running multiple resource
demanding tests in parallel.
5. enable `--verbose` to be repeated to elevate verbosity and print more info to stdout
when a test or a server starts.
2023-04-12 06:19:21 +00:00
|
|
|
incr ::loop -1
|
2018-08-02 17:07:17 +00:00
|
|
|
}
|
2020-04-16 08:05:03 +00:00
|
|
|
} elseif {[llength $::run_solo_tests] != 0 && [llength $::active_clients] == 0} {
|
|
|
|
if {!$::quiet} {
|
|
|
|
puts [colorstr bold-white "Testing solo test"]
|
|
|
|
set ::active_clients_task($fd) "ASSIGNED: $fd solo test"
|
|
|
|
}
|
|
|
|
set ::clients_start_time($fd) [clock seconds]
|
|
|
|
send_data_packet $fd run_code [lpop ::run_solo_tests]
|
|
|
|
lappend ::active_clients $fd
|
2010-10-13 07:26:44 +00:00
|
|
|
} else {
|
2011-07-10 21:25:48 +00:00
|
|
|
lappend ::idle_clients $fd
|
2020-02-21 16:08:45 +00:00
|
|
|
set ::active_clients_task($fd) "SLEEPING, no more units to assign"
|
2011-07-10 21:25:48 +00:00
|
|
|
if {[llength $::active_clients] == 0} {
|
|
|
|
the_end
|
2010-12-10 15:13:21 +00:00
|
|
|
}
|
2010-10-13 07:26:44 +00:00
|
|
|
}
|
2011-07-10 21:25:48 +00:00
|
|
|
}
|
2010-12-10 15:13:21 +00:00
|
|
|
|
2014-01-17 04:02:38 +00:00
|
|
|
# The the_end function gets called when all the test units were already
|
2011-07-10 21:25:48 +00:00
|
|
|
# executed, so the test finished.
|
|
|
|
proc the_end {} {
|
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 10:43:38 +00:00
|
|
|
# TODO: print the status, exit with the right exit code.
|
2011-07-11 10:44:55 +00:00
|
|
|
puts "\n The End\n"
|
2011-07-10 21:57:35 +00:00
|
|
|
puts "Execution time of different units:"
|
|
|
|
foreach {time name} $::clients_time_history {
|
|
|
|
puts " $time seconds - $name"
|
|
|
|
}
|
2011-07-11 10:44:55 +00:00
|
|
|
if {[llength $::failed_tests]} {
|
2011-07-11 10:56:00 +00:00
|
|
|
puts "\n[colorstr bold-red {!!! WARNING}] The following tests failed:\n"
|
2011-07-11 10:44:55 +00:00
|
|
|
foreach failed $::failed_tests {
|
|
|
|
puts "*** $failed"
|
|
|
|
}
|
2020-05-05 11:18:53 +00:00
|
|
|
if {!$::dont_clean} cleanup
|
2010-07-23 11:08:35 +00:00
|
|
|
exit 1
|
2011-07-11 10:44:55 +00:00
|
|
|
} else {
|
|
|
|
puts "\n[colorstr bold-white {\o/}] [colorstr bold-green {All tests passed without errors!}]\n"
|
2020-05-05 11:18:53 +00:00
|
|
|
if {!$::dont_clean} cleanup
|
2011-07-11 10:44:55 +00:00
|
|
|
exit 0
|
2010-05-14 15:31:11 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-07-10 21:25:48 +00:00
|
|
|
# The client is not even driven (the test server is instead) as we just need
|
|
|
|
# to read the command, execute, reply... all this in a loop.
|
|
|
|
proc test_client_main server_port {
|
|
|
|
set ::test_server_fd [socket localhost $server_port]
|
2014-01-31 15:25:13 +00:00
|
|
|
fconfigure $::test_server_fd -encoding binary
|
2011-07-10 21:25:48 +00:00
|
|
|
send_data_packet $::test_server_fd ready [pid]
|
|
|
|
while 1 {
|
|
|
|
set bytes [gets $::test_server_fd]
|
|
|
|
set payload [read $::test_server_fd $bytes]
|
|
|
|
foreach {cmd data} $payload break
|
|
|
|
if {$cmd eq {run}} {
|
2020-04-17 08:51:12 +00:00
|
|
|
execute_test_file $data
|
2020-04-16 08:05:03 +00:00
|
|
|
} elseif {$cmd eq {run_code}} {
|
2020-11-04 15:50:31 +00:00
|
|
|
foreach {name filename code} $data break
|
|
|
|
execute_test_code $name $filename $code
|
2011-07-10 21:25:48 +00:00
|
|
|
} else {
|
|
|
|
error "Unknown test client command: $cmd"
|
2010-12-10 15:13:21 +00:00
|
|
|
}
|
2010-05-14 15:31:11 +00:00
|
|
|
}
|
2011-07-10 21:25:48 +00:00
|
|
|
}
|
2011-07-06 13:22:00 +00:00
|
|
|
|
2022-01-05 11:49:01 +00:00
|
|
|
proc send_data_packet {fd status data {elapsed 0}} {
|
|
|
|
set payload [list $status $data $elapsed]
|
2011-07-10 21:25:48 +00:00
|
|
|
puts $fd [string length $payload]
|
|
|
|
puts -nonewline $fd $payload
|
|
|
|
flush $fd
|
2010-05-14 15:31:11 +00:00
|
|
|
}
|
|
|
|
|
2011-07-11 11:03:22 +00:00
|
|
|
proc print_help_screen {} {
|
|
|
|
puts [join {
|
|
|
|
"--valgrind Run the test over valgrind."
|
2020-08-31 08:24:17 +00:00
|
|
|
"--durable suppress test crashes and keep running"
|
2015-09-23 08:34:00 +00:00
|
|
|
"--stack-logging Enable OSX leaks/malloc stack logging."
|
2011-07-11 11:03:22 +00:00
|
|
|
"--accurate Run slow randomized tests for more iterations."
|
2011-11-29 15:29:12 +00:00
|
|
|
"--quiet Don't show individual tests."
|
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 10:43:38 +00:00
|
|
|
"--single <unit> Just execute the specified unit (see next option). This option can be repeated."
|
|
|
|
"--verbose Increases verbosity."
|
2011-07-11 11:03:22 +00:00
|
|
|
"--list-tests List all the available test units."
|
2022-05-25 15:25:38 +00:00
|
|
|
"--only <test> Just execute the specified test by test name or tests that match <test> regexp (if <test> starts with '/'). This option can be repeated."
|
2018-07-31 15:28:30 +00:00
|
|
|
"--skip-till <unit> Skip all units until (and including) the specified one."
|
2020-08-31 08:05:30 +00:00
|
|
|
"--skipunit <unit> Skip one unit."
|
2014-11-28 10:38:14 +00:00
|
|
|
"--clients <num> Number of test clients (default 16)."
|
2021-11-10 17:38:58 +00:00
|
|
|
"--timeout <sec> Test timeout in seconds (default 20 min)."
|
2011-07-11 11:03:22 +00:00
|
|
|
"--force-failure Force the execution of a test that always fails."
|
2018-08-02 17:07:17 +00:00
|
|
|
"--config <k> <v> Extra config file argument."
|
2022-07-17 05:47:35 +00:00
|
|
|
"--skipfile <file> Name of a file containing test names or regexp patterns (if <test> starts with '/') that should be skipped (one per line). This option can be repeated."
|
2022-05-25 15:25:38 +00:00
|
|
|
"--skiptest <test> Test name or regexp pattern (if <test> starts with '/') to skip. This option can be repeated."
|
2021-06-09 12:13:24 +00:00
|
|
|
"--tags <tags> Run only tests having specified tags or not having '-' prefixed tags."
|
2024-04-18 13:57:17 +00:00
|
|
|
"--dont-clean Don't delete valkey log files after the run."
|
|
|
|
"--dont-pre-clean Don't delete existing valkey log files before the run."
|
2020-10-22 08:10:53 +00:00
|
|
|
"--no-latency Skip latency measurements and validation by some tests."
|
2018-08-02 17:07:17 +00:00
|
|
|
"--stop Blocks once the first test fails."
|
|
|
|
"--loop Execute the specified set of tests forever."
|
Attempt to solve MacOS CI issues in GH Actions (#12013)
The MacOS CI in github actions often hangs without any logs. GH argues that
it's due to resource utilization, either running out of disk space, memory, or CPU
starvation, and thus the runner is terminated.
This PR contains multiple attempts to resolve this:
1. introducing pause_process instead of SIGSTOP, which waits for the process
to stop before resuming the test, possibly resolving race conditions in some tests,
this was a suspect since there was one test that could result in an infinite loop in that
case, in practice this didn't help, but still a good idea to keep.
2. disable the `save` config in many tests that don't need it, specifically ones that use
heavy writes and could create large files.
3. change the `populate` proc to use short pipeline rather than an infinite one.
4. use `--clients 1` in the macos CI so that we don't risk running multiple resource
demanding tests in parallel.
5. enable `--verbose` to be repeated to elevate verbosity and print more info to stdout
when a test or a server starts.
2023-04-12 06:19:21 +00:00
|
|
|
"--loops <count> Execute the specified set of tests several times."
|
2018-08-02 17:07:17 +00:00
|
|
|
"--wait-server Wait after server is started (so that you can attach a debugger)."
|
2021-02-07 10:37:24 +00:00
|
|
|
"--dump-logs Dump server log on test failure."
|
2019-09-12 07:56:54 +00:00
|
|
|
"--tls Run tests in TLS mode."
|
2024-04-24 18:54:52 +00:00
|
|
|
"--tls-module Run tests in TLS mode with Valkey module."
|
2020-05-26 08:00:48 +00:00
|
|
|
"--host <addr> Run tests against an external host."
|
|
|
|
"--port <port> TCP port to use against external host."
|
2024-04-18 13:57:17 +00:00
|
|
|
"--baseport <port> Initial port number for spawned valkey servers."
|
|
|
|
"--portcount <num> Port range for spawned valkey servers."
|
2021-06-09 12:13:24 +00:00
|
|
|
"--singledb Use a single database, avoid SELECT."
|
|
|
|
"--cluster-mode Run tests in cluster protocol compatible mode."
|
|
|
|
"--ignore-encoding Don't validate object encoding."
|
|
|
|
"--ignore-digest Don't use debug digest validations."
|
2021-11-03 18:47:18 +00:00
|
|
|
"--large-memory Run tests using over 100mb."
|
2011-07-11 11:03:22 +00:00
|
|
|
"--help Print this help screen."
|
|
|
|
} "\n"]
|
|
|
|
}
|
|
|
|
|
2010-06-02 21:04:22 +00:00
|
|
|
# parse arguments
|
|
|
|
for {set j 0} {$j < [llength $argv]} {incr j} {
|
|
|
|
set opt [lindex $argv $j]
|
|
|
|
set arg [lindex $argv [expr $j+1]]
|
|
|
|
if {$opt eq {--tags}} {
|
|
|
|
foreach tag $arg {
|
|
|
|
if {[string index $tag 0] eq "-"} {
|
|
|
|
lappend ::denytags [string range $tag 1 end]
|
|
|
|
} else {
|
|
|
|
lappend ::allowtags $tag
|
|
|
|
}
|
|
|
|
}
|
|
|
|
incr j
|
2018-07-30 13:43:21 +00:00
|
|
|
} elseif {$opt eq {--config}} {
|
|
|
|
set arg2 [lindex $argv [expr $j+2]]
|
|
|
|
lappend ::global_overrides $arg
|
|
|
|
lappend ::global_overrides $arg2
|
2018-07-31 15:28:30 +00:00
|
|
|
incr j 2
|
Add reply_schema to command json files (internal for now) (#10273)
Work in progress towards implementing a reply schema as part of COMMAND DOCS, see #9845
Since ironing the details of the reply schema of each and every command can take a long time, we
would like to merge this PR when the infrastructure is ready, and let this mature in the unstable branch.
Meanwhile the changes of this PR are internal, they are part of the repo, but do not affect the produced build.
### Background
In #9656 we add a lot of information about Redis commands, but we are missing information about the replies
### Motivation
1. Documentation. This is the primary goal.
2. It should be possible, based on the output of COMMAND, to be able to generate client code in typed
languages. In order to do that, we need Redis to tell us, in detail, what each reply looks like.
3. We would like to build a fuzzer that verifies the reply structure (for now we use the existing
testsuite, see the "Testing" section)
### Schema
The idea is to supply some sort of schema for the various replies of each command.
The schema will describe the conceptual structure of the reply (for generated clients), as defined in RESP3.
Note that the reply structure itself may change, depending on the arguments (e.g. `XINFO STREAM`, with
and without the `FULL` modifier)
We decided to use the standard json-schema (see https://json-schema.org/) as the reply-schema.
Example for `BZPOPMIN`:
```
"reply_schema": {
"oneOf": [
{
"description": "Timeout reached and no elements were popped.",
"type": "null"
},
{
"description": "The keyname, popped member, and its score.",
"type": "array",
"minItems": 3,
"maxItems": 3,
"items": [
{
"description": "Keyname",
"type": "string"
},
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
]
}
```
#### Notes
1. It is ok that some commands' reply structure depends on the arguments and it's the caller's responsibility
to know which is the relevant one. this comes after looking at other request-reply systems like OpenAPI,
where the reply schema can also be oneOf and the caller is responsible to know which schema is the relevant one.
2. The reply schemas will describe RESP3 replies only. even though RESP3 is structured, we want to use reply
schema for documentation (and possibly to create a fuzzer that validates the replies)
3. For documentation, the description field will include an explanation of the scenario in which the reply is sent,
including any relation to arguments. for example, for `ZRANGE`'s two schemas we will need to state that one
is with `WITHSCORES` and the other is without.
4. For documentation, there will be another optional field "notes" in which we will add a short description of
the representation in RESP2, in case it's not trivial (RESP3's `ZRANGE`'s nested array vs. RESP2's flat
array, for example)
Given the above:
1. We can generate the "return" section of all commands in [redis-doc](https://redis.io/commands/)
(given that "description" and "notes" are comprehensive enough)
2. We can generate a client in a strongly typed language (but the return type could be a conceptual
`union` and the caller needs to know which schema is relevant). see the section below for RESP2 support.
3. We can create a fuzzer for RESP3.
### Limitations (because we are using the standard json-schema)
The problem is that Redis' replies are more diverse than what the json format allows. This means that,
when we convert the reply to a json (in order to validate the schema against it), we lose information (see
the "Testing" section below).
The other option would have been to extend the standard json-schema (and json format) to include stuff
like sets, bulk-strings, error-string, etc. but that would mean also extending the schema-validator - and that
seemed like too much work, so we decided to compromise.
Examples:
1. We cannot tell the difference between an "array" and a "set"
2. We cannot tell the difference between simple-string and bulk-string
3. we cannot verify true uniqueness of items in commands like ZRANGE: json-schema doesn't cover the
case of two identical members with different scores (e.g. `[["m1",6],["m1",7]]`) because `uniqueItems`
compares (member,score) tuples and not just the member name.
### Testing
This commit includes some changes inside Redis in order to verify the schemas (existing and future ones)
are indeed correct (i.e. describe the actual response of Redis).
To do that, we added a debugging feature to Redis that causes it to produce a log of all the commands
it executed and their replies.
For that, Redis needs to be compiled with `-DLOG_REQ_RES` and run with
`--reg-res-logfile <file> --client-default-resp 3` (the testsuite already does that if you run it with
`--log-req-res --force-resp3`)
You should run the testsuite with the above args (and `--dont-clean`) in order to make Redis generate
`.reqres` files (same dir as the `stdout` files) which contain request-response pairs.
These files are later on processed by `./utils/req-res-log-validator.py` which does:
1. Goes over req-res files, generated by redis-servers, spawned by the testsuite (see logreqres.c)
2. For each request-response pair, it validates the response against the request's reply_schema
(obtained from the extended COMMAND DOCS)
5. In order to get good coverage of the Redis commands, and all their different replies, we chose to use
the existing redis test suite, rather than attempt to write a fuzzer.
#### Notes about RESP2
1. We will not be able to use the testing tool to verify RESP2 replies (we are ok with that, it's time to
accept RESP3 as the future RESP)
2. Since the majority of the test suite is using RESP2, and we want the server to reply with RESP3
so that we can validate it, we will need to know how to convert the actual reply to the one expected.
- number and boolean are always strings in RESP2 so the conversion is easy
- objects (maps) are always a flat array in RESP2
- others (nested array in RESP3's `ZRANGE` and others) will need some special per-command
handling (so the client will not be totally auto-generated)
Example for ZRANGE:
```
"reply_schema": {
"anyOf": [
{
"description": "A list of member elements",
"type": "array",
"uniqueItems": true,
"items": {
"type": "string"
}
},
{
"description": "Members and their scores. Returned in case `WITHSCORES` was used.",
"notes": "In RESP2 this is returned as a flat array",
"type": "array",
"uniqueItems": true,
"items": {
"type": "array",
"minItems": 2,
"maxItems": 2,
"items": [
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
}
]
}
```
### Other changes
1. Some tests that behave differently depending on the RESP are now being tested for both RESP,
regardless of the special log-req-res mode ("Pub/Sub PING" for example)
2. Update the history field of CLIENT LIST
3. Added basic tests for commands that were not covered at all by the testsuite
### TODO
- [x] (maybe a different PR) add a "condition" field to anyOf/oneOf schemas that refers to args. e.g.
when `SET` return NULL, the condition is `arguments.get||arguments.condition`, for `OK` the condition
is `!arguments.get`, and for `string` the condition is `arguments.get` - https://github.com/redis/redis/issues/11896
- [x] (maybe a different PR) also run `runtest-cluster` in the req-res logging mode
- [x] add the new tests to GH actions (i.e. compile with `-DLOG_REQ_RES`, run the tests, and run the validator)
- [x] (maybe a different PR) figure out a way to warn about (sub)schemas that are uncovered by the output
of the tests - https://github.com/redis/redis/issues/11897
- [x] (probably a separate PR) add all missing schemas
- [x] check why "SDOWN is triggered by misconfigured instance replying with errors" fails with --log-req-res
- [x] move the response transformers to their own file (run both regular, cluster, and sentinel tests - need to
fight with the tcl including mechanism a bit)
- [x] issue: module API - https://github.com/redis/redis/issues/11898
- [x] (probably a separate PR): improve schemas: add `required` to `object`s - https://github.com/redis/redis/issues/11899
Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com>
Co-authored-by: Hanna Fadida <hanna.fadida@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Shaya Potter <shaya@redislabs.com>
2023-03-11 08:14:16 +00:00
|
|
|
} elseif {$opt eq {--log-req-res}} {
|
|
|
|
set ::log_req_res 1
|
|
|
|
} elseif {$opt eq {--force-resp3}} {
|
|
|
|
set ::force_resp3 1
|
2018-07-30 13:43:21 +00:00
|
|
|
} elseif {$opt eq {--skipfile}} {
|
|
|
|
incr j
|
|
|
|
set fp [open $arg r]
|
|
|
|
set file_data [read $fp]
|
|
|
|
close $fp
|
2022-07-17 05:47:35 +00:00
|
|
|
set ::skiptests [concat $::skiptests [split $file_data "\n"]]
|
2020-08-31 08:05:30 +00:00
|
|
|
} elseif {$opt eq {--skiptest}} {
|
|
|
|
lappend ::skiptests $arg
|
|
|
|
incr j
|
2010-12-10 14:40:48 +00:00
|
|
|
} elseif {$opt eq {--valgrind}} {
|
|
|
|
set ::valgrind 1
|
2015-09-23 08:34:00 +00:00
|
|
|
} elseif {$opt eq {--stack-logging}} {
|
|
|
|
if {[string match {*Darwin*} [exec uname -a]]} {
|
|
|
|
set ::stack_logging 1
|
|
|
|
}
|
2011-11-29 15:29:12 +00:00
|
|
|
} elseif {$opt eq {--quiet}} {
|
|
|
|
set ::quiet 1
|
Build TLS as a loadable module
* Support BUILD_TLS=module to be loaded as a module via config file or
command line. e.g. redis-server --loadmodule redis-tls.so
* Updates to redismodule.h to allow it to be used side by side with
server.h by defining REDISMODULE_CORE_MODULE
* Changes to server.h, redismodule.h and module.c to avoid repeated
type declarations (gcc 4.8 doesn't like these)
* Add a mechanism for non-ABI neutral modules (ones who include
server.h) to refuse loading if they detect not being built together with
redis (release.c)
* Fix wrong signature of RedisModuleDefragFunc, this could break
compilation of a module, but not the ABI
* Move initialization of listeners in server.c to be after loading
the modules
* Config TLS after initialization of listeners
* Init cluster after initialization of listeners
* Add TLS module to CI
* Fix a test suite race conditions:
Now that the listeners are initialized later, it's not sufficient to
wait for the PID message in the log, we need to wait for the "Server
Initialized" message.
* Fix issues with moduleconfigs test as a result from start_server
waiting for "Server Initialized"
* Fix issues with modules/infra test as a result of an additional module
present
Notes about Sentinel:
Sentinel can't really rely on the tls module, since it uses hiredis to
initiate connections and depends on OpenSSL (won't be able to use any
other connection modules for that), so it was decided that when TLS is
built as a module, sentinel does not support TLS at all.
This means that it keeps using redis_tls_ctx and redis_tls_client_ctx directly.
Example code of config in redis-tls.so(may be use in the future):
RedisModuleString *tls_cfg = NULL;
void tlsInfo(RedisModuleInfoCtx *ctx, int for_crash_report) {
UNUSED(for_crash_report);
RedisModule_InfoAddSection(ctx, "");
RedisModule_InfoAddFieldLongLong(ctx, "var", 42);
}
int tlsCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc)
{
if (argc != 2) return RedisModule_WrongArity(ctx);
return RedisModule_ReplyWithString(ctx, argv[1]);
}
RedisModuleString *getStringConfigCommand(const char *name, void *privdata) {
REDISMODULE_NOT_USED(name);
REDISMODULE_NOT_USED(privdata);
return tls_cfg;
}
int setStringConfigCommand(const char *name, RedisModuleString *new, void *privdata, RedisModuleString **err) {
REDISMODULE_NOT_USED(name);
REDISMODULE_NOT_USED(err);
REDISMODULE_NOT_USED(privdata);
if (tls_cfg) RedisModule_FreeString(NULL, tls_cfg);
RedisModule_RetainString(NULL, new);
tls_cfg = new;
return REDISMODULE_OK;
}
int RedisModule_OnLoad(void *ctx, RedisModuleString **argv, int argc)
{
....
if (RedisModule_CreateCommand(ctx,"tls",tlsCommand,"",0,0,0) == REDISMODULE_ERR)
return REDISMODULE_ERR;
if (RedisModule_RegisterStringConfig(ctx, "cfg", "", REDISMODULE_CONFIG_DEFAULT, getStringConfigCommand, setStringConfigCommand, NULL, NULL) == REDISMODULE_ERR)
return REDISMODULE_ERR;
if (RedisModule_LoadConfigs(ctx) == REDISMODULE_ERR) {
if (tls_cfg) {
RedisModule_FreeString(ctx, tls_cfg);
tls_cfg = NULL;
}
return REDISMODULE_ERR;
}
...
}
Co-authored-by: zhenwei pi <pizhenwei@bytedance.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
2022-08-22 07:53:56 +00:00
|
|
|
} elseif {$opt eq {--tls} || $opt eq {--tls-module}} {
|
2019-09-12 07:56:54 +00:00
|
|
|
package require tls 1.6
|
|
|
|
set ::tls 1
|
|
|
|
::tls::init \
|
|
|
|
-cafile "$::tlsdir/ca.crt" \
|
2020-12-11 16:31:40 +00:00
|
|
|
-certfile "$::tlsdir/client.crt" \
|
|
|
|
-keyfile "$::tlsdir/client.key"
|
Build TLS as a loadable module
* Support BUILD_TLS=module to be loaded as a module via config file or
command line. e.g. redis-server --loadmodule redis-tls.so
* Updates to redismodule.h to allow it to be used side by side with
server.h by defining REDISMODULE_CORE_MODULE
* Changes to server.h, redismodule.h and module.c to avoid repeated
type declarations (gcc 4.8 doesn't like these)
* Add a mechanism for non-ABI neutral modules (ones who include
server.h) to refuse loading if they detect not being built together with
redis (release.c)
* Fix wrong signature of RedisModuleDefragFunc, this could break
compilation of a module, but not the ABI
* Move initialization of listeners in server.c to be after loading
the modules
* Config TLS after initialization of listeners
* Init cluster after initialization of listeners
* Add TLS module to CI
* Fix a test suite race conditions:
Now that the listeners are initialized later, it's not sufficient to
wait for the PID message in the log, we need to wait for the "Server
Initialized" message.
* Fix issues with moduleconfigs test as a result from start_server
waiting for "Server Initialized"
* Fix issues with modules/infra test as a result of an additional module
present
Notes about Sentinel:
Sentinel can't really rely on the tls module, since it uses hiredis to
initiate connections and depends on OpenSSL (won't be able to use any
other connection modules for that), so it was decided that when TLS is
built as a module, sentinel does not support TLS at all.
This means that it keeps using redis_tls_ctx and redis_tls_client_ctx directly.
Example code of config in redis-tls.so(may be use in the future):
RedisModuleString *tls_cfg = NULL;
void tlsInfo(RedisModuleInfoCtx *ctx, int for_crash_report) {
UNUSED(for_crash_report);
RedisModule_InfoAddSection(ctx, "");
RedisModule_InfoAddFieldLongLong(ctx, "var", 42);
}
int tlsCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc)
{
if (argc != 2) return RedisModule_WrongArity(ctx);
return RedisModule_ReplyWithString(ctx, argv[1]);
}
RedisModuleString *getStringConfigCommand(const char *name, void *privdata) {
REDISMODULE_NOT_USED(name);
REDISMODULE_NOT_USED(privdata);
return tls_cfg;
}
int setStringConfigCommand(const char *name, RedisModuleString *new, void *privdata, RedisModuleString **err) {
REDISMODULE_NOT_USED(name);
REDISMODULE_NOT_USED(err);
REDISMODULE_NOT_USED(privdata);
if (tls_cfg) RedisModule_FreeString(NULL, tls_cfg);
RedisModule_RetainString(NULL, new);
tls_cfg = new;
return REDISMODULE_OK;
}
int RedisModule_OnLoad(void *ctx, RedisModuleString **argv, int argc)
{
....
if (RedisModule_CreateCommand(ctx,"tls",tlsCommand,"",0,0,0) == REDISMODULE_ERR)
return REDISMODULE_ERR;
if (RedisModule_RegisterStringConfig(ctx, "cfg", "", REDISMODULE_CONFIG_DEFAULT, getStringConfigCommand, setStringConfigCommand, NULL, NULL) == REDISMODULE_ERR)
return REDISMODULE_ERR;
if (RedisModule_LoadConfigs(ctx) == REDISMODULE_ERR) {
if (tls_cfg) {
RedisModule_FreeString(ctx, tls_cfg);
tls_cfg = NULL;
}
return REDISMODULE_ERR;
}
...
}
Co-authored-by: zhenwei pi <pizhenwei@bytedance.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
2022-08-22 07:53:56 +00:00
|
|
|
if {$opt eq {--tls-module}} {
|
|
|
|
set ::tls_module 1
|
|
|
|
}
|
2010-06-14 08:19:45 +00:00
|
|
|
} elseif {$opt eq {--host}} {
|
|
|
|
set ::external 1
|
|
|
|
set ::host $arg
|
|
|
|
incr j
|
|
|
|
} elseif {$opt eq {--port}} {
|
|
|
|
set ::port $arg
|
|
|
|
incr j
|
2020-05-26 08:00:48 +00:00
|
|
|
} elseif {$opt eq {--baseport}} {
|
|
|
|
set ::baseport $arg
|
|
|
|
incr j
|
|
|
|
} elseif {$opt eq {--portcount}} {
|
|
|
|
set ::portcount $arg
|
|
|
|
incr j
|
2011-07-11 09:59:55 +00:00
|
|
|
} elseif {$opt eq {--accurate}} {
|
|
|
|
set ::accurate 1
|
2011-07-11 10:44:55 +00:00
|
|
|
} elseif {$opt eq {--force-failure}} {
|
|
|
|
set ::force_failure 1
|
2011-07-11 09:59:55 +00:00
|
|
|
} elseif {$opt eq {--single}} {
|
2018-07-30 13:43:21 +00:00
|
|
|
lappend ::single_tests $arg
|
|
|
|
incr j
|
|
|
|
} elseif {$opt eq {--only}} {
|
|
|
|
lappend ::only_tests $arg
|
|
|
|
incr j
|
2020-08-31 08:05:30 +00:00
|
|
|
} elseif {$opt eq {--skipunit}} {
|
|
|
|
lappend ::skipunits $arg
|
|
|
|
incr j
|
2019-05-10 08:27:25 +00:00
|
|
|
} elseif {$opt eq {--skip-till}} {
|
2018-07-30 13:43:21 +00:00
|
|
|
set ::skip_till $arg
|
2011-07-11 09:59:55 +00:00
|
|
|
incr j
|
|
|
|
} elseif {$opt eq {--list-tests}} {
|
|
|
|
foreach t $::all_tests {
|
|
|
|
puts $t
|
|
|
|
}
|
|
|
|
exit 0
|
2018-02-18 15:36:21 +00:00
|
|
|
} elseif {$opt eq {--verbose}} {
|
Attempt to solve MacOS CI issues in GH Actions (#12013)
The MacOS CI in github actions often hangs without any logs. GH argues that
it's due to resource utilization, either running out of disk space, memory, or CPU
starvation, and thus the runner is terminated.
This PR contains multiple attempts to resolve this:
1. introducing pause_process instead of SIGSTOP, which waits for the process
to stop before resuming the test, possibly resolving race conditions in some tests,
this was a suspect since there was one test that could result in an infinite loop in that
case, in practice this didn't help, but still a good idea to keep.
2. disable the `save` config in many tests that don't need it, specifically ones that use
heavy writes and could create large files.
3. change the `populate` proc to use short pipeline rather than an infinite one.
4. use `--clients 1` in the macos CI so that we don't risk running multiple resource
demanding tests in parallel.
5. enable `--verbose` to be repeated to elevate verbosity and print more info to stdout
when a test or a server starts.
2023-04-12 06:19:21 +00:00
|
|
|
incr ::verbose
|
2011-07-10 21:25:48 +00:00
|
|
|
} elseif {$opt eq {--client}} {
|
|
|
|
set ::client 1
|
|
|
|
set ::test_server_port $arg
|
|
|
|
incr j
|
2012-04-03 11:32:49 +00:00
|
|
|
} elseif {$opt eq {--clients}} {
|
|
|
|
set ::numclients $arg
|
|
|
|
incr j
|
2020-08-31 08:24:17 +00:00
|
|
|
} elseif {$opt eq {--durable}} {
|
|
|
|
set ::durable 1
|
2018-06-26 11:14:04 +00:00
|
|
|
} elseif {$opt eq {--dont-clean}} {
|
|
|
|
set ::dont_clean 1
|
Add reply_schema to command json files (internal for now) (#10273)
Work in progress towards implementing a reply schema as part of COMMAND DOCS, see #9845
Since ironing the details of the reply schema of each and every command can take a long time, we
would like to merge this PR when the infrastructure is ready, and let this mature in the unstable branch.
Meanwhile the changes of this PR are internal, they are part of the repo, but do not affect the produced build.
### Background
In #9656 we add a lot of information about Redis commands, but we are missing information about the replies
### Motivation
1. Documentation. This is the primary goal.
2. It should be possible, based on the output of COMMAND, to be able to generate client code in typed
languages. In order to do that, we need Redis to tell us, in detail, what each reply looks like.
3. We would like to build a fuzzer that verifies the reply structure (for now we use the existing
testsuite, see the "Testing" section)
### Schema
The idea is to supply some sort of schema for the various replies of each command.
The schema will describe the conceptual structure of the reply (for generated clients), as defined in RESP3.
Note that the reply structure itself may change, depending on the arguments (e.g. `XINFO STREAM`, with
and without the `FULL` modifier)
We decided to use the standard json-schema (see https://json-schema.org/) as the reply-schema.
Example for `BZPOPMIN`:
```
"reply_schema": {
"oneOf": [
{
"description": "Timeout reached and no elements were popped.",
"type": "null"
},
{
"description": "The keyname, popped member, and its score.",
"type": "array",
"minItems": 3,
"maxItems": 3,
"items": [
{
"description": "Keyname",
"type": "string"
},
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
]
}
```
#### Notes
1. It is ok that some commands' reply structure depends on the arguments and it's the caller's responsibility
to know which is the relevant one. this comes after looking at other request-reply systems like OpenAPI,
where the reply schema can also be oneOf and the caller is responsible to know which schema is the relevant one.
2. The reply schemas will describe RESP3 replies only. even though RESP3 is structured, we want to use reply
schema for documentation (and possibly to create a fuzzer that validates the replies)
3. For documentation, the description field will include an explanation of the scenario in which the reply is sent,
including any relation to arguments. for example, for `ZRANGE`'s two schemas we will need to state that one
is with `WITHSCORES` and the other is without.
4. For documentation, there will be another optional field "notes" in which we will add a short description of
the representation in RESP2, in case it's not trivial (RESP3's `ZRANGE`'s nested array vs. RESP2's flat
array, for example)
Given the above:
1. We can generate the "return" section of all commands in [redis-doc](https://redis.io/commands/)
(given that "description" and "notes" are comprehensive enough)
2. We can generate a client in a strongly typed language (but the return type could be a conceptual
`union` and the caller needs to know which schema is relevant). see the section below for RESP2 support.
3. We can create a fuzzer for RESP3.
### Limitations (because we are using the standard json-schema)
The problem is that Redis' replies are more diverse than what the json format allows. This means that,
when we convert the reply to a json (in order to validate the schema against it), we lose information (see
the "Testing" section below).
The other option would have been to extend the standard json-schema (and json format) to include stuff
like sets, bulk-strings, error-string, etc. but that would mean also extending the schema-validator - and that
seemed like too much work, so we decided to compromise.
Examples:
1. We cannot tell the difference between an "array" and a "set"
2. We cannot tell the difference between simple-string and bulk-string
3. we cannot verify true uniqueness of items in commands like ZRANGE: json-schema doesn't cover the
case of two identical members with different scores (e.g. `[["m1",6],["m1",7]]`) because `uniqueItems`
compares (member,score) tuples and not just the member name.
### Testing
This commit includes some changes inside Redis in order to verify the schemas (existing and future ones)
are indeed correct (i.e. describe the actual response of Redis).
To do that, we added a debugging feature to Redis that causes it to produce a log of all the commands
it executed and their replies.
For that, Redis needs to be compiled with `-DLOG_REQ_RES` and run with
`--reg-res-logfile <file> --client-default-resp 3` (the testsuite already does that if you run it with
`--log-req-res --force-resp3`)
You should run the testsuite with the above args (and `--dont-clean`) in order to make Redis generate
`.reqres` files (same dir as the `stdout` files) which contain request-response pairs.
These files are later on processed by `./utils/req-res-log-validator.py` which does:
1. Goes over req-res files, generated by redis-servers, spawned by the testsuite (see logreqres.c)
2. For each request-response pair, it validates the response against the request's reply_schema
(obtained from the extended COMMAND DOCS)
5. In order to get good coverage of the Redis commands, and all their different replies, we chose to use
the existing redis test suite, rather than attempt to write a fuzzer.
#### Notes about RESP2
1. We will not be able to use the testing tool to verify RESP2 replies (we are ok with that, it's time to
accept RESP3 as the future RESP)
2. Since the majority of the test suite is using RESP2, and we want the server to reply with RESP3
so that we can validate it, we will need to know how to convert the actual reply to the one expected.
- number and boolean are always strings in RESP2 so the conversion is easy
- objects (maps) are always a flat array in RESP2
- others (nested array in RESP3's `ZRANGE` and others) will need some special per-command
handling (so the client will not be totally auto-generated)
Example for ZRANGE:
```
"reply_schema": {
"anyOf": [
{
"description": "A list of member elements",
"type": "array",
"uniqueItems": true,
"items": {
"type": "string"
}
},
{
"description": "Members and their scores. Returned in case `WITHSCORES` was used.",
"notes": "In RESP2 this is returned as a flat array",
"type": "array",
"uniqueItems": true,
"items": {
"type": "array",
"minItems": 2,
"maxItems": 2,
"items": [
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
}
]
}
```
### Other changes
1. Some tests that behave differently depending on the RESP are now being tested for both RESP,
regardless of the special log-req-res mode ("Pub/Sub PING" for example)
2. Update the history field of CLIENT LIST
3. Added basic tests for commands that were not covered at all by the testsuite
### TODO
- [x] (maybe a different PR) add a "condition" field to anyOf/oneOf schemas that refers to args. e.g.
when `SET` return NULL, the condition is `arguments.get||arguments.condition`, for `OK` the condition
is `!arguments.get`, and for `string` the condition is `arguments.get` - https://github.com/redis/redis/issues/11896
- [x] (maybe a different PR) also run `runtest-cluster` in the req-res logging mode
- [x] add the new tests to GH actions (i.e. compile with `-DLOG_REQ_RES`, run the tests, and run the validator)
- [x] (maybe a different PR) figure out a way to warn about (sub)schemas that are uncovered by the output
of the tests - https://github.com/redis/redis/issues/11897
- [x] (probably a separate PR) add all missing schemas
- [x] check why "SDOWN is triggered by misconfigured instance replying with errors" fails with --log-req-res
- [x] move the response transformers to their own file (run both regular, cluster, and sentinel tests - need to
fight with the tcl including mechanism a bit)
- [x] issue: module API - https://github.com/redis/redis/issues/11898
- [x] (probably a separate PR): improve schemas: add `required` to `object`s - https://github.com/redis/redis/issues/11899
Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com>
Co-authored-by: Hanna Fadida <hanna.fadida@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Shaya Potter <shaya@redislabs.com>
2023-03-11 08:14:16 +00:00
|
|
|
} elseif {$opt eq {--dont-pre-clean}} {
|
|
|
|
set ::dont_pre_clean 1
|
2020-10-22 08:10:53 +00:00
|
|
|
} elseif {$opt eq {--no-latency}} {
|
|
|
|
set ::no_latency 1
|
2018-06-26 11:14:04 +00:00
|
|
|
} elseif {$opt eq {--wait-server}} {
|
|
|
|
set ::wait_server 1
|
2021-02-07 10:37:24 +00:00
|
|
|
} elseif {$opt eq {--dump-logs}} {
|
|
|
|
set ::dump_logs 1
|
2018-08-02 16:49:49 +00:00
|
|
|
} elseif {$opt eq {--stop}} {
|
|
|
|
set ::stop_on_failure 1
|
2018-08-02 17:07:17 +00:00
|
|
|
} elseif {$opt eq {--loop}} {
|
Attempt to solve MacOS CI issues in GH Actions (#12013)
The MacOS CI in github actions often hangs without any logs. GH argues that
it's due to resource utilization, either running out of disk space, memory, or CPU
starvation, and thus the runner is terminated.
This PR contains multiple attempts to resolve this:
1. introducing pause_process instead of SIGSTOP, which waits for the process
to stop before resuming the test, possibly resolving race conditions in some tests,
this was a suspect since there was one test that could result in an infinite loop in that
case, in practice this didn't help, but still a good idea to keep.
2. disable the `save` config in many tests that don't need it, specifically ones that use
heavy writes and could create large files.
3. change the `populate` proc to use short pipeline rather than an infinite one.
4. use `--clients 1` in the macos CI so that we don't risk running multiple resource
demanding tests in parallel.
5. enable `--verbose` to be repeated to elevate verbosity and print more info to stdout
when a test or a server starts.
2023-04-12 06:19:21 +00:00
|
|
|
set ::loop 2147483647
|
|
|
|
} elseif {$opt eq {--loops}} {
|
|
|
|
set ::loop $arg
|
|
|
|
incr j
|
2014-11-28 10:38:14 +00:00
|
|
|
} elseif {$opt eq {--timeout}} {
|
|
|
|
set ::timeout $arg
|
|
|
|
incr j
|
2021-06-09 12:13:24 +00:00
|
|
|
} elseif {$opt eq {--singledb}} {
|
|
|
|
set ::singledb 1
|
|
|
|
} elseif {$opt eq {--cluster-mode}} {
|
|
|
|
set ::cluster_mode 1
|
|
|
|
set ::singledb 1
|
2021-11-03 18:47:18 +00:00
|
|
|
} elseif {$opt eq {--large-memory}} {
|
|
|
|
set ::large_memory 1
|
2021-06-09 12:13:24 +00:00
|
|
|
} elseif {$opt eq {--ignore-encoding}} {
|
|
|
|
set ::ignoreencoding 1
|
|
|
|
} elseif {$opt eq {--ignore-digest}} {
|
|
|
|
set ::ignoredigest 1
|
2011-07-11 09:59:55 +00:00
|
|
|
} elseif {$opt eq {--help}} {
|
2011-07-11 11:03:22 +00:00
|
|
|
print_help_screen
|
2011-07-11 09:59:55 +00:00
|
|
|
exit 0
|
2010-06-02 21:04:22 +00:00
|
|
|
} else {
|
|
|
|
puts "Wrong argument: $opt"
|
|
|
|
exit 1
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-08-31 08:05:30 +00:00
|
|
|
set filtered_tests {}
|
|
|
|
|
|
|
|
# Set the filtered tests to be the short list (single_tests) if exists.
|
|
|
|
# Otherwise, we start filtering all_tests
|
|
|
|
if {[llength $::single_tests] > 0} {
|
|
|
|
set filtered_tests $::single_tests
|
|
|
|
} else {
|
|
|
|
set filtered_tests $::all_tests
|
|
|
|
}
|
|
|
|
|
|
|
|
# If --skip-till option was given, we populate the list of single tests
|
2018-07-31 15:28:30 +00:00
|
|
|
# to run with everything *after* the specified unit.
|
2018-07-30 13:43:21 +00:00
|
|
|
if {$::skip_till != ""} {
|
|
|
|
set skipping 1
|
|
|
|
foreach t $::all_tests {
|
2020-08-31 08:05:30 +00:00
|
|
|
if {$skipping == 1} {
|
|
|
|
lremove filtered_tests $t
|
2018-07-30 13:43:21 +00:00
|
|
|
}
|
|
|
|
if {$t == $::skip_till} {
|
|
|
|
set skipping 0
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if {$skipping} {
|
|
|
|
puts "test $::skip_till not found"
|
|
|
|
exit 0
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-08-31 08:05:30 +00:00
|
|
|
# If --skipunits option was given, we populate the list of single tests
|
|
|
|
# to run with everything *not* in the skipunits list.
|
|
|
|
if {[llength $::skipunits] > 0} {
|
|
|
|
foreach t $::all_tests {
|
|
|
|
if {[lsearch $::skipunits $t] != -1} {
|
|
|
|
lremove filtered_tests $t
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-31 15:28:30 +00:00
|
|
|
# Override the list of tests with the specific tests we want to run
|
2020-08-31 08:05:30 +00:00
|
|
|
# in case there was some filter, that is --single, -skipunit or --skip-till options.
|
|
|
|
if {[llength $filtered_tests] < [llength $::all_tests]} {
|
|
|
|
set ::all_tests $filtered_tests
|
2018-07-30 13:43:21 +00:00
|
|
|
}
|
|
|
|
|
2022-10-16 05:30:01 +00:00
|
|
|
proc attach_to_replication_stream_on_connection {conn} {
|
2021-01-25 09:05:25 +00:00
|
|
|
r config set repl-ping-replica-period 3600
|
2019-09-12 07:56:54 +00:00
|
|
|
if {$::tls} {
|
2022-10-16 05:30:01 +00:00
|
|
|
set s [::tls::socket [srv $conn "host"] [srv $conn "port"]]
|
2019-09-12 07:56:54 +00:00
|
|
|
} else {
|
2022-10-16 05:30:01 +00:00
|
|
|
set s [socket [srv $conn "host"] [srv $conn "port"]]
|
2019-09-12 07:56:54 +00:00
|
|
|
}
|
2013-03-27 10:29:47 +00:00
|
|
|
fconfigure $s -translation binary
|
|
|
|
puts -nonewline $s "SYNC\r\n"
|
|
|
|
flush $s
|
|
|
|
|
|
|
|
# Get the count
|
2015-10-07 20:32:24 +00:00
|
|
|
while 1 {
|
|
|
|
set count [gets $s]
|
|
|
|
set prefix [string range $count 0 0]
|
|
|
|
if {$prefix ne {}} break; # Newlines are allowed as PINGs.
|
|
|
|
}
|
2013-03-27 10:29:47 +00:00
|
|
|
if {$prefix ne {$}} {
|
|
|
|
error "attach_to_replication_stream error. Received '$count' as count."
|
|
|
|
}
|
|
|
|
set count [string range $count 1 end]
|
|
|
|
|
|
|
|
# Consume the bulk payload
|
|
|
|
while {$count} {
|
|
|
|
set buf [read $s $count]
|
|
|
|
set count [expr {$count-[string length $buf]}]
|
|
|
|
}
|
|
|
|
return $s
|
|
|
|
}
|
|
|
|
|
2022-10-16 05:30:01 +00:00
|
|
|
proc attach_to_replication_stream {} {
|
|
|
|
return [attach_to_replication_stream_on_connection 0]
|
|
|
|
}
|
|
|
|
|
2013-03-27 10:29:47 +00:00
|
|
|
proc read_from_replication_stream {s} {
|
|
|
|
fconfigure $s -blocking 0
|
|
|
|
set attempt 0
|
|
|
|
while {[gets $s count] == -1} {
|
|
|
|
if {[incr attempt] == 10} return ""
|
|
|
|
after 100
|
|
|
|
}
|
|
|
|
fconfigure $s -blocking 1
|
|
|
|
set count [string range $count 1 end]
|
|
|
|
|
|
|
|
# Return a list of arguments for the command.
|
|
|
|
set res {}
|
|
|
|
for {set j 0} {$j < $count} {incr j} {
|
|
|
|
read $s 1
|
2024-04-18 13:57:17 +00:00
|
|
|
set arg [::valkey::valkey_bulk_read $s]
|
2013-03-27 10:29:47 +00:00
|
|
|
if {$j == 0} {set arg [string tolower $arg]}
|
|
|
|
lappend res $arg
|
|
|
|
}
|
|
|
|
return $res
|
|
|
|
}
|
|
|
|
|
|
|
|
proc assert_replication_stream {s patterns} {
|
2023-03-08 20:39:54 +00:00
|
|
|
set errors 0
|
|
|
|
set values_list {}
|
|
|
|
set patterns_list {}
|
2013-03-27 10:29:47 +00:00
|
|
|
for {set j 0} {$j < [llength $patterns]} {incr j} {
|
2023-03-08 20:39:54 +00:00
|
|
|
set pattern [lindex $patterns $j]
|
|
|
|
lappend patterns_list $pattern
|
|
|
|
set value [read_from_replication_stream $s]
|
|
|
|
lappend values_list $value
|
|
|
|
if {![string match $pattern $value]} { incr errors }
|
2013-03-27 10:29:47 +00:00
|
|
|
}
|
2023-03-08 20:39:54 +00:00
|
|
|
|
|
|
|
if {$errors == 0} { return }
|
|
|
|
|
|
|
|
set context [info frame -1]
|
|
|
|
close_replication_stream $s ;# for fast exit
|
|
|
|
assert_match $patterns_list $values_list "" $context
|
2013-03-27 10:29:47 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
proc close_replication_stream {s} {
|
|
|
|
close $s
|
2021-01-25 09:05:25 +00:00
|
|
|
r config set repl-ping-replica-period 10
|
2021-06-09 12:13:24 +00:00
|
|
|
return
|
2013-03-27 10:29:47 +00:00
|
|
|
}
|
|
|
|
|
2024-04-09 08:24:03 +00:00
|
|
|
# With the parallel test running multiple server instances at the same time
|
2012-05-11 15:26:09 +00:00
|
|
|
# we need a fast enough computer, otherwise a lot of tests may generate
|
|
|
|
# false positives.
|
2013-08-07 14:05:09 +00:00
|
|
|
# If the computer is too slow we revert the sequential test without any
|
2012-05-11 15:26:09 +00:00
|
|
|
# parallelism, that is, clients == 1.
|
|
|
|
proc is_a_slow_computer {} {
|
|
|
|
set start [clock milliseconds]
|
|
|
|
for {set j 0} {$j < 1000000} {incr j} {}
|
|
|
|
set elapsed [expr [clock milliseconds]-$start]
|
|
|
|
expr {$elapsed > 200}
|
|
|
|
}
|
|
|
|
|
2011-07-10 21:25:48 +00:00
|
|
|
if {$::client} {
|
|
|
|
if {[catch { test_client_main $::test_server_port } err]} {
|
|
|
|
set estr "Executing test client: $err.\n$::errorInfo"
|
|
|
|
if {[catch {send_data_packet $::test_server_fd exception $estr}]} {
|
|
|
|
puts $estr
|
2010-06-02 19:20:29 +00:00
|
|
|
}
|
|
|
|
exit 1
|
|
|
|
}
|
2011-07-10 21:25:48 +00:00
|
|
|
} else {
|
2012-05-11 15:26:09 +00:00
|
|
|
if {[is_a_slow_computer]} {
|
|
|
|
puts "** SLOW COMPUTER ** Using a single client to avoid false positives."
|
|
|
|
set ::numclients 1
|
|
|
|
}
|
|
|
|
|
2011-07-10 21:25:48 +00:00
|
|
|
if {[catch { test_server_main } err]} {
|
|
|
|
if {[string length $err] > 0} {
|
|
|
|
# only display error when not generated by the test suite
|
|
|
|
if {$err ne "exception"} {
|
|
|
|
puts $::errorInfo
|
|
|
|
}
|
|
|
|
exit 1
|
|
|
|
}
|
|
|
|
}
|
2010-06-02 19:20:29 +00:00
|
|
|
}
|