mirrors/valkey
1
0
Fork 0
mirror of http://github.com/valkey-io/valkey synced 2024-11-21 08:37:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change default pidfile from redis.pid to valkey.pid (#378)

Browse Source 
Changes the default value for the `pidfile` config.

The template config file `valkey.conf` already contains `pidfile
/var/run/valkey_6379.pid`. This is not a default. The default is what
you get when you start valkey without config.

Tests suites config pidfile changed to valkey accordingly.

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
This commit is contained in:
Shivshankar 2024-04-30 12:45:08 -04:00 committed by GitHub
parent 6e05d0fcb1
commit 0cb97653b7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/server.h
View File

@ -129,7 +129,7 @@ struct hdr_histogram;
#define RDB_EOF_MARK_SIZE 40 #define RDB_EOF_MARK_SIZE 40
#define CONFIG_REPL_BACKLOG_MIN_SIZE (1024*16) /* 16k */ #define CONFIG_REPL_BACKLOG_MIN_SIZE (1024*16) /* 16k */
#define CONFIG_BGSAVE_RETRY_DELAY 5 /* Wait a few secs before trying again. */ #define CONFIG_BGSAVE_RETRY_DELAY 5 /* Wait a few secs before trying again. */
#define CONFIG_DEFAULT_PID_FILE "/var/run/redis.pid" #define CONFIG_DEFAULT_PID_FILE "/var/run/valkey.pid"
#define CONFIG_DEFAULT_BINDADDR_COUNT 2 #define CONFIG_DEFAULT_BINDADDR_COUNT 2
#define CONFIG_DEFAULT_BINDADDR { "*", "-::*" } #define CONFIG_DEFAULT_BINDADDR { "*", "-::*" }
#define NET_HOST_STR_LEN 256 /* Longest valid hostname */ #define NET_HOST_STR_LEN 256 /* Longest valid hostname */

2
tests/assets/default.conf
View File

@ -3,7 +3,7 @@
always-show-logo yes always-show-logo yes
notify-keyspace-events KEA notify-keyspace-events KEA
daemonize no daemonize no
pidfile /var/run/redis.pid pidfile /var/run/valkey.pid
port 6379 port 6379
timeout 0 timeout 0
bind 127.0.0.1 bind 127.0.0.1

2
tests/assets/minimal.conf
View File

@ -1,5 +1,5 @@
# Minimal configuration for testing. # Minimal configuration for testing.
always-show-logo yes always-show-logo yes
daemonize no daemonize no
pidfile /var/run/redis.pid pidfile /var/run/valkey.pid
loglevel verbose loglevel verbose

2
valkey.conf
View File

@ -329,7 +329,7 @@ daemonize no
# #
# When the server runs non daemonized, no pid file is created if none is # When the server runs non daemonized, no pid file is created if none is
# specified in the configuration. When the server is daemonized, the pid file # specified in the configuration. When the server is daemonized, the pid file
# is used even if not specified, defaulting to "/var/run/redis.pid". # is used even if not specified, defaulting to "/var/run/valkey.pid".
# #
# Creating a pid file is best effort: if the server is not able to create it # Creating a pid file is best effort: if the server is not able to create it
# nothing bad happens, the server will start and run normally. # nothing bad happens, the server will start and run normally.