mirrors/valkey
1
0
Fork 0
mirror of http://github.com/valkey-io/valkey synced 2024-11-22 18:54:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

EXPIRE precision test more attempts and more tolerant (#12150)

Browse Source 
The test failed on MacOS:
```
*** [err]: EXPIRE precision is now the millisecond in tests/unit/expire.tcl
Expected 'somevalue {}' to equal or match '{} {}'
```

`set a [r get x]`, even though we tried 10 times, sometimes we
still get {}, this is a time-sensitive test.

In this PR, we add the following changes:
1. More attempts, change it from 10 to 30.
2. More tolerant, change the `after 900` to `after 800`.

In addition, we judging $a in advance and changing `after 1100`
to `after 300`, this will save us some times.
This commit is contained in:
Binbin 2023-05-09 19:14:22 +08:00 committed by GitHub
parent 9b53cb28d6
commit 6ab2174d37
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/unit/expire.tcl
View File

@ -76,20 +76,22 @@ start_server {tags {"expire"}} {
# This test is very likely to do a false positive if the
# server is under pressure, so if it does not work give it a few more
# chances.
for {set j 0} {$j < 10} {incr j} {
for {set j 0} {$j < 30} {incr j} {
r del x
r setex x 1 somevalue
after 900
after 800
set a [r get x]
after 1100
if {$a ne {somevalue}} continue
after 300
set b [r get x]
if {$a eq {somevalue} && $b eq {}} break
if {$b eq {}} break
}
if {$::verbose} {
puts "millisecond expire test attempts: $j"
}
list $a $b
} {somevalue {}}
assert_equal $a {somevalue}
assert_equal $b {}
}
test "PSETEX can set sub-second expires" {
# This test is very likely to do a false positive if the server is