mirrors/valkey
1
0
Fork 0
mirror of http://github.com/valkey-io/valkey synced 2024-11-22 18:54:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix outdated comment about flags in moduleCreateArgvFromUserFormat (#10781)

Browse Source 
Clearly more than one flag exists, also fixed some typos.
Fixes #10776
This commit is contained in:
Binbin 2022-05-26 22:34:17 +08:00 committed by GitHub
parent f28e2ce7a4
commit 6f7c1a8ce6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/functions.c
View File

@ -325,7 +325,7 @@ static void libraryLink(functionsLibCtx *lib_ctx, functionLibInfo* li) {
/* Takes all libraries from lib_ctx_src and add to lib_ctx_dst. /* Takes all libraries from lib_ctx_src and add to lib_ctx_dst.
* On collision, if 'replace' argument is true, replace the existing library with the new one. * On collision, if 'replace' argument is true, replace the existing library with the new one.
* Otherwise abort and leave 'lib_ctx_dst' and 'lib_ctx_src' untouched. * Otherwise abort and leave 'lib_ctx_dst' and 'lib_ctx_src' untouched.
* Return C_OK on success and C_ERR if aborted. If C_ERR is retunred, set a relevant * Return C_OK on success and C_ERR if aborted. If C_ERR is returned, set a relevant
* error message on the 'err' out parameter. * error message on the 'err' out parameter.
* */ * */
static int libraryJoin(functionsLibCtx *functions_lib_ctx_dst, functionsLibCtx *functions_lib_ctx_src, int replace, sds *err) { static int libraryJoin(functionsLibCtx *functions_lib_ctx_dst, functionsLibCtx *functions_lib_ctx_src, int replace, sds *err) {

2
src/module.c
View File

@ -5549,7 +5549,7 @@ RedisModuleString *RM_CreateStringFromCallReply(RedisModuleCallReply *reply) {
* items and *argvlenp with the length of the allocated argv. * items and *argvlenp with the length of the allocated argv.
* *
* The integer pointed by 'flags' is populated with flags according * The integer pointed by 'flags' is populated with flags according
* to special modifiers in "fmt". For now only one exists: * to special modifiers in "fmt".
* *
* "!" -> REDISMODULE_ARGV_REPLICATE * "!" -> REDISMODULE_ARGV_REPLICATE
* "A" -> REDISMODULE_ARGV_NO_AOF * "A" -> REDISMODULE_ARGV_NO_AOF

2
tests/README.md
View File

@ -38,7 +38,7 @@ The following compatibility and capability tags are currently used:
| `external:skip` | Not compatible with external servers. | | `external:skip` | Not compatible with external servers. |
| `cluster:skip` | Not compatible with `--cluster-mode`. | | `cluster:skip` | Not compatible with `--cluster-mode`. |
| `large-memory` | Test that requires more than 100mb | | `large-memory` | Test that requires more than 100mb |
| `tls:skip` | Not campatible with `--tls`. | | `tls:skip` | Not compatible with `--tls`. |
| `needs:repl` | Uses replication and needs to be able to `SYNC` from server. | | `needs:repl` | Uses replication and needs to be able to `SYNC` from server. |
| `needs:debug` | Uses the `DEBUG` command or other debugging focused commands (like `OBJECT`). | | `needs:debug` | Uses the `DEBUG` command or other debugging focused commands (like `OBJECT`). |
| `needs:pfdebug` | Uses the `PFDEBUG` command. | | `needs:pfdebug` | Uses the `PFDEBUG` command. |

2
tests/unit/tracking.tcl
View File

@ -369,7 +369,7 @@ start_server {tags {"tracking network"}} {
$r CLIENT TRACKING OFF $r CLIENT TRACKING OFF
} }
test {hdel deliver invlidate message after response in the same connection} { test {hdel deliver invalidate message after response in the same connection} {
r CLIENT TRACKING off r CLIENT TRACKING off
r HELLO 3 r HELLO 3
r CLIENT TRACKING on r CLIENT TRACKING on