mirrors/valkey
1
0
Fork 0
mirror of http://github.com/valkey-io/valkey synced 2024-11-21 16:46:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stabilize replica migration test to make sure cluster config is consistent (#1311)

Browse Source 
CI report this failure:
```
[exception]: Executing test client: MOVED 1 127.0.0.1:22128.
MOVED 1 127.0.0.1:22128
    while executing
"wait_for_condition 1000 50 {
            [R 3 get key_991803] == 1024 && [R 3 get key_977613] == 10240 &&
            [R 4 get key_991803] == 1024 && ..."
```

This may be because, even though the cluster state becomes OK,
The cluster still has inconsistent configuration for a short period
of time. We make sure to wait for the config to be consistent.

Signed-off-by: Binbin <binloveplay1314@qq.com>
This commit is contained in:
Binbin 2024-11-16 18:58:25 +08:00 committed by GitHub
parent 86f33ea2b0
commit aa2dd3ecb8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/unit/cluster/replica-migration.tcl
View File

@ -90,6 +90,8 @@ proc test_migrated_replica {type} {
# Wait for the cluster to be ok.
wait_for_condition 1000 50 {
[R 3 cluster slots] eq [R 4 cluster slots] &&
[R 4 cluster slots] eq [R 7 cluster slots] &&
[CI 3 cluster_state] eq "ok" &&
[CI 4 cluster_state] eq "ok" &&
[CI 7 cluster_state] eq "ok"
@ -187,6 +189,7 @@ proc test_nonempty_replica {type} {
# Wait for the cluster to be ok.
wait_for_condition 1000 50 {
[R 4 cluster slots] eq [R 7 cluster slots] &&
[CI 4 cluster_state] eq "ok" &&
[CI 7 cluster_state] eq "ok"
} else {
@ -306,6 +309,8 @@ proc test_sub_replica {type} {
# Wait for the cluster to be ok.
wait_for_condition 1000 50 {
[R 3 cluster slots] eq [R 4 cluster slots] &&
[R 4 cluster slots] eq [R 7 cluster slots] &&
[CI 3 cluster_state] eq "ok" &&
[CI 4 cluster_state] eq "ok" &&
[CI 7 cluster_state] eq "ok"