mirrors/valkey
1
0
Fork 0
mirror of http://github.com/valkey-io/valkey synced 2024-11-23 03:33:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Trim trailing spaces in error replies coming from rejectCommand (#7668)

Browse Source 
65a3307bc9 added rejectCommand which takes an robj reply and passes it
through addReplyErrorSafe to addReplyErrorLength.
The robj contains newline at it's end, but addReplyErrorSafe converts it
to spaces, and passes it to addReplyErrorLength which adds the protocol
newlines.

The result was that most error replies (like OOM) had extra two trailing
spaces in them.
This commit is contained in:
Oran Agra 2020-08-18 08:28:43 +03:00 committed by GitHub
parent 64c360c515
commit cdd925b289
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/networking.c
View File

@ -412,10 +412,14 @@ void addReplyError(client *c, const char *err) {
* is emitted. */ * is emitted. */
void addReplyErrorSafe(client *c, char *s, size_t len) { void addReplyErrorSafe(client *c, char *s, size_t len) {
size_t j; size_t j;
/* Trim any newlines at the end (ones will be added by addReplyErrorLength) */
while (s[len-1] == '\r' || s[len-1] == '\n')
len--;
/* Replace any newlines in the rest of the string with spaces. */
for (j = 0; j < len; j++) { for (j = 0; j < len; j++) {
if (s[j] == '\r' || s[j] == '\n') s[j] = ' '; if (s[j] == '\r' || s[j] == '\n') s[j] = ' ';
} }
addReplyErrorLength(c,s,sdslen(s)); addReplyErrorLength(c,s,len);
} }
void addReplyErrorFormat(client *c, const char *fmt, ...) { void addReplyErrorFormat(client *c, const char *fmt, ...) {