mirror of
http://github.com/valkey-io/valkey
synced 2024-11-22 00:52:38 +00:00
PSYNC2: Create backlog on slave partial sync as well.
A slave may be started with an RDB file able to provide enough slave to perform a successful partial SYNC with its master. However in such a case, how outlined in issue #4268, the slave backlog will not be started, since it was only initialized on full syncs attempts. This creates different problems with successive PSYNC attempts that will always result in full synchronizations. Thanks to @fdingiit for discovering the issue.
This commit is contained in:
parent
0c0b77d149
commit
f1a2cbfd6e
@ -1531,6 +1531,11 @@ int slaveTryPartialResynchronization(int fd, int read_reply) {
|
||||
/* Setup the replication to continue. */
|
||||
sdsfree(reply);
|
||||
replicationResurrectCachedMaster(fd);
|
||||
|
||||
/* If this instance was restarted and we read the metadata to
|
||||
* PSYNC from the persistence file, our replication backlog could
|
||||
* be still not initialized. Create it. */
|
||||
if (server.repl_backlog == NULL) createReplicationBacklog();
|
||||
return PSYNC_CONTINUE;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user