Go to file
Binbin 5d97f5133c
Fix CLUSTER SETSLOT block and unblock error when all replicas are down (#879)
In CLUSTER SETSLOT propagation logic, if the replicas are down, the
client will get block during command processing and then unblock
with `NOREPLICAS Not enough good replicas to write`.

The reason is that all replicas are down (or some are down), but
myself->num_replicas is including all replicas, so the client will
get block and always get timeout.

We should only wait for those online replicas, otherwise the waiting
propagation will always timeout since there are not enough replicas.
The admin can easily check if there are replicas that are down for an
extended period of time. If they decide to move forward anyways, we
should not block it. If a replica  failed right before the replication and
was not included in the replication, it would also unlikely win the election.

Signed-off-by: Binbin <binloveplay1314@qq.com>
Co-authored-by: Ping Xie <pingxie@google.com>
2024-08-23 16:21:53 +08:00
.config Format yaml files (#615) 2024-06-14 13:40:06 -07:00
.github Skip tracking clients OOM test when I/O threads are enabled (#764) 2024-08-21 17:02:57 -07:00
deps Copyright update to reflect IP transfer from salvatore to Redis (#740) 2024-08-14 09:20:36 -07:00
src Fix CLUSTER SETSLOT block and unblock error when all replicas are down (#879) 2024-08-23 16:21:53 +08:00
tests Fix CLUSTER SETSLOT block and unblock error when all replicas are down (#879) 2024-08-23 16:21:53 +08:00
utils Copyright update to reflect IP transfer from salvatore to Redis (#740) 2024-08-14 09:20:36 -07:00
.gitattributes Fix commands.c build issue on merge (#10172) 2022-01-25 12:24:06 +02:00
.gitignore Introduce Valkey Over RDMA transport (experimental) (#477) 2024-07-15 14:04:22 +02:00
00-RELEASENOTES Changed links and naming to valkey instead of redis (#389) 2024-05-02 14:53:37 +02:00
BUGS Update naming to to Valkey (#62) 2024-03-28 09:58:28 -07:00
CODE_OF_CONDUCT.md Update CODE_OF_CONDUCT.md (#5) 2024-03-22 08:12:45 +01:00
codecov.yml Format yaml files (#615) 2024-06-14 13:40:06 -07:00
CONTRIBUTING.md Initial PR outlining the governance for the project (#345) 2024-04-30 14:57:21 -07:00
COPYING Copyright update to reflect IP transfer from salvatore to Redis (#740) 2024-08-14 09:20:36 -07:00
GOVERNANCE.md Initial PR outlining the governance for the project (#345) 2024-04-30 14:57:21 -07:00
INSTALL INSTALL now redirects the user to README 2012-02-05 09:38:41 +01:00
MAINTAINERS.md Initial PR outlining the governance for the project (#345) 2024-04-30 14:57:21 -07:00
Makefile Replace offensive term (#86) 2024-03-30 14:23:50 +01:00
MANIFESTO Changed links and naming to valkey instead of redis (#389) 2024-05-02 14:53:37 +02:00
README.md Update README.md file to reference valkey.io (#931) 2024-08-21 14:19:50 -07:00
runtest Replace Valkey in runtest scripts error prints (#190) 2024-04-03 16:17:38 -07:00
runtest-cluster Replace Valkey in runtest scripts error prints (#190) 2024-04-03 16:17:38 -07:00
runtest-moduleapi Replace Valkey in runtest scripts error prints (#190) 2024-04-03 16:17:38 -07:00
runtest-rdma Introduce Valkey Over RDMA transport (experimental) (#477) 2024-07-15 14:04:22 +02:00
runtest-sentinel Replace Valkey in runtest scripts error prints (#190) 2024-04-03 16:17:38 -07:00
SECURITY.md Fix typo in SECURITY.md (#309) 2024-04-12 11:05:39 -04:00
sentinel.conf Update sentinel conf access string to allow hello channel access (#854) 2024-08-03 23:32:53 +08:00
TLS.md Improve TLS.md configuration instructions (#385) 2024-05-03 20:13:10 +02:00
valkey.conf Set repl-backlog-size from 1mb to 10mb by default (#911) 2024-08-21 11:59:02 -04:00

codecov

This project was forked from the open source Redis project right before the transition to their new source available licenses.

This README is just a fast quick start document. More details can be found under valkey.io

What is Valkey?

Valkey is a high-performance data structure server that primarily serves key/value workloads. It supports a wide range of native structures and an extensible plugin system for adding new data structures and access patterns.

Building Valkey

Valkey can be compiled and used on Linux, OSX, OpenBSD, NetBSD, FreeBSD. We support big endian and little endian architectures, and both 32 bit and 64 bit systems.

It may compile on Solaris derived systems (for instance SmartOS) but our support for this platform is best effort and Valkey is not guaranteed to work as well as in Linux, OSX, and *BSD.

It is as simple as:

% make

To build with TLS support, you'll need OpenSSL development libraries (e.g. libssl-dev on Debian/Ubuntu) and run:

% make BUILD_TLS=yes

To build with experimental RDMA support you'll need RDMA development libraries (e.g. librdmacm-dev and libibverbs-dev on Debian/Ubuntu). For now, Valkey only supports RDMA as connection module mode. Run:

% make BUILD_RDMA=module

To build with systemd support, you'll need systemd development libraries (such as libsystemd-dev on Debian/Ubuntu or systemd-devel on CentOS) and run:

% make USE_SYSTEMD=yes

To append a suffix to Valkey program names, use:

% make PROG_SUFFIX="-alt"

You can build a 32 bit Valkey binary using:

% make 32bit

After building Valkey, it is a good idea to test it using:

% make test

If TLS is built, running the tests with TLS enabled (you will need tcl-tls installed):

% ./utils/gen-test-certs.sh
% ./runtest --tls

Fixing build problems with dependencies or cached build options

Valkey has some dependencies which are included in the deps directory. make does not automatically rebuild dependencies even if something in the source code of dependencies changes.

When you update the source code with git pull or when code inside the dependencies tree is modified in any other way, make sure to use the following command in order to really clean everything and rebuild from scratch:

% make distclean

This will clean: jemalloc, lua, hiredis, linenoise and other dependencies.

Also if you force certain build options like 32bit target, no C compiler optimizations (for debugging purposes), and other similar build time options, those options are cached indefinitely until you issue a make distclean command.

Fixing problems building 32 bit binaries

If after building Valkey with a 32 bit target you need to rebuild it with a 64 bit target, or the other way around, you need to perform a make distclean in the root directory of the Valkey distribution.

In case of build errors when trying to build a 32 bit binary of Valkey, try the following steps:

  • Install the package libc6-dev-i386 (also try g++-multilib).
  • Try using the following command line instead of make 32bit: make CFLAGS="-m32 -march=native" LDFLAGS="-m32"

Allocator

Selecting a non-default memory allocator when building Valkey is done by setting the MALLOC environment variable. Valkey is compiled and linked against libc malloc by default, with the exception of jemalloc being the default on Linux systems. This default was picked because jemalloc has proven to have fewer fragmentation problems than libc malloc.

To force compiling against libc malloc, use:

% make MALLOC=libc

To compile against jemalloc on Mac OS X systems, use:

% make MALLOC=jemalloc

Monotonic clock

By default, Valkey will build using the POSIX clock_gettime function as the monotonic clock source. On most modern systems, the internal processor clock can be used to improve performance. Cautions can be found here: http://oliveryang.net/2015/09/pitfalls-of-TSC-usage/

To build with support for the processor's internal instruction clock, use:

% make CFLAGS="-DUSE_PROCESSOR_CLOCK"

Verbose build

Valkey will build with a user-friendly colorized output by default. If you want to see a more verbose output, use the following:

% make V=1

Running Valkey

To run Valkey with the default configuration, just type:

% cd src
% ./valkey-server

If you want to provide your valkey.conf, you have to run it using an additional parameter (the path of the configuration file):

% cd src
% ./valkey-server /path/to/valkey.conf

It is possible to alter the Valkey configuration by passing parameters directly as options using the command line. Examples:

% ./valkey-server --port 9999 --replicaof 127.0.0.1 6379
% ./valkey-server /etc/valkey/6379.conf --loglevel debug

All the options in valkey.conf are also supported as options using the command line, with exactly the same name.

Running Valkey with TLS:

Please consult the TLS.md file for more information on how to use Valkey with TLS.

Running Valkey with RDMA:

Note that Valkey Over RDMA is an experimental feature. It may be changed or removed in any minor or major version. Currently, it is only supported on Linux.

To manually run a Valkey server with RDMA mode:

% ./src/valkey-server --protected-mode no \
     --loadmodule src/valkey-rdma.so bind=192.168.122.100 port=6379

It's possible to change bind address/port of RDMA by runtime command:

192.168.122.100:6379> CONFIG SET rdma.port 6380

It's also possible to have both RDMA and TCP available, and there is no conflict of TCP(6379) and RDMA(6379), Ex:

% ./src/valkey-server --protected-mode no \
     --loadmodule src/valkey-rdma.so bind=192.168.122.100 port=6379 \
     --port 6379

Note that the network card (192.168.122.100 of this example) should support RDMA. To test a server supports RDMA or not:

% rdma res show (a new version iproute2 package)

Or:

% ibv_devices

Playing with Valkey

You can use valkey-cli to play with Valkey. Start a valkey-server instance, then in another terminal try the following:

% cd src
% ./valkey-cli
valkey> ping
PONG
valkey> set foo bar
OK
valkey> get foo
"bar"
valkey> incr mycounter
(integer) 1
valkey> incr mycounter
(integer) 2
valkey>

Installing Valkey

In order to install Valkey binaries into /usr/local/bin, just use:

% make install

You can use make PREFIX=/some/other/directory install if you wish to use a different destination.

Note: For compatibility with Redis, we create symlinks from the Redis names (redis-server, redis-cli, etc.) to the Valkey binaries installed by make install. The symlinks are created in same directory as the Valkey binaries. The symlinks are removed when using make uninstall. The creation of the symlinks can be skipped by setting the makefile variable USE_REDIS_SYMLINKS=no.

make install will just install binaries in your system, but will not configure init scripts and configuration files in the appropriate place. This is not needed if you just want to play a bit with Valkey, but if you are installing it the proper way for a production system, we have a script that does this for Ubuntu and Debian systems:

% cd utils
% ./install_server.sh

Note: install_server.sh will not work on Mac OSX; it is built for Linux only.

The script will ask you a few questions and will setup everything you need to run Valkey properly as a background daemon that will start again on system reboots.

You'll be able to stop and start Valkey using the script named /etc/init.d/valkey_<portnumber>, for instance /etc/init.d/valkey_6379.

Code contributions

Please see the CONTRIBUTING.md. For security bugs and vulnerabilities, please see SECURITY.md.

Valkey is an open community project under LF Projects

Valkey a Series of LF Projects, LLC 2810 N Church St, PMB 57274 Wilmington, Delaware 19802-4447