valkey/tests
Binbin 61cf011388 Fix the bug that CLIENT REPLY OFF|SKIP cannot receive push notifications (#11875)
This bug seems to be there forever, CLIENT REPLY OFF|SKIP will
mark the client with CLIENT_REPLY_OFF or CLIENT_REPLY_SKIP flags.
With these flags, prepareClientToWrite called by addReply* will
return C_ERR directly. So the client can't receive the Pub/Sub
messages and any other push notifications, e.g client side tracking.

In this PR, we adding a CLIENT_PUSHING flag, disables the reply
silencing flags. When adding push replies, set the flag, after the reply,
clear the flag. Then add the flag check in prepareClientToWrite.

Fixes #11874

Note, the SUBSCRIBE command response is a bit awkward,
see https://github.com/redis/redis-doc/pull/2327

Co-authored-by: Oran Agra <oran@redislabs.com>
(cherry picked from commit 416842e6c0)
(cherry picked from commit f8ae7a414c)
(cherry picked from commit 96814a32da61e5ed523864e00609a4aa6be065b3)
2023-04-17 15:54:33 +03:00
..
assets
cluster fix race in cluster transactions test (#8312) 2021-01-12 16:25:37 +02:00
helpers
integration fflush stdout after responses partial backport from (#9136) 2023-01-17 14:59:41 +02:00
modules Fix test modules build issue on OS X 11. (#9658) 2023-01-17 14:59:41 +02:00
sentinel
support Fix the bug that CLIENT REPLY OFF|SKIP cannot receive push notifications (#11875) 2023-04-17 15:54:33 +03:00
tmp
unit Fix the bug that CLIENT REPLY OFF|SKIP cannot receive push notifications (#11875) 2023-04-17 15:54:33 +03:00
instances.tcl
test_helper.tcl