mirror of
http://github.com/valkey-io/valkey
synced 2024-11-22 09:17:20 +00:00
acf3495eb8
Writable replicas now no longer use the values of expired keys. Expired keys are deleted when lookupKeyWrite() is used, even on a writable replica. Previously, writable replicas could use the value of an expired key in write commands such as INCR, SUNIONSTORE, etc.. This commit also sorts out the mess around the functions lookupKeyRead() and lookupKeyWrite() so they now indicate what we intend to do with the key and are not affected by the command calling them. Multi-key commands like SUNIONSTORE, ZUNIONSTORE, COPY and SORT with the store option now use lookupKeyRead() for the keys they're reading from (which will not allow reading from logically expired keys). This commit also fixes a bug where PFCOUNT could return a value of an expired key. Test modules commands have their readonly and write flags updated to correctly reflect their lookups for reading or writing. Modules are not required to correctly reflect this in their command flags, but this change is made for consistency since the tests serve as usage examples. Fixes #6842. Fixes #7475.
31 lines
1.1 KiB
C
31 lines
1.1 KiB
C
#include "redismodule.h"
|
|
|
|
/* ZSET.REM key element
|
|
*
|
|
* Removes an occurrence of an element from a sorted set. Replies with the
|
|
* number of removed elements (0 or 1).
|
|
*/
|
|
int zset_rem(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
|
|
if (argc != 3) return RedisModule_WrongArity(ctx);
|
|
RedisModule_AutoMemory(ctx);
|
|
int keymode = REDISMODULE_READ | REDISMODULE_WRITE;
|
|
RedisModuleKey *key = RedisModule_OpenKey(ctx, argv[1], keymode);
|
|
int deleted;
|
|
if (RedisModule_ZsetRem(key, argv[2], &deleted) == REDISMODULE_OK)
|
|
return RedisModule_ReplyWithLongLong(ctx, deleted);
|
|
else
|
|
return RedisModule_ReplyWithError(ctx, "ERR ZsetRem failed");
|
|
}
|
|
|
|
int RedisModule_OnLoad(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
|
|
REDISMODULE_NOT_USED(argv);
|
|
REDISMODULE_NOT_USED(argc);
|
|
if (RedisModule_Init(ctx, "zset", 1, REDISMODULE_APIVER_1) ==
|
|
REDISMODULE_OK &&
|
|
RedisModule_CreateCommand(ctx, "zset.rem", zset_rem, "write",
|
|
1, 1, 1) == REDISMODULE_OK)
|
|
return REDISMODULE_OK;
|
|
else
|
|
return REDISMODULE_ERR;
|
|
}
|