mirrors/zitadel
1
0
Fork 0
mirror of https://github.com/zitadel/zitadel synced 2024-11-22 18:44:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove app name check on ChangeAPIApplication (#1561)

Browse Source 
* fix: remove app name check on ChangeAPIApplication

* fix APIConfigInvalid message
This commit is contained in:
Livio Amstutz 2021-04-09 11:50:06 +02:00 committed by GitHub
parent e7913bde59
commit 188938e937
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/command/project_application_api.go
View File

@ -69,7 +69,7 @@ func (c *Commands) addAPIApplication(ctx context.Context, projectAgg *eventstore
}
func (c *Commands) ChangeAPIApplication(ctx context.Context, apiApp *domain.APIApp, resourceOwner string) (*domain.APIApp, error) {
if !apiApp.IsValid() || apiApp.AppID == "" || apiApp.AggregateID == "" {
if apiApp.AppID == "" || apiApp.AggregateID == "" {
return nil, caos_errs.ThrowInvalidArgument(nil, "COMMAND-1m900", "Errors.Project.App.APIConfigInvalid")
}

21
internal/command/project_application_api_test.go
View File

@ -272,27 +272,6 @@ func TestCommandSide_ChangeAPIApplication(t *testing.T) {
args args
res res
}{
{
name: "invalid app, invalid argument error",
fields: fields{
eventstore: eventstoreExpect(
t,
),
},
args: args{
ctx: context.Background(),
apiApp: &domain.APIApp{
ObjectRoot: models.ObjectRoot{
AggregateID: "project1",
},
AppID: "app1",
},
resourceOwner: "org1",
},
res: res{
err: caos_errs.IsErrorInvalidArgument,
},
},
{
name: "missing appid, invalid argument error",
fields: fields{

2
internal/static/i18n/en.yaml
View File

@ -194,7 +194,7 @@ Errors:
NotActive:: Application is not active
NotInactive: Application is not inactive
OIDCConfigInvalid: OIDC configuration is invalid
APIConfigInvalid: OIDC configuration is invalid
APIConfigInvalid: API configuration is invalid
IsNotOIDC: Application is not type oidc
IsNotAPI: Application is not type API
OIDCAuthMethodNoSecret: Chosen OIDC Auth Method does not require a secret