From 1d542a0c57dd0aa4718c94dd4545cb65e7e547e0 Mon Sep 17 00:00:00 2001
From: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Date: Fri, 18 Sep 2020 10:20:45 +0200
Subject: [PATCH] fix: remove redirect uri validator (#754)

* fix: remove redirect uri validator

* fix: remove redirect uri validator
---
 .../apps/app-create/app-create.component.ts         | 13 ++++++-------
 .../apps/app-detail/app-detail.component.ts         |  5 ++---
 2 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/console/src/app/pages/projects/apps/app-create/app-create.component.ts b/console/src/app/pages/projects/apps/app-create/app-create.component.ts
index 4cb947b31d..ce2e2edb59 100644
--- a/console/src/app/pages/projects/apps/app-create/app-create.component.ts
+++ b/console/src/app/pages/projects/apps/app-create/app-create.component.ts
@@ -19,7 +19,6 @@ import { ManagementService } from 'src/app/services/mgmt.service';
 import { ToastService } from 'src/app/services/toast.service';
 
 import { AppSecretDialogComponent } from '../app-secret-dialog/app-secret-dialog.component';
-import { nativeValidator, webValidator } from '../appTypeValidator';
 
 @Component({
     selector: 'app-app-create',
@@ -120,8 +119,8 @@ export class AppCreateComponent implements OnInit, OnDestroy {
                             [OIDCGrantType.OIDCGRANTTYPE_AUTHORIZATION_CODE];
                         this.oidcApp.authMethodType = OIDCAuthMethodType.OIDCAUTHMETHODTYPE_NONE;
 
-                        this.redirectControl = new FormControl('', [nativeValidator as ValidatorFn]);
-                        this.postRedirectControl = new FormControl('', [nativeValidator as ValidatorFn]);
+                        // this.redirectControl = new FormControl('', [nativeValidator as ValidatorFn]);
+                        // this.postRedirectControl = new FormControl('', [nativeValidator as ValidatorFn]);
                         break;
                     case OIDCApplicationType.OIDCAPPLICATIONTYPE_WEB:
                         this.oidcAuthMethodType[0].disabled = false;
@@ -137,8 +136,8 @@ export class AppCreateComponent implements OnInit, OnDestroy {
                         this.oidcApp.grantTypesList =
                             [OIDCGrantType.OIDCGRANTTYPE_AUTHORIZATION_CODE];
 
-                        this.redirectControl = new FormControl('', [webValidator as ValidatorFn]);
-                        this.postRedirectControl = new FormControl('', [webValidator as ValidatorFn]);
+                        // this.redirectControl = new FormControl('', [webValidator as ValidatorFn]);
+                        // this.postRedirectControl = new FormControl('', [webValidator as ValidatorFn]);
                         break;
                     case OIDCApplicationType.OIDCAPPLICATIONTYPE_USER_AGENT:
                         this.oidcResponseTypes[0].checked = true;
@@ -149,8 +148,8 @@ export class AppCreateComponent implements OnInit, OnDestroy {
 
                         this.oidcApp.authMethodType = OIDCAuthMethodType.OIDCAUTHMETHODTYPE_NONE;
 
-                        this.redirectControl = new FormControl('', [webValidator as ValidatorFn]);
-                        this.postRedirectControl = new FormControl('', [webValidator as ValidatorFn]);
+                        // this.redirectControl = new FormControl('', [webValidator as ValidatorFn]);
+                        // this.postRedirectControl = new FormControl('', [webValidator as ValidatorFn]);
                         break;
                 }
 
diff --git a/console/src/app/pages/projects/apps/app-detail/app-detail.component.ts b/console/src/app/pages/projects/apps/app-detail/app-detail.component.ts
index 2b67d9b22b..a8cf22ce6f 100644
--- a/console/src/app/pages/projects/apps/app-detail/app-detail.component.ts
+++ b/console/src/app/pages/projects/apps/app-detail/app-detail.component.ts
@@ -22,7 +22,6 @@ import { ManagementService } from 'src/app/services/mgmt.service';
 import { ToastService } from 'src/app/services/toast.service';
 
 import { AppSecretDialogComponent } from '../app-secret-dialog/app-secret-dialog.component';
-import { nativeValidator } from '../appTypeValidator';
 
 enum RedirectType {
     REDIRECT = 'redirect',
@@ -134,11 +133,11 @@ export class AppDetailComponent implements OnInit, OnDestroy {
             if (this.app.oidcConfig?.redirectUrisList) {
                 this.redirectUrisList = this.app.oidcConfig.redirectUrisList;
 
-                this.redirectControl = new FormControl('', [nativeValidator as ValidatorFn]);
+                // this.redirectControl = new FormControl('', [nativeValidator as ValidatorFn]);
             }
             if (this.app.oidcConfig?.postLogoutRedirectUrisList) {
                 this.postLogoutRedirectUrisList = this.app.oidcConfig.postLogoutRedirectUrisList;
-                this.postRedirectControl = new FormControl('', [nativeValidator as ValidatorFn]);
+                // this.postRedirectControl = new FormControl('', [nativeValidator as ValidatorFn]);
             }
             if (this.app.oidcConfig) {
                 this.appForm.patchValue(this.app.oidcConfig);