Commit Graph

388 Commits

Author SHA1 Message Date
odedponcz
a00c205b5b
docs: Improve wording in issue reporting (#232)
* docs: Improve wording in issue reporting

Signed-off-by: odedponcz <oded@poncz.com>

* docs: Change contribution doc flow

Signed-off-by: odedponcz <oded@poncz.com>
2022-08-08 10:55:44 +03:00
odedponcz
3b04801cd6
fix: RENAMENX according to spec #229 (#230)
fix: RENAMENX according to spec #226

Signed-off-by: odedponcz <oded@poncz.com>
2022-08-07 22:49:21 +03:00
Roman Gershman
d19fa58216 feat(server): support unix sockets.
Resolves #206. There some minor fixes left to do, but they demand improvements in helio:

1. Remove spurious socket configuration calls that fail on uds.
2. Remove incorrect port printing for uds listener (listener_interface.cc:79).

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-08-02 14:41:18 +03:00
Roman Gershman
cf991deb03 chore(server): add updateval_amount statistic.
This statistic helps understanding how much Dragonfly memory grows via updating the existing value vs the new ones.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-08-02 11:03:46 +03:00
romange
404629258a chore(helm-chart): update to v0.6.0 2022-07-29 05:53:30 +00:00
Roman Gershman
e8cbd41719 fix(build): Fixes #220. 2022-07-28 10:13:48 +03:00
Ikko Ashimine
4ab55675bb docs(README): minor fix
Github -> GitHub
2022-07-27 23:42:26 +03:00
Roman Gershman
b07415ebb8
fix(server): add gitsha to version output. (#217)
This closes #202.
In addition, update helio dependency.
2022-07-27 10:51:18 +03:00
iko1
753c1c0177 feat(server): add pidfile parameter (#209)
Signed-off-by: iko1 <me@remotecpp.dev>
2022-07-27 09:46:28 +03:00
Roman Gershman
f7e58f4de2 fix(pytest): Minor fixes 2022-07-26 17:31:39 +03:00
Roman Gershman
a00d45fb43 fix(bench): Improvements to dash_bench
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-07-20 07:05:13 +03:00
Roman Gershman
3bbdb8e4b1
feat(journal): Introduce basic journal support. (#211)
1. No entries data is written into a journal yet.
2. Introduced a state machine to start and stop journal using a new auxillary command "dfly".
3. string_family currently calls an universal command Journal::RecordEntry that should
   save the current key/value of that entry. Please note that we won't use it for all the operations
   because for some it's more efficient to record the action itself than the final value.
4. no locking information is recorded yet so atomicity of multi-key operations is not preserved for now.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-07-17 21:12:50 +03:00
Roman Gershman
05eb323a0d
fix(server): Fix #207 (#208)
1. Erase expiry data from the expire table in case of evictions.
2. Add test that covers the bug.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-07-15 15:14:20 +03:00
Shmulik Klein
d2b7987ac3
test: flush all records between pytest tests #199 (#205)
test: flush all records between pytest tests
2022-07-13 12:45:29 +03:00
odedponcz
d29425fb2e
feat: Print out dragonfly version and build on startup #202 (#203)
* feat: Print out dragonfly version and build on startup #202

* feat: Print out dragonfly version and build on startup #202
changes after review.
2022-07-12 17:49:27 +03:00
Shmulik Klein
1f2895e991
[WIP] test: add dragonfly_db fixture to python tests #199 (#204)
* test: add dragonfly_db fixture to it tests #199

Signed-off-by: Shmulik Klein <shmulik.klein@gmail.com>

* test: lint using flake8

Signed-off-by: Shmulik Klein <shmulik.klein@gmail.com>

* test: run dragonfly debug version as fallback

Signed-off-by: Shmulik Klein <shmulik.klein@gmail.com>
2022-07-12 17:43:46 +03:00
Joseph Bylund
1cba08891e
docs(README): Document hz flag (#201)
Document hz flag in readme

The hz flag determines how frequently timers used for key eviction are evaluated. Document this flag in the readme.
2022-07-12 13:37:36 +03:00
iko1
7adf80fccd
fix(server): setup sigill handler (#183) (#198)
Signed-off-by: iko1 <me@remotecpp.dev>
2022-07-09 22:36:05 +03:00
iko1
2b0869c16d
fix(server): exit gracefully when iouring not supported (#197)
fix(server): exit gracefully when iouring not supported #181

Signed-off-by: iko1 <me@remotecpp.dev>
2022-07-09 18:44:23 +03:00
Roman Gershman
9e36197742
chore(server): improve error logging if info command fails. (#196)
Related to #195.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-07-09 09:17:42 +03:00
Rom Grk
1c81bfa66c
doc(quick-start): add note for known issues (#194)
doc: update quick-start
2022-07-08 11:25:24 +03:00
Roman Gershman
c5c143525c chore(presubmit): add more useful hooks 2022-07-08 10:23:46 +03:00
Roman Gershman
049f34c89f
chore(rdb): Move object creation during load operation to shard threads. (#193)
This commit fixes the behavior with streams loading and resolves #159.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-07-07 13:39:59 +03:00
Roman Gershman
567af06d2c
fix(action): switch git push to dedicated action (#192)
Docker release pipeline can not push to protected main branch using
the service token. This switches to PAT secret.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-07-06 12:55:10 +03:00
romange
080203ec21 chore(helm-chart): update to v0.4.0 2022-07-05 18:28:37 +00:00
Roman Gershman
c174b3bead
chore(pubsub): update api status (#189)
chore(pubsub): update api status.

Also make subcommand matching for pubsub case insensitive.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-07-04 20:15:27 +03:00
Roman Gershman
55389d9be5
chore(rdb): move object creation during loading to shard threads. (#188)
Related to #159. Before this change, rdb loading thread has been creating all the redis objects as well.
Now we separate rdb file parsing and objects creation. File parsing phase produces a load trace of one or more binary blobs.
Those blobs are then passed to the threads that are responsible to manage the objects.
The second phase is object creation based on the trace that was passed. Finally those binary blobs are destroyed.
As a result, each thread creates objects using the memory allocator it owns and memory stats become consistent.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-07-04 19:08:13 +03:00
Roman Gershman
8cb486a690
chore(dash): add dashtable benchmark. (#187)
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-07-04 16:01:19 +03:00
Zacharya
25becd2d43
feat(pubsub): implement pubsub command close #90 (#175)
* feat(pubsub): implement pubsub command

* fix(pubsub): code review

* fix(pubsub): code review

* fix(pubsub): code review
2022-07-04 15:57:00 +03:00
Roman Gershman
c8fe7ba28b fix(server): Fix serialization logic when returning an empty array.
1. Fix SendStringArr logic. Consolidate both string_view and string variants to using the same code.
2. Tighten the test framework so that it will test that the parser consumed the whole response.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-28 19:51:25 +03:00
Roman Gershman
448d065647
fix(server): Fix a crash when running "client list" command. (#179)
Also, enhance release script to apply linker optimizations when building the binaries.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-26 17:25:42 +03:00
Roman Gershman
605b1fd217
chore(server): Improve the implementation of SendStringArr. (#178)
1. Make it use vectorized send instead of concatenating everything into a single string.
2. vectorized SendStringArr could fail sending large arrays for lengths higher than 512 (returned EMSGSIZE).
   We improved the implementation so it would send those arrays in chunks of 256 items.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-26 06:12:53 +03:00
Ryan Russell
1f42926b7b
docs(docker-compose): Explain NAT overhead in docker-compose (#176)
docs(docker-compose): Explain `NAT` overhead in docker-compose overlay vs host networks

Signed-off-by: Ryan Russell <git@ryanrussell.org>
2022-06-25 21:47:31 +03:00
Luca Goslar
1ba767dc97
fix(docker-compose): Fetch actual Docker Compose file and add memlock conf to service (#173)
docs(docker-compose): Fetch actual Docker Compose file
fix(docker-compose): Add memlock conf to service

Signed-off-by: Luca Goslar <47827429+lucagoslar@users.noreply.github.com>
2022-06-23 18:37:17 +03:00
Philipp B
7446b85bb3
feat(actions): bump helm-chart version when new container image is published (#162)
Signed-off-by: Philipp Born <mail@philipp-born.eu>
2022-06-20 20:25:14 +03:00
Roman Gershman
6b7d2a22df
chore(strings): Simplify Set flow (#164)
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-19 23:19:42 +03:00
Roman Gershman
da3ae760d5 feat(stream): implement rdb save support for streams
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-18 20:08:09 +03:00
Roman Gershman
2d9370c6b2 chore(doc): add dragonfly/memcached benchmark to README
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-17 16:10:08 +03:00
Roman Gershman
d1d64eb014 feat(streams): implement rdb load for streams
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-17 10:27:46 +03:00
Roman Gershman
07b92841fe fix(zmalloc): fix memory accounting of redis types
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-17 06:38:07 +03:00
Roman Gershman
5505ad00f0
fix(parser): Raise parser limit for array length from 8K to 64K (#158)
Add indication of parser errors to info stats.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-16 22:01:40 +03:00
Roman Gershman
32f47be034
fix(lua): Fix few lua-related bugs (#157)
1. Correctly parse keys for EVAL command.
2. Support PUBLISH within lua.
3. Remove spurious failure in debug-mode with the increased verbosity level.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-16 13:41:09 +03:00
Roman Gershman
46220183ae chore(actions): fix docker release pipeline
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-16 09:00:11 +03:00
Roman Gershman
a1c3d8e33d chore(server): Usability improvements
1. Relax processor requirements for Dragonfly. Fixes #124.
2. Introduce cmake option DF_USE_SSL to allow building DF without SSL support. Fixes #128.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-15 19:20:03 +03:00
Roman Gershman
4ec2538204
fix(transaction): Fix rare deadlock case - fixes #150. (#155)
In rare cases a scheduled transaction is not scheduled correctly and we need
to remove it from the tx-queue in order to re-schedule. When we pull it from tx-queue
and it has been located at the head, we must poll-execute the next txs in the queue.

1. Fix the bug.
2. Improve verbosity loggings to make it easier to follow up on tx flow in release mode.
3. Introduce /txz handler that shows currently pending transactions in the queue.
4. Fix a typo in xdel() function.
5. Add a py-script that reproduces the bug.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-15 16:53:27 +03:00
Ryan Russell
f739300415
chore(issues): Add issue templates with links to Discord/Discussions (#152)
Signed-off-by: Ryan Russell <git@ryanrussell.org>
2022-06-15 16:42:26 +03:00
Ryan Russell
55d1c51c8f
docs(readme): Add Discord Channel and Community Link Bar (#151)
Signed-off-by: Ryan Russell <git@ryanrussell.org>
2022-06-15 16:41:06 +03:00
Roman Gershman
d37a0bbc29 fix(zset): Properly convert non-c strings to floats.
The old code relied on c strtod function that expected some sort of delimiter
at the end. Coincidently my unit-testing code always passed proper c strings so
strod worked as expected. EVAL passes slices to non-c string and this is why the bug was
discovered via eval call. Fixes #148.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-15 00:43:39 +03:00
Roman Gershman
ebd0d89dba chore(zset): add additional logs for parse errors 2022-06-14 22:45:01 +03:00
Roman Gershman
c23dc1c94c fix(lua): Avoid infinite loop and fix sha compatibility with redis.
Fixes #146 and fixes #147.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
2022-06-13 23:32:19 +03:00