insomnia/packages/insomnia-app/app/ui/components
Akhil Sasidharan 0b38c68c1f
fix: insomnia open dialog for proto directory can't select directories (#3348)
* fix: insomnia open dialog for proto directory can't select directories

* uses a named export for selectFileOrFolder

(also, removes original js file from rebase)

* clears error by leveraging exhaustiveness check

* fixes bug: the `name` field is actually for a file filter

see the referenced pull request.

As for the `extensions: ['*']`, there's no reason I can see to include a filter and then tell the filter to then accept everything.

* update selectFileOrFolder mocks

* use switch (for exhaustiveness checking) and type selectedFormat

* removes unnecessary filters from _save_ dialog

from the docs:
> The filters specifies an array of file types that can be displayed

As suspected, this is not needed.  A user is free to save it wherever they want.

* adds extension to saved file

not sure why this was missing before, but it appears to have been a bug

* formatting updates

best to "ignore whitespace" for this commit.  I did this with the hope of using the `ThunkAction` type from `redux-thunk`, but once I got them all looking good and started adding the type I quickly learned there's quite a bit more work to do in this area before we can have such a thing.  I therefore opted to just call it a day at that and take the (no-op) formatting changes and typings.

* removes remaining name filters from save dialogs

same reason as the 2nd to prior commit - they cause the bug

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
Co-authored-by: Opender Singh <opender.singh@konghq.com>
2021-05-26 10:24:21 -04:00
..
base fix: insomnia open dialog for proto directory can't select directories (#3348) 2021-05-26 10:24:21 -04:00
buttons [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
codemirror fix spelling (#2976) 2021-05-25 12:16:43 -04:00
dropdowns use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
editors use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
export-requests use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
graph-ql-explorer use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
key-value-editor use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
modals fixes 'previewHidden' of undefined error (#3409) 2021-05-24 10:14:00 -04:00
panes use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
proto-file use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
settings Theme preview tile for OS themes (#3387) 2021-05-19 18:14:11 +12:00
sidebar use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
spec-editor use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
tags [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
templating fix spelling (#2976) 2021-05-25 12:16:43 -04:00
viewers fix: insomnia open dialog for proto directory can't select directories (#3348) 2021-05-26 10:24:21 -04:00
activity-toggle.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
analytics.tsx use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
check-for-updates-button.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
cookie-list.tsx fixes 'previewHidden' of undefined error (#3409) 2021-05-24 10:14:00 -04:00
error-boundary.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
forms.stories.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
grpc-spinner.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
help-tooltip.stories.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
help-tooltip.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
hotkey.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
html-element-wrapper.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
keydown-binder.ts use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
markdown-editor.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
markdown-preview.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
notice.stories.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
notice.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
onboarding-container.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
page-layout.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
rendered-query-string.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
rendered-text.tsx use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
request-url-bar.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
response-timer.tsx ResponseTimer callstack exceeded (#3386) 2021-05-17 18:58:05 -05:00
sync-pull-button.tsx use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
time-from-now.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
toast.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
tooltip.stories.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
tooltip.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
unit-test-editable.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
workspace-page-header.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
wrapper-analytics.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
wrapper-debug.tsx use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
wrapper-design.tsx fixes 'previewHidden' of undefined error (#3409) 2021-05-24 10:14:00 -04:00
wrapper-home.tsx [TypeScript] Phase 1 & 2 (#3370) 2021-05-12 18:35:00 +12:00
wrapper-migration.tsx fix spelling (#2976) 2021-05-25 12:16:43 -04:00
wrapper-onboarding.tsx use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
wrapper-unit-test.tsx use same array-type rule, project-wide (#3395) 2021-05-19 08:32:18 +12:00
wrapper.tsx fixes 'previewHidden' of undefined error (#3409) 2021-05-24 10:14:00 -04:00